From abbb25fd2b9d5bea6ec4d76e5df4a2b7259ece04 Mon Sep 17 00:00:00 2001 From: Francis Deslauriers Date: Mon, 14 Dec 2020 14:56:19 -0500 Subject: [PATCH] event-notifier: Initialize `_notifier_notification` struct to zero Valgrind reports the following use of uninitialized bytes: ==2233138== Syscall param writev(vector[...]) points to uninitialised byte(s) ==2233138== at 0x4EA161D: __writev (writev.c:26) ==2233138== by 0x4EA161D: writev (writev.c:24) ==2233138== by 0x489A9EC: patient_writev (in /usr/local/lib/liblttng-ust.so.0.0.0) ==2233138== by 0x48C2D5F: lttng_event_notifier_notification_send (in /usr/local/lib/liblttng-ust.so.0.0.0) ==2233138== by 0x4033F3: __event_notifier_probe__tp___tptest (in /home/frdeso/projets/lttng/tools/tests/utils/testapp/gen-ust-events/gen-ust-events) ==2233138== by 0x401D6E: main (in /home/frdeso/projets/lttng/tools/tests/utils/testapp/gen-ust-events/gen-ust-events) ==2233138== Address 0x1ffeffedda is on thread 1's stack ==2233138== in frame #2, created by lttng_event_notifier_notification_send (???:) ==2233138== Signed-off-by: Francis Deslauriers Signed-off-by: Mathieu Desnoyers Change-Id: I49ac4b440df61b322ac9614b09c32d1f69beedd0 --- liblttng-ust/event-notifier-notification.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/liblttng-ust/event-notifier-notification.c b/liblttng-ust/event-notifier-notification.c index ed2c8d28..5bbbbd31 100644 --- a/liblttng-ust/event-notifier-notification.c +++ b/liblttng-ust/event-notifier-notification.c @@ -315,7 +315,7 @@ void notification_send(struct lttng_event_notifier_notification *notif, ssize_t ret; size_t content_len; int iovec_count = 1; - struct lttng_ust_event_notifier_notification ust_notif; + struct lttng_ust_event_notifier_notification ust_notif = {0}; struct iovec iov[2]; assert(notif); -- 2.34.1