ansible: Add SLES support to developer role

Change-Id: I710a9fd8f84789bb2617255e045a36f4af784f37
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Add support for SLES in i386-libs role

Change-Id: Ib2629466f055188fb1f5bd7dd0f41496f93775cd
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Allow cloud-init status to complete with an error for images

Change-Id: I7b63d76a9ce61a3cf19b2ab8f75742dde42e51a2
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Correct runcmd to deploy SSH public keys in profiles

`authorized_keys` should be a file, not a directory.

Change-Id: Ia8d250149b77f6e812a311509e70900f2a975c9b
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Reduce output when downloading go during distrobuild

Change-Id: Ia30dc11a07ea691077ca82faa8633ad1068e96e6
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb/ansible: Add support for building SLES images

Change-Id: I89af9759bb7b3c8352ea19f1f6890842cb4efe9a
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Use image type to different vm and container distrobuild images

Our lxd instance doesn't support applying the same alias to multiple
image fingerprints at this time.

Change-Id: Id12ade8f6ea1c00be10bc33528448f5b0c016f37
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Support release specific distrobuilder files

Change-Id: I9f692b483356cc7f6d40f5e39372c7f633b623d3
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Add dev_review_lttng-ust_lttng-tools_master for SLES

Change-Id: I20d3b65b2ffb343a16b92a39fc77f1f958733f1a
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Add support for SLES 12

Change-Id: I5cbc69edd7673e0bc1375f1a6720b96665d5f30f
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Register SLES nodes if necessary

Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Change-Id: Iae950177ebddf2ecec67f9f719d088051cdaee2f

ansible: Activate supplementary SLES repos using suseconnect

Change-Id: I25ce4a9c6a4d47efc478b559adf7bef3c37660fa
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Install compilers on sles nodes

Change-Id: I1c487cc929ab661c091812b7ff6e9730e6bf648d
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Remove corrupted YAML when parsing TAP results on lttng-tools

While `stdbuf` helps, it doesn't guarantee that the YAML sections in
the TAP output are parseable.

Requires: jenkins-job-buidler with the following patch:
https://review.opendev.org/c/jjb/jenkins-job-builder/+/906536

Change-Id: Ibf9780fef5334d1c2abfe4a339776c40e822824a
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Disable TAP timing on slesbuilds of lttng-tools

The tap results regularly have malformed YAML which causes the builds
to fail spuriously.

Change-Id: I53f28d01eb5f126d7d6803846353852bdaf2065f
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Add dev_review_slesbuild for lttng-tools

Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Change-Id: I5b4a78c9c4f28f050bfd19e250a81d7f51083ec7

jjb/ansible: Test lttng-ust-java-agents on slesbuilds

Change-Id: Ie3b77a9ed6276a73bc3446825c5017c67066aff2
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Update host names for SLES ci nodes

Change-Id: Ic52654e46d4e64a2deb5a0f255fa8fb026966c23

jjb: update yocto powerpc and ppc64 to kirkstone

Change-Id: Iab8529b9f716c57e5661779ebfb1ef97d63815e1
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

lava: Use custom timeout function for make check

This allows us to send SIGABRT and get coredumps for the state of the
binaries that are interesting.

Change-Id: I5304b4856a80f25389180b36c6666cf60cfbd4a7
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

Merge "jjb: babeltrace: add shellcheck to lint jobs"

jjb: babeltrace: add shellcheck to lint jobs

Change-Id: Id709f4982c66a11ae0188f257e21a9332c6fb85b
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

ansible: Deploy combined key+cert for haproxy

Change-Id: I7cbb2dee54b8322b1acbcfd440cbbf1efce302d6
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Update internal ssl cert for 2024

Change-Id: I0cc49f9fb2a963f0e12c5e6405da42189e79f750
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: test lttng-modules review jobs with the latest kernel rc

This helps in situations where an RC as just been released and that
the incoming review commit(s) that are run by the CI need to check
that version.

Change-Id: I363469fadeb7c0219c52aa0b4521a45ee0edfd10
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Add docker role for developer nodes

Change-Id: If8df43b443c547f9229c8502146c4c2b9456afc2
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Limit gcc cross from bookworm snapshot to bookworm nodes

Change-Id: I572ec2499555739e7e0245f93bf0ac50efc14f60
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Use a more generic condition for installing linux headers

When building ci-node or developer images, the linux headers weren't
being installed as the node wasn't in the node_standalone group.

When the node is a virtualization host or a KVM guest, the headers
will be installed.

Change-Id: Ic19459fc6c3f7c0b47541ffb194640f01e517986
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Exclude cross compiler packages not available in Debian/i386

Change-Id: I05ee89ccf407b42ee026d3c5eb70549a05037016

ansible: Add support for Debian sid

Change-Id: I1debfebc84926c5a1f0621607a3e706b3b444b65
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Add support for Debian trixie

Change-Id: I7ab2688ae11c71fcfd0893a2fdd1dfaa110bab74
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Add support for Debian 11

Change-Id: Ia6a3202f5fdf130b8fc2103f7ce2c30bbf2af099
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Add jobs for building ci/dev images

Change-Id: I68ec852b8dcf4775966b8bfb4a53e1d539b58d2b
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Remove lttng-analyses role

lttng-analyses is archived and not currently maintained

Change-Id: Iae8c3172255088bec82f34fac907e05d6c206a61
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Remove lttng-analyses jobs

lttng-analyses has been archived and isn't currently maintained

Change-Id: I5d9dc404cfd4557dcab233e814910ee05a1e400d
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Install gcc5 on Debian 12 CI nodes

lttng-modules crossbuilds for arm64 were failing for kernel versions <
4.4, principally due to gcc < 5.1 being explicitly denied in
lttng-modules.

To recover compilation coverage for these versions on this
architecture, gcc 5.5.0 has been built and deployed via ansible on to
the deb12-amd64 nodes.

The compilation coverage is not quite as large, as support for gcc 5
was only introduced in linux 3.18.

Fixes: support #1604
Change-Id: I49e7fc9d081c0b86cb25487d161efc3d1cf8f484
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

lava: Install vlttng inside a venv

A number of the lava jobs were failing as the python tests couldn't
import the `bt2` module. While it may be possible to improve the
behaviour of vlttng to better address the situation two elements
combine to make the process work more systematically:

* Install `vlttng` inside a venv instead of using the
`--break-system-packages` option: once activated, this will set an
initial value for the `PYTHONPATH` environment variable
* When `vlttng` is invoked, since `PYTHONPATH` is no longer empty, the
value will be updated correctly.

In the case of the new rootfs, it also appears to be necessary to
ensure that `setuptools` is using `distutils` from Python stdlib,
although the module is deprecated and will be removed in Python 3.12

C.f. https://peps.python.org/pep-0632/

Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Change-Id: If0aefb72f5c37721f88b49bd4a841b5ce61f46a0

lava: Wait until time is synchronised during test suite cleanup

Change-Id: I85d426b9167eb53777d0684d4f7f3249a6a48f3a
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Add cron job to reboot armhf nodes that have gone read-only

Change-Id: I4f2c38244bf4135600e1e33bf9c4fe76be1de740
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: lttng-ivc: use 'lttng' upstream repo for lttng-ivc

Change-Id: I6a9acb70983e7e4bf88210a2b596ae8f5685f4f4
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: babeltrace: remove unused mjeanson dev jobs

Change-Id: I83e3fdb903bbce26d51383ba653e297e08d949a3

jjb: fix memory printing on FreeBSD

Change-Id: I0f5b56d9008e08134f81563d9c54f1bb15cb843b
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb/lava: Update system tests to use Debian bookworm rootfs

Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Change-Id: If40992f99c7b484351b2f54255fc37c4d89eed8b

lava: Upload artifacts as a separate test

Change-Id: I6736aa3d1e807ef26451008cc5e2ec2f6aa93de8
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb/lava: Correct YAML loading for lava job results

Change-Id: I7d2a7d4eeb0192c4ac1b83547683fc02589ccc76
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: print hardware details

Print the hardware details of the CI node at the beginning of the build.

Change-Id: I675d950f687df72f90f89d296b1a68b9207d0f93
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: lttng-tools: remove unused mjeanson dev jobs

Change-Id: Ic53dc166092343b469cabef9ac4d8828b5a10205
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: lttng-ust: remove unused mjeanson dev jobs

Change-Id: I455a6475319c5abb1ab920dcc823da4371287b17
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: Remove lttng-ust jobs for unsupported versions

Change-Id: Ic763d668554b3745fc3aff4d81cf403ca9a1e35d
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Remove lttng-tools jobs for unsupported versions

Change-Id: I0d4bfba21560a8cdb2601a0fe0ae51c04a78df06
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Disable UST java tests by default on non-linuxbuild targets

Change-Id: I451abf33352c8953a0b909974597a0b9916898ce
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

lava: Include test logs in uploaded artifact when make check fails

Change-Id: I2c216a12f94f377de719ec128a0dae8524f08480
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

lava: Use safe loads for YAML

The version of LAVA we are using was updated last year, and includes
fixes for supporting safe YAML.

C.f. https://gitlab.com/lava/lava/-/commit/c0da3495c11936d761de4e03d709041f2f9a1d3e

Fixes Support #754

Change-Id: I34afafa5643fa45059077468536239e4b48d15ac
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: binutils-gdb: don't run tests in parallel

We see some tests failing, where GDB gets SIGKILLed, most likely some
out of memory problems.  Don't run test in parallel for now, to try to
avoid these.

Change-Id: I6e3ed399dd9376d5ab0316f85b77eb4c0b35c9e1

ansible: Install rasdaemon and prometheus exporter on CI hosts

Change-Id: Iff4018e7e4174aad321ab740e534cab4d3414255
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Rerun failed system test jobs by default

There can be occasional temporary errors launching jobs, eg. a
time-out waiting for the PXE boot, or flaky tests. Rather than stop
trying to run the test after a single failure, the failed tests will
be retried the next time to job is triggered.

Change-Id: Id996e70d46c41cf4693d6d2a9febe7a3c557e86b
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Manage system tests view with jenkins-job-builder

The view was only configured via the interface, and a number of the
jobs weren't being shown.

In particular the regex for the baremetal tests in the interface was
missing the plural 's' on the 'tests'.

Change-Id: Ib4c2cd78bd8b92a14a114f7fc72df4cf2a5afce3
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Add Linux 6.6.y to system tests

Change-Id: Ibcc313e0996ba0d269ee8725bfa138344f276561
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Use git.efficios.com mirror for deploying efficios-www

Change-Id: Ic4d92b9f64be4a425eb90175eebe9198048f9f34
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: babeltrace: run tools/format-cpp.sh to check C++ formatting

Change-Id: I87ce874d12792697522c4a5b92dd120e138791b3
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>

jjb: drop macos-amd64 except for binutils-gdb

Our macOS amd64 machine is unsupported and doesn't receive OS updates
anymore.

Change-Id: I51449a8158423d5dc1f2c736c19bb5d23711015e
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: babeltrace: move mingw64 builds to ucrt64

UCRT64 is the new default runtime supported by the MSYS2 project.

Change-Id: I74576e3a7c7e7522b12abd103105bada70bb5051
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: babeltrace: drop mingw32 flavor from winbuild

The MSYS2 project is starting to deprecate their 32-bit support, drop it
from the build matrix.

Change-Id: I184880f6d2e8408de451084daccae2a1dbaae5b0
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: liburcu: remove mjeanson dev jobs

Change-Id: I0364e04066f3d48b710c2ffb410578b0dbb3b424
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: remove -DDEBUG from coverity CFLAGS

As far as I know we don't use this define and it conflicts with a
loglevel enum value in babeltrace.

Change-Id: I197deacfdd178288404ddb8f2ad94034baf512ed
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

ansible: Use HTTP/1.1 for git http operations on Debian bookworm

When using HTTP/2 for git operations, git's use of libcurl can result
in deadlocks with libcurl 7.84-8.4 as libcurl may call the read
callback multiple times after EOF.

@see https://lore.kernel.org/git/CAGE_+C5u9H8m5faK1vXKk6QTyjcHgKHqxOZy5ptzsYbF_0yrCQ@mail.gmail.com/
@see https://curl.se/mail/lib-2023-11/0017.html
@see https://github.com/curl/curl/pull/12363

Fixes #1532

Change-Id: I1236d7bc8480c2b8316891b2572ce93f999ff4e4

Merge "jjb: Add dev_review_efficios-www"

Merge "jjb: Add dev_review_lttng-www"

jjb: Add dev_review_efficios-www

Change-Id: I3c73146fafa6a8a898daaeb67f5d5f4c821b1765
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Add dev_review_lttng-www

Change-Id: I924fdbb835b7767f62aa25bc1eeea94e3b61746c
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Update recent Linux kernel LTS versions

C.f. https://www.kernel.org/category/releases.html accessed on
2023-12-01

Change-Id: I60d6252eaa1b73d3c9e4390d0fb76fecc62cee7b
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Add older LTS kernel versions

lttng-modules stable-2.13 supports Linux >= 3.0 at this time. When
`dev_review_` jobs for this branch are run, the version ranges are set
with `kverceil` and `kverfloor`, then filtered according to
`lts-head`. Since only more recent LTS kernels were added to
`lts_kversions`, CI tests weren't running against as wide of a range
of kernels as suggested by the project's support matrix.

Change-Id: Id49eca88732ed2cdd840e717e13c9161b35f2e81
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

Merge "ansible: Add group roles for building ci/dev images"

Merge "ansible: Add role for developer tools"

Merge "ansible: Use 'compilers_legacy_install' to control legacy CC installation"

Merge "ansible: lxd: Disable secureboot on the ci-rootnode profile"

ansible: Add group roles for building ci/dev images

Change-Id: I7c1ac127fd43d7b9507c0f9672f9800604dc48d3

ansible: Add role for developer tools

The idea of the developer tools roles is to provide commonly used by
people working interactively in an environment on LTTng or other
projects.

This first pass is based on https://github.com/jgalar/lttng-dockerfiles

Change-Id: I2b822602dfeb08bf59ab5094cee2f0554845a614

ansible: Remove lttng-scope role

Change-Id: Ied03ebfa715c2e26f688418ba1948d299f69c0d5
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Remove coverity build options related to lttng-scope

Change-Id: I9eded456cd58e5ccd55559c01b1060813f01a530
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

ansible: Use 'compilers_legacy_install' to control legacy CC installation

Change-Id: Ib82813759364dd7227206f3dd4e6d8d95b720b2e

ansible: lxd: Disable secureboot on the ci-rootnode profile

The rootnodes are typically VMs (currently managed via libvirt rather
than lxd). However, the profile is still useful when launching VMs
from images for testing, eg.

lxc launch -p default -p ci-rootnode --vm images:debian/10/cloud/amd64

Without disabling secureboot, extra steps are required to load any
built kernel modules.

Change-Id: I65ec94cf6e2891c27e437a3b1a4e8126f81487da

jjb: Stop using jgit for lttng-tools jobs

The CI master and the Debian workers are using a more recent
libcurl3-gnutls which doesn't seem to suffer from the same issues when
fetching tags from some of the gerrit repos.

Refs #1532

Change-Id: I972f17572ae30a2394944b716bebf0b5d5824cc5

jjb: coverity: fix for curl 8.4

We upgraded curl to work around a git clone issue but this new version
doesn't support combining '--form' or '--data' with '--continue-at'.
Remove the resume support that was added when the Coverity download
server was flaky, they seem to have fixed the issue on their side.

Change-Id: I9907a1cba903a73a8221a5ce490c39d82e2d4769
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

ansible: Install libcurl3-gnutls from bookworm-backports

In the CI builds, we're seeing an issue where certain projects hang
and fail to checkout the gerrit refs.

Eg. ```
git init .
git fetch --tags --force --progress -- \
  https://review.lttng.org/babeltrace \
  +refs/heads/*:refs/remotes/origin/*
git fetch --tags --force --progress -- \
  https://review.lttng.org/babeltrace \
  refs/changes/*:refs/changes/*
```

Not all repositories are affected. There seems to be some type of
content in the gerrit repository that triggers the issue.
After some testing, the version of libcurl3-gnutls available in
bookworm-backports (8.4.0-2~bpo12+1) doesn't seem to be affected
while the version in Debian bookworm (7.88.1-10+deb12u4) fails.

Fetches via SSH are not affected.

Refs #1532

Change-Id: If4b8ca62d5a512c7cccc2225b180b91d3832987d
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Cleanup system tests email notification recipients

Change-Id: Ibf861c81fc0a3130f12edb9f52f52858a1d9dd73
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: babeltrace: Add 'isort' to pylint jobs

Requested by Simon, the script makes sure it doesn't run on stable-15
and stable-2.0 where it's not supported.

Change-Id: Ia4617feff900fe7ca9542c06974f1b45371d011b
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: Add jobs for lttng-docs

Change-Id: I92bea15063de5d942a0e095109c4b6a4d5656b9d
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: Add latest Ubuntu jammy kernel ranges for lttng-modules

Change-Id: I1245ee2f27d3bf6dcb6536d210c4fb6515cd6354

jjb/ansible: Drop support for Ubuntu bionic

Bionic reached it's end of life in June 2023

Change-Id: I1a874090a0360be7d962c1b78c2116716420745d
Signed-off-by: Kienan Stewart <kstewart@efficios.com>

jjb: normand: use virtualenv instead of venv

Virtualenv is installed on the nodes, not venv currently.

Change-Id: I2875888a792d484c8bacb5a1f94aea807c0bd949
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: add Normand job

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>

jjb: lttng-modules: Add riscv64 to crossbuilds

Change-Id: I979165f270138f0daae63589a84b784bfa8b71fb
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: babeltrace-benchmark: update requirement.txt for deb12

Change-Id: If47ef5d42d34c220e02199bc16953a75ecd85567
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: babeltrace-benchmark: fix job for deb12

Change-Id: Ie1623b1c64ea603ecdc8a4a97441b845c4fa4f76
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

wip: ivc

Change-Id: Ia70ca04036a9ddfc92727a8ea620afe3ccd16f96

jjb: lttng-modules: add floor for ubuntu riscv builds

Change-Id: I1bcb92e8a4f727364d6fc887167b436f2481066b
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: lttng-modules: update coverity for deb12

Change-Id: I4194aeb8d37d2211e79d1e36fc26ccf6897cd944
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: lttng-modules: refactor triggers

Refactor triggers for lttng-modules kernel buils.

'(cross)build-vanilla':
  - hourly check for lttng-modules commits
  - daily (22:00) check for new kernel tags

'fullbuild-vanilla':
  - friday at midnight check for lttng-modules commits

'build-{UBUNTU}':
  - hourly check for lttng-modules commits
  - saturday at midnight check for new ubuntu kernel tags

'build-rt':
  - hourly check for lttng-modules commits
  - sunday at midnight check for new rt kernel tags

Change-Id: I9b827d926f89c81f49e6689b3c12f9688ae7ede4
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

jjb: Do not test python2 agents in lttng-tools release builds

The nodes that run lttng-tools release jobs no longer have python2

Change-Id: If86f0ca782633d1b7ea40ddaff3fce8032676955
Signed-off-by: Kienan Stewart <kstewart@efficios.com>