Mathieu Desnoyers [Wed, 13 Jun 2012 08:46:44 +0000 (04:46 -0400)]
Fix: perform TLS fixup of nest count outside of UST mutex
Could otherwise lead to a deadlock between the dynamic linker, TLS
fixup, and the UST mutex due to reversed lock acquisition order.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 13 Jun 2012 08:26:34 +0000 (04:26 -0400)]
Fix: liblttng-ust-fork deadlock
* Mathieu Desnoyers (mathieu.desnoyers@efficios.com) wrote:
> * Burton, Michael (mburton@ciena.com) wrote:
> > Mathieu,
> >
> > I think there is a deadlock scenario in UST, which has been causing my problem.
>
> Good catch !
>
> >
> > sessiond is started as root:
> > - creates global sockets ONLY
> > - DOES NOT CREATE shm in $HOME/lttng-ust-wait-<uid>
> >
> > application linked against ust is run as root:
> > - in lttng_ust_init constructor
> > - ust_listener_thread (local_apps)
> > - fails to connect to local_apps in $HOME/.lttng (as expected)
> > - prev_connect_failed=1
> > - ust_unlock()
> > - restart
> > - wait_for_sessiond()
> > --> - ust_lock()
> > | - get_map_shm()
> > | - get_wait_shm()
> > DEADLOCK - shm_open() FAILS (not created by sessiond when run by root)
> > | - fork() (trying to create shared memory itself)
> > | - ust_before_fork()
> > ------------> - ust_lock()
> >
> >
> > You should be able to create this with an empty main, with no
> > tracepoints. As long as sessiond is started as root so
> > $HOME/lttng-ust-wait-<uid> is not created. You can also make the
> > lttng-ust constructor (lttng_ust_init) wait forever and then you'll be
> > able to see the deadlock in gdb without even leaving the
> > lttng_ust_init constructor.
>
> Ah, I see. This deadlock is caused by the interaction between
> [ liblttng-ust-fork ] and liblttng-ust (the fork override is
> performed by [ liblttng-ust-fork ]).
This can be reproduced easily with the in-tree tests: by removing the
lttng-ust-apps-wait* files belonging to the user in /dev/shm, running
the "tests/fork" test (with ./run) hangs. If we run "hello" first, and
then the fork test, it works fine.
Fixing this by keeping a nesting counter around the fork() call, so we
return immediately from the pre/post fork handlers if they are
overridden by liblttng-ust-fork.
Reported-by: Michael Burton <mburton@ciena.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 13 Jun 2012 00:12:23 +0000 (20:12 -0400)]
Fix: handle pthread errors
Show a descriptive error message if pthread calls fail.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 13 Jun 2012 00:03:53 +0000 (20:03 -0400)]
Fix: local apps allowed should disable local (not global) tracing
Reported-by: Michael Burton <mburton@ciena.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 12 Jun 2012 15:51:31 +0000 (11:51 -0400)]
Fix strict ISO-C compatibility for ust-tracepoint-event.h public header
../../include/lttng/ust-tracepoint-event.h:328:23: warning: ISO C does not permit named variadic macros [-Wvariadic-macros]
Use ... and __VA_ARGS__ instead of args... and args.
This enables ISO-C compability for the tracepoint headers for program
instrumentation. Note that the probes need to be built _without_ strict
C99 flags (they require gnu extensions).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 12 Jun 2012 15:22:46 +0000 (11:22 -0400)]
Fix: support -std=c99 in tracepoint macros
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 11 Jun 2012 14:00:53 +0000 (10:00 -0400)]
Revert "hello test: fail on old style definition"
This reverts commit
5558cdce88ba0436ddaa02377ac79c1985e5f81a.
This commit was not intended to make it into stable-2.0.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 11 Jun 2012 13:53:07 +0000 (09:53 -0400)]
Fix: tracepoint.h should not generate old-style definitions
I've defined a tracepoint without arguments:
TRACEPOINT_EVENT(
qemu_tb_hash,
flushall,
TP_ARGS(void),
TP_FIELDS()
)
When I build (with -Werror=old-style-definition), I get this error:
In file included from /home/hollisb/work/qemu.git/exec.c:59:0:
/home/hollisb/work/qemu.git/tracepoints.h:24:2: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
/home/hollisb/work/qemu.git/tracepoints.h: In function ‘__tracepoint_cb_qemu_tb_hash___flushall’:
/home/hollisb/work/qemu.git/tracepoints.h:24:2: error: old-style function definition [-Werror=old-style-definition]
cc1: all warnings being treated as errors
The preprocessed code looks like so:
extern struct
# 129 "/usr/local/include/lttng/tracepoint.h" 3
tracepoint
# 24 "/home/hollisb/work/qemu.git/tracepoints.h"
__tracepoint_qemu_tb_hash___flushall
# 19 "/home/hollisb/work/qemu.git/tracepoints.h"
; static __attribute__ (( always_inline )) __inline__ void
__tracepoint_cb_qemu_tb_hash___flushall
# 19 "/home/hollisb/work/qemu.git/tracepoints.h"
() { struct tracepoint_probe *__tp_probe; if (!tracepoint_dlopen.rcu_read_lock_sym_bp) return; tracepoint_dlopen.rcu_read_lock_sym_bp(); __tp_probe = ({ typeof(__tracepoint_qemu_tb_hash___flushall.probes) _________p1 = ((typeof(__tracepoint_qemu_tb_hash___flushall.probes)) (tracepoint_dlopen.rcu_dereference_sym_bp(((void *) (__tracepoint_qemu_tb_hash___flushall.probes))))); (_________p1); }); if (__builtin_expect(!!(!__tp_probe), 0)) goto end; do { void *__tp_cb = __tp_probe->func; void *__tp_data = __tp_probe->data; ((void (*)(void *__tp_data)) (__tp_cb)) (__tp_data); } while ((++__tp_probe)->func); end: tracepoint_dlopen.rcu_read_unlock_sym_bp(); } static __attribute__ (( always_inline )) __inline__ void
I believe the problem comes from -Werror=old-style-definition not liking
that empty "()", i.e. tracepoint_cb_qemu_tb_hash___flushall() { ... }.
Reported-by: Hollis Blanchard <hollis_blanchard@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 11 Jun 2012 13:52:41 +0000 (09:52 -0400)]
hello test: fail on old style definition
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 8 Jun 2012 17:17:05 +0000 (13:17 -0400)]
Fix: don't define variables in headers
From Hollis Blanchard <hollis_blanchard@mentor.com>:
> Hi, I was adding an LTTng UST 2.0 tracepoint to an application that uses
> -warn-common (see http://www.math.utah.edu/docs/info/ld_2.html). I created
> a simple tracepoint, had lttng-gen-tp produce tracepoints.o, then linked
> that to the application, along with -llttng-ust. This results in some
> warnings:
>
> tracepoints.o: warning: common of `handle' overridden by definition
> /usr/local/lib/liblttng-ust.so: warning: defined here
> tracepoints.o: warning: common of `lttng_client_callbacks_overwrite' overridden
> +by definition
> /usr/local/lib/liblttng-ust.so: warning: defined here
> tracepoints.o: warning: common of `lttng_client_callbacks_discard' overridden by
> +definition
> /usr/local/lib/liblttng-ust.so: warning: defined here
> tracepoints.o: warning: common of `lttng_client_callbacks_metadata' overridden
> +by definition
> /usr/local/lib/liblttng-ust.so: warning: defined here
> /usr/local/lib/liblttng-ust-tracepoint.so.0: warning: multiple common of
> +`handle'
> tracepoints.o: warning: previous common is here
>
> This seems to be a valid warning. The LTTng UST headers contain
> definitions like this in include/lttng/ringbuffer-config.h:
> struct lttng_ust_shm_handle *handle;
>
> If two objects use that header, each will get a copy of "handle", right?
handle: This was meant to be a forward declaration of
struct lttng_ust_shm_handle
so just removing the "*handle" part. This can be considered as a
cleanup (or a fix without actual runtime effect).
lttng_client_callbacks_*: if the cb values would have been used in the
consumer daemon, this would have caused an issue: these would be set to
NULL instead of the actual callback pointers. So in a way this is a fix,
but it does not have any runtime impact at this point.
Reported-by: Hollis Blanchard <hollis_blanchard@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 5 Jun 2012 17:15:52 +0000 (13:15 -0400)]
test "hello": add boolean test
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 5 Jun 2012 17:08:54 +0000 (13:08 -0400)]
Fix: perform macro expansion on tracepoint signatures
The problem can be seen by patching the demo test from lttng-ust as
follows:
--- a/tests/demo/ust_tests_demo3.h
+++ b/tests/demo/ust_tests_demo3.h
@@ -22,12 +22,14 @@ extern "C" {
* all copies or substantial portions of the Software.
*/
+#include <stdbool.h>
+
#include <lttng/tracepoint.h>
TRACEPOINT_EVENT(ust_tests_demo3, done,
- TP_ARGS(int, value),
+ TP_ARGS(bool, value),
TP_FIELDS(
- ctf_integer(int, value, value)
+ ctf_integer(bool, value, value)
)
)
Then when the demo is run with LTTNG_UST_DEBUG=1, a warning is shown,
like:
liblttng_ust_tracepoint[3315/3315]: Warning: Tracepoint signature mismatch, not
enabling one or more tracepoints. Ensure that the tracepoint probes prototypes
match the application. (in set_tracepoint() at tracepoint.c:310)
liblttng_ust_tracepoint[3315/3315]: Warning: Tracepoint "ust_tests_demo3:done"
signatures: call: "_Bool, value" vs probe: "bool, value". (in set_tracepoint()
at tracepoint.c:312)
It seems that TP_ARGS does not perform preprocessor expansion on the
"bool" type spec, while something underneath TP_FIELDS does. And since
(at least on this Centos 6.2 box) stdbool.h uses a #define rather than a
typedef to make bool equivalent to _Bool, liblttng detects a mismatch.
Reported-by: John Steele Scott <toojays@toojays.net>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Fredrik Oestman [Tue, 5 Jun 2012 15:21:36 +0000 (11:21 -0400)]
UST check pointer/de-reference order
I stumbled across some code where pointers are de-referenced and then
checked for NULL.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 1 Jun 2012 18:13:58 +0000 (14:13 -0400)]
Update version to 2.0.3
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Wolfgang Puffitsch [Fri, 1 Jun 2012 16:04:37 +0000 (12:04 -0400)]
Fix: Block all signals in listener thread
The listener thread does not block signals and receives signals that are
intended for the application. As this can cause applications to fail,
the listener thread should block all signals. The attached patch is
derived from an old commit and fixes the issue.
Fixes #241
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 22 May 2012 16:30:05 +0000 (12:30 -0400)]
Remove jni support for configure
java jni is not supported in stable-2.0. Make sure that the
--with-jni-interface fails.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 18 May 2012 21:07:06 +0000 (17:07 -0400)]
Fix: don't SIGBUS when filesystem is full
Write zeroes into the buffer after its allocation to ensure that writes
to the shm will not trigger SIGBUS upon full filesystem situations.
This scenario can occur if /dev/shm is filled, e.g. by specifying too
large buffers with --enable-channel.
When the write() fails, the buffer creation for this channel fails.
Fixes #230
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 May 2012 17:31:07 +0000 (13:31 -0400)]
tracepoint: include stdio.h for NULL definition
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 May 2012 12:51:07 +0000 (08:51 -0400)]
manpage update: document that probes need gcc
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 May 2012 12:40:04 +0000 (08:40 -0400)]
Fix: remove # in front on extern "C" {
Fails to compile with g++.
Reported-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 10 May 2012 18:33:38 +0000 (14:33 -0400)]
Cleanup: don't use GNU old-style field designator extension
ustfork.c:112:38: warning: use of GNU old-style field designator extension
[-Wgnu-designator]
struct ustfork_clone_info info = { fn: fn, arg: arg };
^~~
.fn =
ustfork.c:112:46: warning: use of GNU old-style field designator extension
[-Wgnu-designator]
struct ustfork_clone_info info = { fn: fn, arg: arg };
^~~~
.arg =
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 10 May 2012 18:31:28 +0000 (14:31 -0400)]
Fix: remove padding field after variable sized array
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 25 Apr 2012 20:27:09 +0000 (16:27 -0400)]
Fix: lttng-ust.pc needs to specify -ldl
Fixes #224
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 18 Apr 2012 23:36:27 +0000 (19:36 -0400)]
Update changelog after liblttng-ust-java removal
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 18 Apr 2012 23:34:37 +0000 (19:34 -0400)]
Fix: drop unusable liblttng-ust-java.so
There is no java class installed onto the system anyway, so it was
dependent on having access to the build tree to use it. And
documentation only sits in the build tree, so instead of installing a
.so that cannot be used, and is not documented, remove it from the
package for 2.0.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 18 Apr 2012 23:06:45 +0000 (19:06 -0400)]
Update changelog for 2.0.2
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 18 Apr 2012 23:05:32 +0000 (19:05 -0400)]
Revert "Fix: Make the JNI interface actually work"
This reverts commit
46adf653a1d01b8e87baa30cc9b92616eee1a788.
It changes the makefiles, and broke make dist. This does not belong in a
stable release.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 18 Apr 2012 20:27:49 +0000 (16:27 -0400)]
Update version to 2.0.2
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 18 Apr 2012 20:17:56 +0000 (16:17 -0400)]
Fix: examples Makefiles should pass $(LIBS) at last
Fixes #210
Description
Since Ubuntu 11.10, the "--as-needed" option is given by default to ld
(linker). This option breaks the makefiles given with the userspace
tracing examples. Therefore the libraries against which the program
should be linked should be passed at last:
$(CC) -o $@ $^ $(LIBS)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 12 Apr 2012 18:06:14 +0000 (14:06 -0400)]
Revert "Build a jar for the Java side of the JNI interface"
This reverts commit
6dcf3689333a2b465a5738c840d0b14d3f8014ea.
This should not go into stable-2.0.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Alexandre Montplaisir [Thu, 12 Apr 2012 13:39:55 +0000 (09:39 -0400)]
Build a jar for the Java side of the JNI interface
Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 9 Apr 2012 15:02:42 +0000 (11:02 -0400)]
Fix: ustctl need to send the second fd upon error of 1st fd
Otherwise cause protocol discrepancy between ust and sessiond upon send
error. The sessiond will wait for an fd that never arrives.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Alexandre Montplaisir [Thu, 5 Apr 2012 21:15:57 +0000 (17:15 -0400)]
Fix: Make the JNI interface actually work
Now a user can import LTTngUst.java (which is now in a proper
package) and then define tracepoints in his application with:
LTTngUst.tracepointString(name, args);
We could eventually ship it in a .jar when the JNI interface is
enabled. It's still very basic, only string payloads are
implemented, and there is no mechanism to enable/disable trace
points call sites at runtime (they are always enabled). The event under
which these events appear is "lttng_ust_java:string".
Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 29 Mar 2012 04:48:12 +0000 (00:48 -0400)]
Update version to 2.0.1
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 21 Feb 2012 03:01:52 +0000 (22:01 -0500)]
Use bsd-compatible fcntl for close-on-exec on socket
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 27 Mar 2012 20:15:20 +0000 (16:15 -0400)]
Fix multi-session wildcard support
Incorrectly unset loglevel information upon creation of wildcard_entry
was causing a second session with wildcard enabled to not record its
events.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 27 Mar 2012 19:41:42 +0000 (15:41 -0400)]
Fix event lost count when buffer is full
The tracing channels should count lost events due to buffer full, and
the metadata channel should not (see comment), but not the opposite.
This was a mixup between the two.
Reported-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sun, 25 Mar 2012 23:52:07 +0000 (19:52 -0400)]
Remove inappropriate \n from easy-ust sample
Although \n is permitted in strings, it adds newlines in the trace
pretty-printer output, which is not that nice.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 20 Mar 2012 22:33:26 +0000 (18:33 -0400)]
Update version to 2.0.0 stable
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 20 Mar 2012 21:34:28 +0000 (17:34 -0400)]
make dist: Generate bzip2 instead of gzip
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 20 Mar 2012 21:05:09 +0000 (17:05 -0400)]
Update version to 2.0.0-rc4
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 20 Mar 2012 18:24:36 +0000 (14:24 -0400)]
Fix out-of-bound write in ltt-events.c
Valgrind complains that the size allocated is too small for the memcpy,
rightly so (off by one).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 20 Mar 2012 18:13:54 +0000 (14:13 -0400)]
Document LTTNG_UST_DEBUG_VALGRIND compilation flag
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 19 Mar 2012 18:28:04 +0000 (14:28 -0400)]
Update COPYING
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Mon, 19 Mar 2012 17:22:48 +0000 (13:22 -0400)]
Add exception handling to lttng-gen-tp io operations
(closes: 54)
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 16 Mar 2012 19:34:03 +0000 (15:34 -0400)]
Update version to 2.0.0-rc3
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 14 Mar 2012 18:55:35 +0000 (14:55 -0400)]
Fix: sendmsg should retry on EINTR, and use MSG_NOSIGNAL
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 14 Mar 2012 18:49:21 +0000 (14:49 -0400)]
fix: ustcomm_close_unix_sock should close, not shutdown
.. and ensure that we actually use the API rather than doing the close()
directly in the caller.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 14 Mar 2012 18:43:32 +0000 (14:43 -0400)]
Fix: do not print EPIPE perror, as it is an expected error
It is perfectly valid for the other end to close its socket, so do not
report broken pipe errors as perror.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 13 Mar 2012 20:09:52 +0000 (16:09 -0400)]
Ensure that multiplication of clock offset is done on 64-bit
This is not a bug in UST per se, because we happen to force
multiplication by a ULL number, but force cast to uint64_t anyway to
ensure we don't trigger this overflow if the constant ever happen to
change.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 8 Mar 2012 19:11:22 +0000 (14:11 -0500)]
Add 2 missing licenses in deprecated tests
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 8 Mar 2012 19:06:49 +0000 (14:06 -0500)]
Remove unbuild and unused (deprecated) make_shared_lib test
Was for UST 0.x.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 8 Mar 2012 19:04:09 +0000 (14:04 -0500)]
License text standardization, add missing licenses
- Use MIT/X11 text for BSD-style license.
- Fix FSF address.
- Use appropriate LTTNG_ prefix for ifndef (rather than LINUX).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 8 Mar 2012 15:58:04 +0000 (10:58 -0500)]
Cleanup: remove duplicate check for 0 num_subbuf and subbuf_size
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 8 Mar 2012 15:54:13 +0000 (10:54 -0500)]
Fix: power of 2 size check should apply to size_t type, not uint32_t
Fix this by using the much simpler x & (x - 1) check (rather than
hweight(x) == 1).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 6 Mar 2012 23:10:43 +0000 (18:10 -0500)]
Fix: recvmsg should handle EINTR
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Tue, 6 Mar 2012 21:11:04 +0000 (16:11 -0500)]
Make lttng-gen-tp work on python 2.6
(refs #114)
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Tue, 6 Mar 2012 15:35:46 +0000 (10:35 -0500)]
Make lttng-gen-tp executable
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 22:41:30 +0000 (17:41 -0500)]
Update version to 2.0.0-rc2
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Alexandre Montplaisir [Fri, 2 Mar 2012 22:35:32 +0000 (17:35 -0500)]
Manpage fixes
Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 15:24:39 +0000 (10:24 -0500)]
Fix: dmesg printout should not print metadata warnings
Metadata channel retry when an event is dropped by the underlying
buffer. We should not print a message showing that the event has been
dropped to the user on debug console.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 15:13:14 +0000 (10:13 -0500)]
Fix: use transport name as channel name
Clarify lost event printout.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 22:03:09 +0000 (17:03 -0500)]
Fix: Add signature check in tracepoint activation
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 20:26:19 +0000 (15:26 -0500)]
Fix: add tracepoint signature at tracepoint definition site
Will enable type-checking between call site and handler.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 19:39:02 +0000 (14:39 -0500)]
Fix: keep event probe signature, for use by event probe signature check
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 18:53:45 +0000 (13:53 -0500)]
Fix ABI: add padding to structures shared between UST and consumer
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 18:39:04 +0000 (13:39 -0500)]
Fix ABI: add padding to tracepoint and ring buffer config public structures
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 18:33:11 +0000 (13:33 -0500)]
Fix ABI: Adding missing padding in tracepoint event structures
Add padding for future extensions.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 17:48:13 +0000 (12:48 -0500)]
Fix: Add include/lttng/ust-config.h to git ignore
(fixes #95)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 17:15:34 +0000 (12:15 -0500)]
Fix effect: update README about dlopen()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 17:13:47 +0000 (12:13 -0500)]
Fix: fixup vtid TLS
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Conflicts:
liblttng-ust/lttng-context-vtid.c
Mathieu Desnoyers [Thu, 1 Mar 2012 17:09:40 +0000 (12:09 -0500)]
Fix: fixup ringbuffer tls at constructor by forcing read
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Conflicts:
liblttng-ust/lttng-ust-comm.c
libringbuffer/ring_buffer_frontend.c
Mathieu Desnoyers [Thu, 1 Mar 2012 17:00:04 +0000 (12:00 -0500)]
Fix: fix deadlock with dlopen() lttng-ust
Pre-"fault" the libuuid TLS outside of the ust lock to ensure that we
never deadlock with the linker mutex in libc. This mutex is held both
for TLS fixup of dlopen'd libs, and across execution of all
constructors. We therefore have a reverse use of this mutex wrt ust
lock, that we fix by forcing the TLS fixup to happen very early in the
lttng-ust constructor.
[fixed merge from dev branch]
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 24 Feb 2012 01:11:17 +0000 (20:11 -0500)]
Fix: only print event errors every
1048576 hits
Never spam the console, even in debug mode, since it would make debug
information very much useless.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 24 Feb 2012 00:08:51 +0000 (19:08 -0500)]
Fix: add missing debug printout to identify the cause of lost events
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 23 Feb 2012 22:28:19 +0000 (17:28 -0500)]
fix: liblttng-ust-ctl should check for incorrect parameters
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 23 Feb 2012 20:13:01 +0000 (15:13 -0500)]
fix: ust comm error handling segfault
On comm errors, UST should not try to populate fields from NULL
pointers.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:34 +0000 (17:10 -0500)]
Revert "Add FreeBSD compat layer for endian.h"
This reverts commit
8740da0a30986094ebf03a0f3b7448844d5e886f.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:33 +0000 (17:10 -0500)]
Revert "fls: use local namespace to do not clash with FreeBSD string.h"
This reverts commit
6b95cebfaaf9f6ee862fc790d5a128769dc573bf.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:32 +0000 (17:10 -0500)]
Revert "Fix freebsd endian support"
This reverts commit
020760b19e351bda940b38ca273f32206ab4d03f.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:32 +0000 (17:10 -0500)]
Revert "Add get proc name wrapper for FreeBSD"
This reverts commit
48621a4272bdeb1e8fced511ca6bf3c4c2240c15.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:31 +0000 (17:10 -0500)]
Revert "Add freebsd support for getcpu (use cpu nr 0)"
This reverts commit
dbafbbf5527d2e291b216216fd2c5b7dc4df66ed.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:30 +0000 (17:10 -0500)]
Revert "snprintf: fix namespace of snprintf types for freebsd"
This reverts commit
18d0b33ab9884b3f7bac0dd918993dc05a7c43fd.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:29 +0000 (17:10 -0500)]
Revert "Compat layer for gettid"
This reverts commit
36e2ba2a19ec6698ed8dfb8c9bde683368334372.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:29 +0000 (17:10 -0500)]
Revert "Use XSI-compliant strerror_r by default on non-Linux"
This reverts commit
7705281be801c16b35349f9ab17f67419cac1c34.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:28 +0000 (17:10 -0500)]
Revert "Use ENOMSG as fallback for ENODATA on freebsd"
This reverts commit
e5757a9047b04cb2fb94d9dfdf7153e963eafa95.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:27 +0000 (17:10 -0500)]
Revert "Use bsd-compatible fcntl for close-on-exec on socket"
This reverts commit
4171df999bf0c0c552fa35cea9a12fa4d82faae6.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:27 +0000 (17:10 -0500)]
Revert "configure.ac: check for both libuuid/libc uuid APIs"
This reverts commit
eade58d0cba1a300e37a4b1fd4b2588f134d08c9.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:26 +0000 (17:10 -0500)]
Revert "Create libuuid/libc uuid wrapper"
This reverts commit
67107619135ff344f0de2783ec2d48e558deaf9a.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:10:22 +0000 (17:10 -0500)]
Revert "Rename uuid.h wrapper to lttng-ust-uuid.h"
This reverts commit
f194f3b00d042154c35f1f9ec262e25f2cd83b8a.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:38 +0000 (17:09 -0500)]
Revert "uuid.h should only be included when libuuid is detected"
This reverts commit
ce32a22799df2d99926df4563e3a52059e3e180a.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:37 +0000 (17:09 -0500)]
Revert "Add freebsd rfork support"
This reverts commit
16295480956eae5c1c3a83546353143bef1885ba.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:36 +0000 (17:09 -0500)]
Revert "Cast uuid_create parameter"
This reverts commit
f1a74d692e1469c197fba0ce5c7519da222cfaf2.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:35 +0000 (17:09 -0500)]
Revert "Update uuid_create type cast"
This reverts commit
a58a54609106b5dc7f9cb0ff5514de8b175e4b01.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:31 +0000 (17:09 -0500)]
Revert "Remove useless const qualifier"
This reverts commit
277d6e1d016e69184fd49b867ff1268d3ff668f5.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:31 +0000 (17:09 -0500)]
Revert "Detect and document dependency on -ldl on Linux, -lc on BSD for dlopen"
This reverts commit
90cefaa31af0a85593a155fba8570e04c653225a.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:30 +0000 (17:09 -0500)]
Revert "ust-event.h: use BYTE_ORDER instead of __BYTE_ORDER"
This reverts commit
52367557562008ab80a94adbaf047dd44b282d15.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:29 +0000 (17:09 -0500)]
Revert "Wrap FLOAT_WORD_ORDER"
This reverts commit
c759fe81a6251b9feddf5cd9576278ffedf92ac3.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:28 +0000 (17:09 -0500)]
Revert "Remove O_LARGEFILE from tests"
This reverts commit
626cb7f6174c4d9c22364f10d3d6a0915e53d5f3.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 22:09:27 +0000 (17:09 -0500)]
Revert "Add configure amd64 support (for FreeBSD)"
This reverts commit
404d9909a392de0e0044c7f49a932d1765c9d813.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.044883 seconds and 4 git commands to generate.