Philippe Proulx [Wed, 26 Aug 2015 05:20:24 +0000 (01:20 -0400)] 
Add LTTNG_EVENT_EXCLUSION_NAME_AT() helper macro
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 26 Aug 2015 05:05:13 +0000 (01:05 -0400)]
Fix: lay out names in exclusion structure correctly
This:
char names[0][LTTNG_SYMBOL_NAME_LEN];
means that accessing
->names[0][i]
will return the i-th character of the first name.
So doing:
lttng enable-event -u -a --exclude hello,a,b,c,d
lttng save
would result in a saved session XML file containing
this:
<exclusion>hello</exclusion>
<exclusion>ello</exclusion>
<exclusion>llo</exclusion>
<exclusion>lo</exclusion>
<exclusion>o</exclusion>
This is great art, but not what is expected.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 Nov 2015 22:51:04 +0000 (17:51 -0500)] 
Fix: Check for NULL hash tables on relay daemon teardown
The relay daemon will log any "leaked" object on exit. However,
some errors encountered early-on during the daemon's
initialization may result in the teardown being executed with
uninitialized hash tables.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 Nov 2015 16:39:59 +0000 (11:39 -0500)]
Fix: Verify directory's existence before calling mkdir
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 Nov 2015 21:46:16 +0000 (16:46 -0500)]
Clean-up: declare variables at beginning of scope
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 23 Oct 2015 23:36:04 +0000 (19:36 -0400)] 
Load x86-exceptions lttng-modules probe
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 23 Oct 2015 22:47:11 +0000 (18:47 -0400)]
Load x86-irq-vectors lttng-modules probe
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 23 Oct 2015 21:14:55 +0000 (17:14 -0400)]
Agent: Make the agent protocol consistently network endian
Considering the Agent Protocol is bumped to v2.0 as of 2.8.x,
this patch revisits the unfortunate decision of communicating
in host-endianness from the session daemon to the agents, and
in big endian from the agents to the session daemon.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 23 Oct 2015 01:38:08 +0000 (21:38 -0400)]
Clean-up: Remove unused variables from default.c
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 23 Oct 2015 01:37:54 +0000 (21:37 -0400)]
Fix: Unchecked NULL string in logging statement
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Alexandre Montplaisir [Fri, 11 Sep 2015 22:38:52 +0000 (18:38 -0400)] 
Fix: include the filter expression in agent events' primary key
Similar fix to
a931962, but for filter expressions this time.
UST events's key already includes the filter bytecode, so adding the
string itself should not be needed.
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Alexandre Montplaisir [Wed, 9 Sep 2015 23:40:19 +0000 (19:40 -0400)]
Add the filter expression to the enable_event agent protocol message
The filter expression is part of an event rule, so should be sent
along with the event name and log level.
This bumps the protocol version to 2.0, and will require UST agents
to be updated.
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Alexandre Montplaisir [Fri, 11 Sep 2015 04:06:55 +0000 (00:06 -0400)]
Add some IDE project files to the gitignore
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mikael Beckius [Wed, 21 Oct 2015 19:48:29 +0000 (15:48 -0400)] 
Fix live timer calculation error
There is an calculation error for live timer. Variable
switch_timer_interval is based on microsecond, and it is not
right to assign switch_timer_interval mod
1000000 to var tv_nsec
which is based on nanosecond.
Signed-off-by: Mikael Beckius <mikael.beckius@windriver.com>
Signed-off-by: Jianchuan Wang <jianchuan.wang@windriver.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 20 Oct 2015 15:08:54 +0000 (11:08 -0400)]
Don't initialize defaults in library constructor
This is done so lttng-tools has no dependency on constructors
being run, such as in the case of a static build.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 20 Oct 2015 14:45:28 +0000 (10:45 -0400)]
Initialize lttng_ht_seed on hashtable creation
This is done to get rid of the need for constructors to be executed
such as in the case of a static build.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 20 Oct 2015 14:01:57 +0000 (10:01 -0400)]
Cleanup: Missing space after cast operator
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 19 Oct 2015 23:14:12 +0000 (19:14 -0400)]
Build: Switch from tar v7 to posix archive format
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 19 Oct 2015 22:00:42 +0000 (18:00 -0400)]
Fix: Retry poll on interruption
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 19 Oct 2015 21:37:27 +0000 (17:37 -0400)]
Port: Explicitly allocate realpath() resolved buffer
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 16 Oct 2015 23:08:29 +0000 (19:08 -0400)] 
Select which binaries/extras to build at configure time
Introduce new flags to the configure script to select what to build:
* By default everything is built *
--disable-bin-lttng
Do not build anything under src/bin/lttng.
--disable-bin-lttng-consumerd
Do not build anything under src/bin/lttng-consumerd.
--disable-bin-lttng-crash
Do not build anything under src/bin/lttng-crash.
--disable-bin-lttng-relayd
Do not build anything under src/bin/lttng-relayd.
--disable-bin-lttng-sessiond
Do not build anything under src/bin/lttng-sessiond.
--disable-extras
Do not build anything under extras.
Only the necessary libs (from src/lib and src/common) are built.
libcommon and libconfig are always built since they are used by every
target.
If any lttng-* binaries are disabled, 'tests' will not be built.
On ./configure a warning is shown to the user.
Also 'make check' and 'make checkinstall' only return a warning when 'tests'
are not built.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 15 Oct 2015 20:47:34 +0000 (16:47 -0400)]
Move libconsumer under common/consumer/
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 15 Oct 2015 20:45:30 +0000 (16:45 -0400)]
Fix: There is more tests than the plan
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Wed, 14 Oct 2015 20:20:40 +0000 (16:20 -0400)]
Remove dead check from configure.ac
The consumerd_only variable was removed here [1].
[1]
4f061d4cf16d6625ed8649095ee6df6922b5262a
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 21:06:12 +0000 (17:06 -0400)] 
Fix: Silence warning by casting *sin_addr to *sockaddr
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Fri, 16 Oct 2015 14:23:46 +0000 (10:23 -0400)]
Port: fix 'ERR' conflict with Solaris regset.h
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 15 Oct 2015 20:47:14 +0000 (16:47 -0400)]
Relay protocol: check string lengths
Ensure that string lengths are not longer than what the protocol
supports on both send and receive. Ensure that path lengths fit in the
local filename length limits on the receive side. Ensure that strings
exchanged in the relay protocol are zero-terminated.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 21:05:05 +0000 (17:05 -0400)]
Fix: Silence warning of function having no return value
Some compilers complain that codepaths which assert have
no return value. This is valid since assertions could
be compiled-out, resulting in an undefined return value.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 21:01:34 +0000 (17:01 -0400)]
Fix: Silence warnings when using uid_t and pid_t with printf
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 18:55:40 +0000 (14:55 -0400)]
Port: Add compat for platforms with no MSG_NOSIGNAL or SO_NOSIGPIPE
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 18:18:15 +0000 (14:18 -0400)]
Port: Add Solaris compat to sessiond-comm/unix.c
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 16:17:43 +0000 (12:17 -0400)]
Port: Add Solaris compat for netdb
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 21:05:53 +0000 (17:05 -0400)]
Fix: Silence warning formating pid_t as int
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 21:05:24 +0000 (17:05 -0400)]
Port: Add Solaris dirent compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 21:01:05 +0000 (17:01 -0400)]
Port: Add Solaris paths compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:51:30 +0000 (16:51 -0400)]
Rename config.h to session-config.h
The global config.h is included on the command line with
the gcc '-include' switch which searches the local directory
before the include path. This leads to a namespace collision
with 'src/common/config/config.h'.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:47:21 +0000 (16:47 -0400)]
Port: Remove _GNU_SOURCE, defined in config.h
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:23:43 +0000 (16:23 -0400)]
Port: cleanup and portability fix to configure.ac
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 17 Oct 2015 23:41:47 +0000 (19:41 -0400)]
Port: Don't use SIGUNUSED which is not defined on Solaris
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 17 Oct 2015 23:34:03 +0000 (19:34 -0400)]
Port: Implement prctl wrapper
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:11:48 +0000 (16:11 -0400)]
Port: Replace flock with fnctl
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 6 Oct 2015 21:38:35 +0000 (17:38 -0400)]
Port: make bootstrap script work on most shells
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 17 Sep 2015 16:47:00 +0000 (12:47 -0400)]
Port: removed unused clone() compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 17 Sep 2015 16:43:40 +0000 (12:43 -0400)]
Port: Add macro for socket linking on solaris
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:05:38 +0000 (16:05 -0400)]
Port: Add Solaris support to mman compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:02:45 +0000 (16:02 -0400)]
Port: Replace dirent->d_type by stat
dirent->d_type is Linux specific while 'stat' is part of POSIX
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 17 Sep 2015 14:49:53 +0000 (10:49 -0400)]
Add missing include for memset()
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 19:35:21 +0000 (15:35 -0400)]
Port: Add Solaris support to socket compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 19:11:40 +0000 (15:11 -0400)]
Port: name clash on Solaris, rename sun to s_un
'sun' is a reserved keyword on Solaris
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:55:14 +0000 (14:55 -0400)]
Port: move memset of anc_buf inside ifdef
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 19 Oct 2015 03:44:30 +0000 (23:44 -0400)]
Port: Add Solaris fls compat
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:56:12 +0000 (16:56 -0400)]
Port: Add Solaris string compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:35:36 +0000 (14:35 -0400)]
Port: Use LTTNG_PATH_MAX instead of PATH_MAX
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:33:43 +0000 (14:33 -0400)]
Port: Use LTTNG_HOST_NAME_MAX instead of HOST_NAME_MAX
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:31:03 +0000 (14:31 -0400)]
Port: Use LTTNG_NAME_MAX instead of NAME_MAX
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:16:30 +0000 (14:16 -0400)]
Port: Add Solaris support to socket compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:15:10 +0000 (14:15 -0400)]
Port: Add Solaris support to poll compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:06:04 +0000 (14:06 -0400)]
Port: Add Solaris support to fcntl compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 17:54:38 +0000 (13:54 -0400)]
Port: Add Solaris endian.h compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 17:33:59 +0000 (13:33 -0400)]
Fix: Use 'echo' in a portable way
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 17:32:51 +0000 (13:32 -0400)]
Fix: Use result of AC_PROG_* when using sed / grep
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 17 Oct 2015 20:44:36 +0000 (16:44 -0400)]
Cleanup: Remove commented-out constant
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 17 Sep 2015 20:42:35 +0000 (16:42 -0400)]
Fix: use start and stop sessiond from utils.sh
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 30 Sep 2015 20:48:12 +0000 (16:48 -0400)]
Fix: Remove dependency on glibc 2.12 caused by pthread_setname_np
prctl() can be used to set the same attribute set by
pthread_setname_np, but doesn't introduce a dependency on a newer
glibc. Using prctl(PR_SET_NAME) introduces a soft dependency on
Linux 2.6.9. However, the worker won't fail to launch if the call
fails as it is set out of convenience (debugger output).
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 29 Sep 2015 16:19:00 +0000 (12:19 -0400)]
Fix: Log and ignore SIGINT and SIGTERM in run_as worker
The run_as worker is in the same process group as its parent and
will receive both SIGINT and SIGTERM. However, we want to give
the worker a chance to tear itself down gracefully when its
parent closes the command socket.
The run_as worker will now ignore these signals (although it will
log them) and wait for the parent to induce the teardown.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 29 Sep 2015 16:18:49 +0000 (12:18 -0400)]
Add logging to the run_as worker
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 24 Sep 2015 18:20:42 +0000 (14:20 -0400)]
Fix: Handle EINTR of waipid in run-as worker
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 24 Sep 2015 16:34:49 +0000 (12:34 -0400)]
Fix: Handle EINTR of waitpid when spawning a session daemon
waitpid may fail for various reasons, being interrupted being
the most frequent. In such a case, status is left uninitialized
which results in the WIFSIGNALED and WIFEXITED macros returning
undefined value, resulting in surprising logging statements such
as "killed by signal 114".
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 22 Sep 2015 21:14:45 +0000 (17:14 -0400)]
Fix: tests: support systems where PAGE_SIZE is not 4096
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 22 Sep 2015 17:55:34 +0000 (13:55 -0400)]
Test: jul/log4j: use -a instead of '*' to disable all events
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 22 Sep 2015 16:12:20 +0000 (12:12 -0400)]
Reword warning on event disable
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 22 Sep 2015 15:59:44 +0000 (11:59 -0400)]
Clean-up: Remove unused test launchers
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Mon, 21 Sep 2015 22:43:57 +0000 (18:43 -0400)]
Help: add -j -l -p option to help string
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Mon, 21 Sep 2015 22:43:56 +0000 (18:43 -0400)]
man: update disable-event section
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Mon, 21 Sep 2015 22:43:55 +0000 (18:43 -0400)]
Use empty event name on disable -a for ust and agent domain
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Mon, 21 Sep 2015 22:43:54 +0000 (18:43 -0400)]
Fix: disable kernel event based on name and event type
The -a argument is interpreted as a zero-length event name
instead of '*' which is actually a valid wildcard event
name by itself. This simplifies how a disable command is
handled by the session daemon.
The event type can now be passed as argument and is a
new criteria while disabling kernel events. The default
is to disable for all event types.
UST and agent domain do not yet support disabling by event
type.
e.g:
# Only disable kernel event of type tracepoint.
lttng disable -a -k --tracepoint
# Only disable the event with name '*' and type syscall.
lttng disable -k '*' --syscall
# Disable all kernel event of all type.
lttng disable -a -k
Fixes #925
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 21 Sep 2015 22:14:02 +0000 (18:14 -0400)]
Tests: Clean-up test-crash on SIGTERM and SIGINT
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Mon, 21 Sep 2015 20:31:25 +0000 (16:31 -0400)]
Fix: Possible dereference of null pointers
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 21 Sep 2015 20:38:01 +0000 (16:38 -0400)]
Fix: Break out of loop when searching for a domain's agent
The list command never check if a domain's agent has been found
and lists the events of every agent.
This has two direct effects:
1) Memory leak of all agents' event descriptions, except the last
2) The session daemon lists the wrong agent's events
This fix check the agent's domain and breaks out of the loop once
one is found.
Fixes #906
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Mon, 21 Sep 2015 19:19:30 +0000 (15:19 -0400)]
Fix: int printed as uint
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 19:09:10 +0000 (15:09 -0400)]
Fix: add subdir-objects to Makefile.am
Fixes the following warning introduced by the runas worker changes. Use
the same technique used in src/bin/lttng/Makefile.am.
src/common/Makefile.am:17: warning: source file 'sessiond-comm/unix.c' is in a subdirectory,
src/common/Makefile.am:17: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled. For now, the corresponding output
automake: object file(s) will be placed in the top-level directory. However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 18:10:50 +0000 (14:10 -0400)]
Fix: tests: skip UST perf tests if not root
Some distributions like Debian (e.g. Debian kernel 4.1.0-2-amd64) have
some grsecurity options enabled, such as CONFIG_GRKERNSEC_PERF_HARDEN.
Unfortunately, this option makes it impossible to use the SW page-fault
perf event as a normal user. It only leaves some HW events. However, we
can only use SW events within virtual machines.
Therefore, only run this test as root for now until we find a better
approach.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 21:03:14 +0000 (17:03 -0400)]
Fix: Check use_clone() instead of worker in run_as
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 20:16:35 +0000 (16:16 -0400)]
Fix: Perform rcu barrier before tearing down the run-as worker
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 19:50:02 +0000 (15:50 -0400)]
Fix: Handle hang-up gracefully in run-as
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 19:35:21 +0000 (15:35 -0400)]
Fix: Only log app handle release on failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 18 Sep 2015 18:46:23 +0000 (14:46 -0400)]
Fix: shm-path: handling of snprintf return value
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 18:39:13 +0000 (14:39 -0400)]
Fix: Wrong format specifier used in debug statement
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 16:59:20 +0000 (12:59 -0400)]
Tests: Swap usages of pidof for pgrep --full
Some implementations of pidof (such as the one from procps-ng)
seem immune to changing a process' name using prctl() and
overwriting argv[0]. Using preg --full works around this
problem.
In time, we should ensure every deamon publishes a PID file
which can be reliably used by the tests.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 20:35:29 +0000 (16:35 -0400)]
Tests: indefinitely wait for shm buffers to be unlinked
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 18:12:34 +0000 (14:12 -0400)]
Fix: Hide run-as functions
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 17:49:22 +0000 (13:49 -0400)]
Fix: Hide sessiond-comm functions
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 16:48:41 +0000 (12:48 -0400)]
Cleanup: remove duplicated implementation of rculfhash
lttng-tools features a duplicated copy of Userspace RCU rculfhash due to
interaction issues between runas clone() and internal libc mutexes.
Now that the runas implementation has been changed to use fork() and a
worker process, we don't need this work-around anymore. Remove the
duplicated rculfhash to lessen the maintenance burden.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 16:48:40 +0000 (12:48 -0400)]
Fix: relayd: don't call lttng_ht_destroy in RCU read-side C.S.
It is forbidden to call lttng_ht_destroy() within a RCU read-side
critical section.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 15:30:29 +0000 (11:30 -0400)]
Fix: libc internal mutex races with run_as
Implement a proper run_as worker process scheme to fix internal libc
mutex races. Those races lead to having the internal mutex held by
another process when clone() is called, thus hanging the clone child.
Now that we create the worker process when the parent process is
still single-threaded, we don't run into those issues. Implement a
standard fork + file descriptor passing over unnamed unix sockets rather
than the prior clone + shared file descriptor table, which was causing
issues with valgrind.
This adds a new process called "lttng-runas" for each sessiond
and consumerd process.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 17:29:29 +0000 (13:29 -0400)]
Fix: Hide readwrite symbols in common lib
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 17:29:11 +0000 (13:29 -0400)]
Fix: Hide pipe symbols in common lib
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 16:50:02 +0000 (12:50 -0400)]
Fix: Hide daemonize symbols in common lib
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 15:29:06 +0000 (11:29 -0400)]
Fix: Hide RCU hashtable wrapper symbols
RCU hashtable symbols shall not be exported in liblttng-ctl.so.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 01:11:43 +0000 (21:11 -0400)]
Clean-up: NULL free'd pointers in utils_partial_realpath
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.041651 seconds and 4 git commands to generate.
projects / lttng-tools.git / log
