Remove warnings in the lttv/module/text directory v2

Remove unused variable and some commented code
Use proper cast in depanalysis for the hash table entries
Fix other simple warnings
Also fix an unitialized variable usage detected by valgrind in depanalysis

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Formatteddump: checkpatch.pl coding style fixes

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add formatted dump module v5

This new plugin prints a formated output of each events in a trace. The
output format is defined as a parameter with printf like syntax.It provides
a default format easy to read and the original textDump format for backward
compatibility.
Updated: Use glib functions for solving buffer overflow problem and correct
indentation. Add another format called "strace-like".

Signed-off-by: Vincent Attard <vincent.attard@polymtl.ca>
Reviewed-by: Yannick Brosseau <yannick.brosseau@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Set the build silent by default

So we can see the warnings

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Correctly expand the passed quoted parameters

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

tracefile.c: Seek fix

Made the tracefile.c seek more robust. Fixes a rare crash where high can be
lower than low in a seek.

Matthew Khouzam <matthew.khouzam@ericsson.com>:
I am including an example to better illustrace my fix.
the current binary search has a case where high can be lower then low.
An example: 51 blocks, the element is somewhere in the 12th block.
trace of before :
 low : 0, high 51 , block_num -1
 low : 0, high 24 , block_num 25
 low : 13, high 24 , block_num 12
 low : 13, high 17 , block_num 18
 low : 13, high 14 , block_num 15
 low : 13, high 12 , block_num 13
This will assert and fail.
The trace after will produce the following walkthrough
 low : 0, high 51 , block_num -1
 low : 0, high 24 , block_num 25
 low : 0, high 24 , block_num 12
 Found!

Reported-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update version

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' of ssh://git.lttng.org/home/git/lttv

Use the prettier GtkFileChooser dialog.

(instead of the GtkFileSelector for the Add Trace menu and toolbar button
action)

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ASCII art for dep analysis

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

enhance depanalysis

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

remove debug code

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix block event resource view

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix marker_field access in the JNI interface

Reflect the new way to access marker_field fields introduced in 1184dc3

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix gcc warning in depanalysis.c

Small patch to fix typo/mispelling of sstack_item_new_event() in
lttv/modules/text/sstack.h

(GCC merely throws a warning, but Launchpad would throw a build error on
amd64.)

From: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update manual

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update manual

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update manual

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update lttng manual

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update version

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ltt traceread: fix offsets calculation, should be per tracefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Fix dynamic update of marker data across same channel tracefiles"

This reverts commit f972ab5e81be30df0ef5d690a55a6876c27b1d40.

It behaves incorrectly with trace hooks. Will keep one marker data per channel
for cache efficiency, and keep track of event payload offsets using a
per-tracefile table instead.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix typo

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update to 0.12.34

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix dynamic update of marker data across same channel tracefiles

Fixes garbled string output when the same channel / event are written by
concurrent threads. This was caused by the fact that metadata information was
shared across cpu tracefiles for a given channel.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update lttng manual: add block trace module

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update version to 0.12.33

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix statistics: take into account many tracefiles per cpu

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update manual (links)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update version and compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove libm addition, already taken care of by previous commit

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

add missing libm to configure.ac

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Indentation updates

Switch the indentation from spaces to tabs for all files in ./lttv/lttv
as per the kernel coding style.

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>

Always link against libm

This patch makes builds --without-lttv-gui work by linking against libm.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>

filter.c: add missing break

reported by Alexandre Montplaisir

hook.c: add missing braces after if()

reported by Alexandre Montplaisir

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

java interface: add script to automatically generate lib loader C code

Merge branch 'master' of git://git.dorsal.polymtl.ca/git/liblttngtrace

update manual deps

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update README glib deps.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Removing whitespace/align errors

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Changed freeHandle() to test for empty before calling free

Support for multiple trace version in the same experiment (traceset)

Merged changes needed by JNI in latest LTTv version

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update compat

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move and update documentation

Document the functions that each module may provide in each module's
respective header file.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Fix two memory leaks

Found using valgrind, of course.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Display the accuracy area below the eval graphs

Restore the trace-time graph behavior that was present before "Calculate
synchronization accuracy within the chull module". The encapsulation is not
broken however. The eval graphs show broadcast points over the accuracy area.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Calculate synchronization accuracy within the chull module

Move the linear programming-based synchronization accuracy code from the eval
module to the chull module. This avoids having to break the chull module
encapsulation to access the hull points from the eval module. As before,
accuracy information is only available if the glpk library is available at
build time.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Perform factor reduction as a modular step

Adds a fourth step of modular processing. After event processing, matching and
analysis are completed, factor reduction is performed through a module. At the
moment there is only one such module, the accuracy-based factor reduction that
was already present, but new modules can be added and selected through a
command line option.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Perform trace factor reduction as a separate step

This avoids duplicating the factor reduction (or "propagation") code in every
analysis module. Instead, analysis modules return synchronization factors for
every pair of traces and reduction is performed separately from the analysis.

If a trace pair doesn't have factors but the inverse pair does (ie. no factors
to convert the time from trace 1 to 0 but there are factors to convert the
time from trace 0 to 1), the factors from the inverted pair are used (after
being inverted themselves).

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Set the correction factors in the sync_chain

... instead of in the event_processing. Using the correction factors, at least
through lttv, is specific to the viewer, not the trace type. The sync chain is
the part that contains code specific to a viewer.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Fix a warning

"dereferencing type-punned pointer will break strict-aliasing rules"
See man gcc, -fstrict-aliasing

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Perform accuracy analysis only on hull points

This is more precise than a sample of evenly spaced points. It is also faster
on real traces.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Give more statistics about broadcast messages

Most of these only apply to the case where only two traces are synchronized.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Update README and documentation

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Change synchronization code license to LGPLv2.1

This change is to allow potential inclusion of the synchronization code in the
Tracing and Monitoring Framework project of Eclipse.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>

Merge branch 'master' of ssh://lttng.org/home/git/lttv