lttng-tools.git
8 years agoBuild: fallback to AC_CHECK_LIBS when looking for popt and uuid
Jonathan Rajotte [Tue, 1 Dec 2015 20:19:01 +0000 (15:19 -0500)] 
Build: fallback to AC_CHECK_LIBS when looking for popt and uuid

Not all distro ship .pc so fallback to basic libs searching if necessary.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agotests/unit: fix object files' location
Samuel Martin [Tue, 1 Dec 2015 23:36:45 +0000 (00:36 +0100)] 
tests/unit: fix object files' location

Referring to *.o files under a .libs/ directory is not recommended
because this belongs to libtool's innards.

Indeed, libtool decides to place the *.o files in an
implementation-specific location:
- PIC *.o files go into a .libs/ directory;
- non-PIC *.o files are generated along side to their corresponding
  source files.

Using PIC objects to build executable is legit, thought it may
introduce some minor overhead at runtime.

However, hard-coding these PIC object files in the Makefile.am to build
executables breaks the build in case of static only build.

In this case, no PIC object files is generated, so the linker will not
found some of the needed objects files.

Changing these dependencies' path fixes the static build, keeping the
shared one ok, though the non-PIC object files are now always built.

Fixes #983.

Fix tested on git master and v2.6 with no change needed.

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoconfigure.ac: fix static build
Samuel Martin [Sun, 22 Nov 2015 22:38:00 +0000 (23:38 +0100)] 
configure.ac: fix static build

For static build, some extra LDFLAGS may be needed.

Using PKG_CHECK_MODULES instead of AC_CHECK_LIB for librairy detection
allows to get all these flags. Then, the LIBS variable can be extended
with everything that is needed.

So, use PKG_CHECK_MODULES for popt and uuid detection; which both depend
on libintl.

This changes fixes build failures triggered with Buildroot, e.g.:
  http://autobuild.buildroot.net/results/0f1/0f1e015a0c5a5ac2beeb5011d31a1e0058a32a0d/build-end.log

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: fix tracefile count when page_size is > 4k
Michael Jeanson [Fri, 27 Nov 2015 21:24:28 +0000 (16:24 -0500)] 
Tests: fix tracefile count when page_size is > 4k

Set the tracefile size according to the platform page_size and increase
the number of iterations to properly test the rotation.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoconfigure.ac: use $withval with AC_ARG_WITH
Samuel Martin [Sun, 22 Nov 2015 22:38:01 +0000 (23:38 +0100)] 
configure.ac: use $withval with AC_ARG_WITH

Fixes #980

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: close indexes when rotating the trace files in mmap mode
Jérémie Galarneau [Fri, 27 Nov 2015 20:47:01 +0000 (15:47 -0500)] 
Fix: close indexes when rotating the trace files in mmap mode

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: close indexes when rotating the trace files in splice mode
Julien Desfossez [Fri, 27 Nov 2015 17:12:44 +0000 (12:12 -0500)] 
Fix: close indexes when rotating the trace files in splice mode

The consumer needs to close the old index file when doing a file
rotation before opening a new one.
The relay does not have this problem (handled with refcounts).

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoClarify error message on "add context" failure
Jérémie Galarneau [Thu, 19 Nov 2015 17:26:37 +0000 (12:26 -0500)] 
Clarify error message on "add context" failure

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Don't spam session daemon logs on invalid UST context
Jérémie Galarneau [Thu, 19 Nov 2015 17:07:56 +0000 (12:07 -0500)] 
Fix: Don't spam session daemon logs on invalid UST context

Fixes #976

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTests: getcpu_override: use event delay when launching with wrapper
Jérémie Galarneau [Thu, 12 Nov 2015 23:56:29 +0000 (18:56 -0500)] 
Tests: getcpu_override: use event delay when launching with wrapper

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTests: getcpu: no events shall be emitted at the same timestamp
Jérémie Galarneau [Thu, 12 Nov 2015 21:54:48 +0000 (16:54 -0500)] 
Tests: getcpu: no events shall be emitted at the same timestamp

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTests: Switch test apps to use usleep_safe()
Jérémie Galarneau [Thu, 12 Nov 2015 21:43:12 +0000 (16:43 -0500)] 
Tests: Switch test apps to use usleep_safe()

usleep_safe() ensures that usleep honors its timing guarantees
(which it, according to the man pages, does not strictly enforce).

Some tests need to make ensure no events are emitted at the same
timestamp since Babeltrace does not define an ordering which can
be relied upon in such a case.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTests: Add a test utils library
Jérémie Galarneau [Thu, 12 Nov 2015 21:42:05 +0000 (16:42 -0500)] 
Tests: Add a test utils library

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: redefinition of _GNU_SOURCE
Jérémie Galarneau [Thu, 12 Nov 2015 21:41:33 +0000 (16:41 -0500)] 
Fix: redefinition of _GNU_SOURCE

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTests: only call usleep if the test in configured to wait
Jérémie Galarneau [Thu, 12 Nov 2015 20:01:59 +0000 (15:01 -0500)] 
Tests: only call usleep if the test in configured to wait

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTest: add UST dl helper test
Antoine Busque [Tue, 4 Aug 2015 21:55:12 +0000 (17:55 -0400)] 
Test: add UST dl helper test

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTest: add UST baddr statedump test
Antoine Busque [Mon, 3 Aug 2015 20:16:37 +0000 (16:16 -0400)] 
Test: add UST baddr statedump test

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agolttng: add status command
Philippe Proulx [Sat, 5 Sep 2015 18:50:46 +0000 (14:50 -0400)] 
lttng: add status command

The status command is the equivalent of:
    lttng [general-options] list <current-session-name>

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agolttng: factor out declaration of commands
Philippe Proulx [Sat, 5 Sep 2015 18:15:21 +0000 (14:15 -0400)] 
lttng: factor out declaration of commands

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agomake check: add warning when LTTng processes are running
Philippe Proulx [Tue, 1 Sep 2015 02:32:11 +0000 (22:32 -0400)] 
make check: add warning when LTTng processes are running

This patch adds a warning when running LTTng/test processes are
detected at the beginning of make check. It offers a convenient
way to kill them and warns the user that some tests could fail
if the processes are kept alive.

The check can be disabled by setting
$LTTNG_TOOLS_TESTS_DISABLE_WARN_LTTNG_PROCESSES to 1

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoMissing cpu id kernel context in the kernel tracer ABI
Julien Desfossez [Wed, 11 Nov 2015 02:21:14 +0000 (21:21 -0500)] 
Missing cpu id kernel context in the kernel tracer ABI

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoUse --without-lttng-ust in error message
Michael Jeanson [Wed, 11 Nov 2015 19:54:17 +0000 (14:54 -0500)] 
Use --without-lttng-ust in error message

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoUse --with/--without for lttng-ust support
Jonathan Rajotte [Tue, 20 Oct 2015 18:57:24 +0000 (14:57 -0400)] 
Use --with/--without for lttng-ust support

Fixes #956

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoOnly compare "bison -y" to the basename of YACC variable
Jonathan Rajotte [Thu, 22 Oct 2015 20:11:18 +0000 (16:11 -0400)] 
Only compare "bison -y" to the basename of YACC variable

In the event that the YACC variable is set to a full path
this test fail even if it should not.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTests: Add debug output to getcpu_override
Jérémie Galarneau [Wed, 4 Nov 2015 23:45:04 +0000 (18:45 -0500)] 
Tests: Add debug output to getcpu_override

Adds debug output to the getcpu_override test and split its
two tests into two distinct functions. This ensures that we
output two separate traces without overwriting the previous one.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTests: Change description of clock-override test
Jérémie Galarneau [Wed, 4 Nov 2015 23:24:48 +0000 (18:24 -0500)] 
Tests: Change description of clock-override test

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoAdd event exclusion test for identical names
Philippe Proulx [Wed, 26 Aug 2015 06:26:42 +0000 (02:26 -0400)] 
Add event exclusion test for identical names

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoWarn when exclusion names are truncated
Philippe Proulx [Wed, 26 Aug 2015 22:13:23 +0000 (18:13 -0400)] 
Warn when exclusion names are truncated

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoTruncate exclusion names to have a terminal '\0'
Philippe Proulx [Wed, 26 Aug 2015 22:11:46 +0000 (18:11 -0400)] 
Truncate exclusion names to have a terminal '\0'

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoIgnore exclusion names order when matching events
Philippe Proulx [Wed, 26 Aug 2015 05:47:15 +0000 (01:47 -0400)] 
Ignore exclusion names order when matching events

In other words:

    lttng enable-event -u -a --exclude a,b,c,d  ->  passes
    lttng enable-event -u -a --exclude a,c,d,b  ->  fails (same event)

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agosessiond-comm.h: fix whitespaces
Philippe Proulx [Wed, 26 Aug 2015 05:26:10 +0000 (01:26 -0400)] 
sessiond-comm.h: fix whitespaces

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoDisallow duplicate event exclusion names
Philippe Proulx [Wed, 26 Aug 2015 05:24:02 +0000 (01:24 -0400)] 
Disallow duplicate event exclusion names

This patch makes the session daemon disallow event
exclusion names sharing the same name when creating an
UST event, e.g.:

    lttng enable-event -u -a a,b,c,d  ->  allowed
    lttng enable-event -u -a a,b,a,d  ->  disallowed

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoAdd LTTNG_EVENT_EXCLUSION_NAME_AT() helper macro
Philippe Proulx [Wed, 26 Aug 2015 05:20:24 +0000 (01:20 -0400)] 
Add LTTNG_EVENT_EXCLUSION_NAME_AT() helper macro

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: lay out names in exclusion structure correctly
Philippe Proulx [Wed, 26 Aug 2015 05:05:13 +0000 (01:05 -0400)] 
Fix: lay out names in exclusion structure correctly

This:

    char names[0][LTTNG_SYMBOL_NAME_LEN];

means that accessing

    ->names[0][i]

will return the i-th character of the first name.
So doing:

    lttng enable-event -u -a --exclude hello,a,b,c,d
    lttng save

would result in a saved session XML file containing
this:

    <exclusion>hello</exclusion>
    <exclusion>ello</exclusion>
    <exclusion>llo</exclusion>
    <exclusion>lo</exclusion>
    <exclusion>o</exclusion>

This is great art, but not what is expected.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Check for NULL hash tables on relay daemon teardown
Jérémie Galarneau [Mon, 2 Nov 2015 22:51:04 +0000 (17:51 -0500)] 
Fix: Check for NULL hash tables on relay daemon teardown

The relay daemon will log any "leaked" object on exit. However,
some errors encountered early-on during the daemon's
initialization may result in the teardown being executed with
uninitialized hash tables.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Verify directory's existence before calling mkdir
Jérémie Galarneau [Mon, 2 Nov 2015 16:39:59 +0000 (11:39 -0500)] 
Fix: Verify directory's existence before calling mkdir

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoClean-up: declare variables at beginning of scope
Jérémie Galarneau [Mon, 2 Nov 2015 21:46:16 +0000 (16:46 -0500)] 
Clean-up: declare variables at beginning of scope

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoLoad x86-exceptions lttng-modules probe
Mathieu Desnoyers [Fri, 23 Oct 2015 23:36:04 +0000 (19:36 -0400)] 
Load x86-exceptions lttng-modules probe

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoLoad x86-irq-vectors lttng-modules probe
Mathieu Desnoyers [Fri, 23 Oct 2015 22:47:11 +0000 (18:47 -0400)] 
Load x86-irq-vectors lttng-modules probe

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoAgent: Make the agent protocol consistently network endian
Jérémie Galarneau [Fri, 23 Oct 2015 21:14:55 +0000 (17:14 -0400)] 
Agent: Make the agent protocol consistently network endian

Considering the Agent Protocol is bumped to v2.0 as of 2.8.x,
this patch revisits the unfortunate decision of communicating
in host-endianness from the session daemon to the agents, and
in big endian from the agents to the session daemon.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoClean-up: Remove unused variables from default.c
Jérémie Galarneau [Fri, 23 Oct 2015 01:38:08 +0000 (21:38 -0400)] 
Clean-up: Remove unused variables from default.c

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Unchecked NULL string in logging statement
Jérémie Galarneau [Fri, 23 Oct 2015 01:37:54 +0000 (21:37 -0400)] 
Fix: Unchecked NULL string in logging statement

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: include the filter expression in agent events' primary key
Alexandre Montplaisir [Fri, 11 Sep 2015 22:38:52 +0000 (18:38 -0400)] 
Fix: include the filter expression in agent events' primary key

Similar fix to a931962, but for filter expressions this time.

UST events's key already includes the filter bytecode, so adding the
string itself should not be needed.

Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoAdd the filter expression to the enable_event agent protocol message
Alexandre Montplaisir [Wed, 9 Sep 2015 23:40:19 +0000 (19:40 -0400)] 
Add the filter expression to the enable_event agent protocol message

The filter expression is part of an event rule, so should be sent
along with the event name and log level.

This bumps the protocol version to 2.0, and will require UST agents
to be updated.

Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoAdd some IDE project files to the gitignore
Alexandre Montplaisir [Fri, 11 Sep 2015 04:06:55 +0000 (00:06 -0400)] 
Add some IDE project files to the gitignore

Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix live timer calculation error
Mikael Beckius [Wed, 21 Oct 2015 19:48:29 +0000 (15:48 -0400)] 
Fix live timer calculation error

There is an calculation error for live timer. Variable
switch_timer_interval is based on microsecond, and it is not
right to assign switch_timer_interval mod 1000000 to var tv_nsec
which is based on nanosecond.

Signed-off-by: Mikael Beckius <mikael.beckius@windriver.com>
Signed-off-by: Jianchuan Wang <jianchuan.wang@windriver.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoDon't initialize defaults in library constructor
Jérémie Galarneau [Tue, 20 Oct 2015 15:08:54 +0000 (11:08 -0400)] 
Don't initialize defaults in library constructor

This is done so lttng-tools has no dependency on constructors
being run, such as in the case of a static build.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoInitialize lttng_ht_seed on hashtable creation
Jérémie Galarneau [Tue, 20 Oct 2015 14:45:28 +0000 (10:45 -0400)] 
Initialize lttng_ht_seed on hashtable creation

This is done to get rid of the need for constructors to be executed
such as in the case of a static build.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoCleanup: Missing space after cast operator
Jérémie Galarneau [Tue, 20 Oct 2015 14:01:57 +0000 (10:01 -0400)] 
Cleanup: Missing space after cast operator

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoBuild: Switch from tar v7 to posix archive format
Jérémie Galarneau [Mon, 19 Oct 2015 23:14:12 +0000 (19:14 -0400)] 
Build: Switch from tar v7 to posix archive format

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Retry poll on interruption
Jérémie Galarneau [Mon, 19 Oct 2015 22:00:42 +0000 (18:00 -0400)] 
Fix: Retry poll on interruption

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Explicitly allocate realpath() resolved buffer
Jérémie Galarneau [Mon, 19 Oct 2015 21:37:27 +0000 (17:37 -0400)] 
Port: Explicitly allocate realpath() resolved buffer

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoSelect which binaries/extras to build at configure time
Jonathan Rajotte [Fri, 16 Oct 2015 23:08:29 +0000 (19:08 -0400)] 
Select which binaries/extras to build at configure time

Introduce new flags to the configure script to select what to build:

* By default everything is built *

--disable-bin-lttng
    Do not build anything under src/bin/lttng.
--disable-bin-lttng-consumerd
    Do not build anything under src/bin/lttng-consumerd.
--disable-bin-lttng-crash
    Do not build anything under src/bin/lttng-crash.
--disable-bin-lttng-relayd
    Do not build anything under src/bin/lttng-relayd.
--disable-bin-lttng-sessiond
    Do not build anything under src/bin/lttng-sessiond.
--disable-extras
    Do not build anything under extras.

Only the necessary libs (from src/lib and src/common) are built.
libcommon and libconfig are always built since they are used by every
target.

If any lttng-* binaries are disabled, 'tests' will not be built.
On ./configure a warning is shown to the user.
Also 'make check' and 'make checkinstall' only return a warning when 'tests'
are not built.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoMove libconsumer under common/consumer/
Jonathan Rajotte [Thu, 15 Oct 2015 20:47:34 +0000 (16:47 -0400)] 
Move libconsumer under common/consumer/

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: There is more tests than the plan
Jonathan Rajotte [Thu, 15 Oct 2015 20:45:30 +0000 (16:45 -0400)] 
Fix: There is more tests than the plan

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoRemove dead check from configure.ac
Jonathan Rajotte [Wed, 14 Oct 2015 20:20:40 +0000 (16:20 -0400)] 
Remove dead check from configure.ac

The consumerd_only variable was removed here [1].

[1]4f061d4cf16d6625ed8649095ee6df6922b5262a

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Silence warning by casting *sin_addr to *sockaddr
Michael Jeanson [Wed, 14 Oct 2015 21:06:12 +0000 (17:06 -0400)] 
Fix: Silence warning by casting *sin_addr to *sockaddr

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: fix 'ERR' conflict with Solaris regset.h
Michael Jeanson [Fri, 16 Oct 2015 14:23:46 +0000 (10:23 -0400)] 
Port: fix 'ERR' conflict with Solaris regset.h

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoRelay protocol: check string lengths
Mathieu Desnoyers [Thu, 15 Oct 2015 20:47:14 +0000 (16:47 -0400)] 
Relay protocol: check string lengths

Ensure that string lengths are not longer than what the protocol
supports on both send and receive. Ensure that path lengths fit in the
local filename length limits on the receive side. Ensure that strings
exchanged in the relay protocol are zero-terminated.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Silence warning of function having no return value
Michael Jeanson [Thu, 15 Oct 2015 21:05:05 +0000 (17:05 -0400)] 
Fix: Silence warning of function having no return value

Some compilers complain that codepaths which assert have
no return value. This is valid since assertions could
be compiled-out, resulting in an undefined return value.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Silence warnings when using uid_t and pid_t with printf
Michael Jeanson [Thu, 15 Oct 2015 21:01:34 +0000 (17:01 -0400)] 
Fix: Silence warnings when using uid_t and pid_t with printf

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add compat for platforms with no MSG_NOSIGNAL or SO_NOSIGPIPE
Michael Jeanson [Thu, 15 Oct 2015 18:55:40 +0000 (14:55 -0400)] 
Port: Add compat for platforms with no MSG_NOSIGNAL or SO_NOSIGPIPE

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris compat to sessiond-comm/unix.c
Michael Jeanson [Thu, 15 Oct 2015 18:18:15 +0000 (14:18 -0400)] 
Port: Add Solaris compat to sessiond-comm/unix.c

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris compat for netdb
Michael Jeanson [Thu, 15 Oct 2015 16:17:43 +0000 (12:17 -0400)] 
Port: Add Solaris compat for netdb

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Silence warning formating pid_t as int
Michael Jeanson [Wed, 14 Oct 2015 21:05:53 +0000 (17:05 -0400)] 
Fix: Silence warning formating pid_t as int

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris dirent compat
Michael Jeanson [Wed, 14 Oct 2015 21:05:24 +0000 (17:05 -0400)] 
Port: Add Solaris dirent compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris paths compat
Michael Jeanson [Wed, 14 Oct 2015 21:01:05 +0000 (17:01 -0400)] 
Port: Add Solaris paths compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoRename config.h to session-config.h
Michael Jeanson [Wed, 14 Oct 2015 20:51:30 +0000 (16:51 -0400)] 
Rename config.h to session-config.h

The global config.h is included on the command line with
the gcc '-include' switch which searches the local directory
before the include path. This leads to a namespace collision
with 'src/common/config/config.h'.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Remove _GNU_SOURCE, defined in config.h
Michael Jeanson [Wed, 14 Oct 2015 20:47:21 +0000 (16:47 -0400)] 
Port: Remove _GNU_SOURCE, defined in config.h

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: cleanup and portability fix to configure.ac
Michael Jeanson [Wed, 14 Oct 2015 20:23:43 +0000 (16:23 -0400)] 
Port: cleanup and portability fix to configure.ac

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Don't use SIGUNUSED which is not defined on Solaris
Jérémie Galarneau [Sat, 17 Oct 2015 23:41:47 +0000 (19:41 -0400)] 
Port: Don't use SIGUNUSED which is not defined on Solaris

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Implement prctl wrapper
Jérémie Galarneau [Sat, 17 Oct 2015 23:34:03 +0000 (19:34 -0400)] 
Port: Implement prctl wrapper

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Replace flock with fnctl
Michael Jeanson [Wed, 14 Oct 2015 20:11:48 +0000 (16:11 -0400)] 
Port: Replace flock with fnctl

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: make bootstrap script work on most shells
Michael Jeanson [Tue, 6 Oct 2015 21:38:35 +0000 (17:38 -0400)] 
Port: make bootstrap script work on most shells

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: removed unused clone() compat
Michael Jeanson [Thu, 17 Sep 2015 16:47:00 +0000 (12:47 -0400)] 
Port: removed unused clone() compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add macro for socket linking on solaris
Michael Jeanson [Thu, 17 Sep 2015 16:43:40 +0000 (12:43 -0400)] 
Port: Add macro for socket linking on solaris

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris support to mman compat
Michael Jeanson [Wed, 14 Oct 2015 20:05:38 +0000 (16:05 -0400)] 
Port: Add Solaris support to mman compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Replace dirent->d_type by stat
Michael Jeanson [Wed, 14 Oct 2015 20:02:45 +0000 (16:02 -0400)] 
Port: Replace dirent->d_type by stat

dirent->d_type is Linux specific while 'stat' is part of POSIX

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoAdd missing include for memset()
Michael Jeanson [Thu, 17 Sep 2015 14:49:53 +0000 (10:49 -0400)] 
Add missing include for memset()

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris support to socket compat
Michael Jeanson [Wed, 14 Oct 2015 19:35:21 +0000 (15:35 -0400)] 
Port: Add Solaris support to socket compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: name clash on Solaris, rename sun to s_un
Michael Jeanson [Wed, 14 Oct 2015 19:11:40 +0000 (15:11 -0400)] 
Port: name clash on Solaris, rename sun to s_un

'sun' is a reserved keyword on Solaris

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: move memset of anc_buf inside ifdef
Michael Jeanson [Wed, 14 Oct 2015 18:55:14 +0000 (14:55 -0400)] 
Port: move memset of anc_buf inside ifdef

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris fls compat
Jérémie Galarneau [Mon, 19 Oct 2015 03:44:30 +0000 (23:44 -0400)] 
Port: Add Solaris fls compat

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris string compat
Michael Jeanson [Wed, 14 Oct 2015 20:56:12 +0000 (16:56 -0400)] 
Port: Add Solaris string compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Use LTTNG_PATH_MAX instead of PATH_MAX
Michael Jeanson [Wed, 14 Oct 2015 18:35:36 +0000 (14:35 -0400)] 
Port: Use LTTNG_PATH_MAX instead of PATH_MAX

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Use LTTNG_HOST_NAME_MAX instead of HOST_NAME_MAX
Michael Jeanson [Wed, 14 Oct 2015 18:33:43 +0000 (14:33 -0400)] 
Port: Use LTTNG_HOST_NAME_MAX instead of HOST_NAME_MAX

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Use LTTNG_NAME_MAX instead of NAME_MAX
Michael Jeanson [Wed, 14 Oct 2015 18:31:03 +0000 (14:31 -0400)] 
Port: Use LTTNG_NAME_MAX instead of NAME_MAX

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris support to socket compat
Michael Jeanson [Wed, 14 Oct 2015 18:16:30 +0000 (14:16 -0400)] 
Port: Add Solaris support to socket compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris support to poll compat
Michael Jeanson [Wed, 14 Oct 2015 18:15:10 +0000 (14:15 -0400)] 
Port: Add Solaris support to poll compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris support to fcntl compat
Michael Jeanson [Wed, 14 Oct 2015 18:06:04 +0000 (14:06 -0400)] 
Port: Add Solaris support to fcntl compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoPort: Add Solaris endian.h compat
Michael Jeanson [Wed, 14 Oct 2015 17:54:38 +0000 (13:54 -0400)] 
Port: Add Solaris endian.h compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Use 'echo' in a portable way
Michael Jeanson [Wed, 14 Oct 2015 17:33:59 +0000 (13:33 -0400)] 
Fix: Use 'echo' in a portable way

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Use result of AC_PROG_* when using sed / grep
Michael Jeanson [Wed, 14 Oct 2015 17:32:51 +0000 (13:32 -0400)] 
Fix: Use result of AC_PROG_* when using sed / grep

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoCleanup: Remove commented-out constant
Jérémie Galarneau [Sat, 17 Oct 2015 20:44:36 +0000 (16:44 -0400)] 
Cleanup: Remove commented-out constant

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: use start and stop sessiond from utils.sh
Jonathan Rajotte [Thu, 17 Sep 2015 20:42:35 +0000 (16:42 -0400)] 
Fix: use start and stop sessiond from utils.sh

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Remove dependency on glibc 2.12 caused by pthread_setname_np
Jérémie Galarneau [Wed, 30 Sep 2015 20:48:12 +0000 (16:48 -0400)] 
Fix: Remove dependency on glibc 2.12 caused by pthread_setname_np

prctl() can be used to set the same attribute set by
pthread_setname_np, but doesn't introduce a dependency on a newer
glibc. Using prctl(PR_SET_NAME) introduces a soft dependency on
Linux 2.6.9. However, the worker won't fail to launch if the call
fails as it is set out of convenience (debugger output).

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Log and ignore SIGINT and SIGTERM in run_as worker
Jérémie Galarneau [Tue, 29 Sep 2015 16:19:00 +0000 (12:19 -0400)] 
Fix: Log and ignore SIGINT and SIGTERM in run_as worker

The run_as worker is in the same process group as its parent and
will receive both SIGINT and SIGTERM. However, we want to give
the worker a chance to tear itself down gracefully when its
parent closes the command socket.

The run_as worker will now ignore these signals (although it will
log them) and wait for the parent to induce the teardown.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoAdd logging to the run_as worker
Jérémie Galarneau [Tue, 29 Sep 2015 16:18:49 +0000 (12:18 -0400)] 
Add logging to the run_as worker

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Handle EINTR of waipid in run-as worker
Jérémie Galarneau [Thu, 24 Sep 2015 18:20:42 +0000 (14:20 -0400)] 
Fix: Handle EINTR of waipid in run-as worker

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: Handle EINTR of waitpid when spawning a session daemon
Jérémie Galarneau [Thu, 24 Sep 2015 16:34:49 +0000 (12:34 -0400)] 
Fix: Handle EINTR of waitpid when spawning a session daemon

waitpid may fail for various reasons, being interrupted being
the most frequent. In such a case, status is left uninitialized
which results in the WIFSIGNALED and WIFEXITED macros returning
undefined value, resulting in surprising logging statements such
as "killed by signal 114".

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.044778 seconds and 4 git commands to generate.