Rename consumer socket fd to fd_ptr

By renaming this value, first the name as a better semantic and second
we are able to find every callsite that uses this variable thus making
sure we don't forget any assert or check made on it.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Lock consumer data before fd check during destroy

Also, a consumer state error is added just before update UST
applications on registration.

Fixes #595

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Use single callsite for send/recv ops. for consumer in sessiond

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Use consumer fd reference in consumer socket obj

This is done so we don't copy the fd value of the consumer thus having a
central control. This is part of a set of patches that makes the session
daemon stop sending command to an invalid consumer (dead, closed).

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Update bash completion

- Refactor options completion to remove a little bit of code
  duplication.
- Add subcommand completion for the snapshot command. It is not perfect,
  but it's a start.
- Add some comments to functions here and there.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Add --list-commands option to the snapshot command

It lists snapshot sub-commands. This involves moving list_commands
to utils so that commands can use it.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Reorder functions _lttng_cmd_* functions in bash completion

Simply reorder them alphabetically to be consistent.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Use parse_size_suffix in snapshot

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: snapshot record error handling

Fixes #617

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: improve error message when UST support is disabled

Fixes #583

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing short filter option in help

Fixes #587

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: typo in configure.ac for version check

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: remove calibrate syscall option from code

Fixes #586

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: snapshot should fail if no successful snapshot is taken

Fixes #606, #608

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: check UST float field mantissa length

Fixes #473

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: add UST context in the same order the user enabled them

This is to avoid having different field order in different traces for
the same contexts enabled in the same order by the user.

Signed-off-by: David Goulet <dgoulet@efficios.com>

Introduce configure --with-lttng-system-rundir

Allow overriding the path where the system-wide sessiond keeps its
runtime files.

It does _not_ allow multiple instances of system-wide sessiond to run in
parallel though, because the wait shm files still requires having only
one single system-wide sessiond at any given time.

Fixes #521

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add .dirstamp to gitignore file

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: snapshot with multiple UIDs

This commit refs #615. Waiting on the confirmation of the author to
close it.

Signed-off-by: David Goulet <dgoulet@efficios.com>

Prepare for automake deprecation of missing subdir-objects

Ensure old and new automake will behave in the same way.

Fixes #594

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: typos in --help and manpage

Fixes #604

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add-context without -c apply to all channels

Fixes #618

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: channels can be _enabled_ after tracing is started, but not created

Fixes #619

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix filter parser segmentation fault with bison 3.0

Replace deprecated YYLEX_PARAM with %lex-param

Tested with bison 2.4, 2.5, 2.7 and 3.0.

Signed-off-by: Zifei Tong <soariez@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: typo in error msg

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: imprecise error message about root sessiond/tracing group

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: don't skip chmod if tracing group is not found

Fixes #620

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint probes don't need extern C

tracepoint.h has the proper extern C guards, so every liblttng-ust API
called from the probe has the proper linkage.

The rest of the symbols are only meaningful within the probe, so we
don't care if they are mangled or not.

This fixes all UST applications in tests/

Fixes #597

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Snapshot should be taken asap in core handler script

Taking a snapshot should be the first thing the core handler does.
An enormous core file write to disk could potentially discard a lot
of tracing data if done before the snapshot.

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: reset out_fd_offset when we rotate the trace file

This value is only used for the sync_file_range, but it has to be set
to 0 when we start to write in a new trace file, otherwise the values
passed to this call are bogus.

Applied to 2.3, but could probably be backported to 2.2.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: LTTNG_ERR_NEED_ROOT_SESSIOND error message

A root session daemon _and_ "tracing" group user membership are required
to trace the kernel.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

inet/inet6 sockets: apply timeout

Close #546

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Implement timeout for connect ipv4/ipv6

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Introduce LTTNG_NETWORK_SOCKET_TIMEOUT env. var

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

bash completion: add calls to _lttng_complete_sessions

Improve a little bit the dummy implementation of
_lttng_complete_sessions and add two calls where it can be useful.

Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>

bash completion: Fix copy-paste typo

Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Extras: Remove deprecated consumer commands in bash completion

enable/disable consumer were removed a while ago. Remove autocomplete
for them to discourage people of using them.

Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>

bash completion: Remove underscores in handler function names

If the command name contains a dash, it is removed to derive the
function name that will handle completion. For example, add-context
becomes _lttng_cmd_addcontext. The functions with erroneous names
were not getting called.

Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>

bash completion: Remove --event for add-context

--event has been remove in 601d5acf42ebdb05ff8aa19f12fd9bdad3602781.

Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>

Update gitignore

Signed-off-by: David Goulet <dgoulet@efficios.com>

relayd: use version macros from build rather than scanf

Acked-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

sessiond: use version major/minor from build for communication with relayd

Acked-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

build: export major/minor/patchlevel numbers

Acked-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Dead code when checking return value from (ust_app|kernel)_snapshot_record

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Test: enable kernel events after start

This test detects if we actually append new metadata when enabling a
kernel event after a start.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kernel ctl error codes are based on errno

ioctl returns -1, and error codes are based on -errno.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: format string mismatch

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

test: test_periodical_metadata_flush shrink timer period, kill app

Decrease the switch timer period to 100ms (instead of 1s), since we're
only getting 2s worth of app run. If the system is busy, nothing really
guarantee that the timer will indeed fire during this time-frame (so
strictly speaking, this test could still fail).

Also, kill the application before trying to read the trace: this should
ensure that the trace is not appended to concurrently with validation.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: format string type mismatch

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

snapshot howto: update text

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add snapshot howto

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 2.3.0-rc2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add core-handler README to dist tarball

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

extras: core-handler: simplify, allow usage from tracing group

Allow managing the coredump handler tracing session from the tracing
group. Use create --snapshot.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: add missing dot

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: documentation: create name and options

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add core dump snapshot handler script

This is a custom core dump program that will be called when a core dump
occurs.  The program will save the core data in CORE_PATH and also, if a
root session daemon is running, will record a snapshot of tracing data
using the lttng command line utility.

Refer to README for installation and testing instructions.

Sample output of test script:

Setup...
Spawning a session daemon
Session auto-20130626-224838 created.
Kernel channel chan enabled for session auto-20130626-224838
kernel event sched_switch created in channel chan
Tracing started for session auto-20130626-224838
Sleeping...
Crashing...
./test.sh: line 35: 16980 Segmentation fault      (core dumped)
$(dirname $0)/crash
Waiting for data availability
Tracing stopped for session auto-20130626-224838
Session auto-20130626-224838 destroyed
Core dump and snapshot will be available in /tmp/lttng/{core,snapshot}.

/tmp/lttng
|-- core
|   `-- core.16980
`-- snapshot
    `-- snapshot
        |-- chan_0
        |-- chan_1
        |-- chan_2
        |-- chan_3
        |-- chan_4
        |-- chan_5
        |-- chan_6
        |-- chan_7
        `-- metadata

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: sym name len (kernel)

Use kernel and not UST sym name len for kernel tracing. Fixed build when
UST is disabled.

Fix bug introduced in 2.3-rc dev cycle by:

commit 850767541647c102a299d7fbc39c97555ac70224
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date:   Fri Jul 19 09:04:29 2013 -0400

    Fix: (slight UI change) refuse missing -c if non-default channel exists

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: tests: provide channel name when a non-default channel exists: per-pid

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: tests: provide channel name when a non-default channel exists

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: data pending race

There is a data pending race involving late population of the streams in
the stream hash table, and applying flush on streams that are not yet
globally visible.

This is caused by the fact that streams are added to the hash table only
when received by the data-handling consumer thread.

This results in data_pending() incorrectly returning that there is no
data pending in some cases.

This has been discovered by adding 1s delay in read subbuffer function
for testing.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix hang in make check snapshots/test_ust

Missing a kill of the test app at the end of
test_ust_1000_local_snapshots.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: ust-consumer: wrong indentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: print dots while waiting for data availability

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove sleep(1) added by "Fix: (slight UI change) refuse missing -c if non-default channel exists"

For debugging, added by mistake.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: (slight UI change) refuse missing -c if non-default channel exists

After a user creates a channel within a session, creating a "default"
channel if a user forgets to put "-c channel_name" in the following
add-context, enable-event, disable-event commands is misleading.  The
natural expected behavior would be that the command would apply the the
last enabled channel (notion of a "current" channel, like we have for
sessions), but certainly not that it creates a new channel with default
attributes behind the user's back.

An intermediate fix that would not require to keep a notion of current
channel is to refuse creation of a default channel if at least one
non-default channel has already been created in the session.

This commit affects enable-event, disable-event and add-context
commands.

This fix belongs to the 2.3-rc cycle, and cannot be backported, since
it:

a) changes the user interface of lttng (returns an error in the case
   where -c name is missing and the session contains an non-default
   channel)
b) changes the ABI between lttng-ctl and sessiond: a default channel is
   now expressed as an empty string ('\0') rather than by "channel0",
   which allows making the difference between an explicit "channel0"
   channel and a default channel in the session daemon.

Fixes #522

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: push metadata on stop for per-UID buffers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

README: update python documentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: other layout cleanups

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of view

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of version

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of stop

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of start

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of snapshot

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of set-session

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of list

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of disable-event

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of disable-channel

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of enable-event

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of enable-channel

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of destroy

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of create

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of calibrate

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage: cleanup layout of add-context

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Documentation: create --snapshot in manpage

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 2.3.0-rc1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing snapshot header to dist tarball

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Documentation: fix thread quit pipe comment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Test for presence of bison and flex when building from git

[ Update by Mathieu Desnoyers: handle VPATH build from tarball
  by prefixing path with $srcdir. ]

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Test UST snapshot with large metadata

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add test application with large metadata

This application generates 5 tracepoints with a lot of parameters. The
resulting metadata is >12kB which is useful to test the behaviour of the
UST metadata cache and the flushing mechanism when there is more than
one metadata packet.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove redundant assignment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use per-uid buffer registry for UID buffer snapshots

Fixes empty traces when doing a snapshot after killing a single traced
application.

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

cmd.c: fix typos in snapshot commands

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Test snapshot per-uid post-mortem

Test to check if we can take a snapshot after a traced application
exited when using per-uid buffers.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove leftover fprintf

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix deadlock: don't take channel lock in timer

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Introduce channel timer lock

Currently a shadow of the channel lock. Will eventually be used to
protect channel timer handler from concurrent channel updates without
being held when the timer is stopped (future commit).

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

document lttng_ustconsumer_request_metadata locking constraints

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

consumer: remove unused lttng_ustconsumer_push_metadata

Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>