Mathieu Desnoyers [Mon, 8 Aug 2011 15:40:41 +0000 (11:40 -0400)]
Version 2.0-pre8
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 8 Aug 2011 15:08:29 +0000 (11:08 -0400)]
Cleanup compiler warnings
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 8 Aug 2011 06:13:27 +0000 (02:13 -0400)]
Allow tracing group users to read trace files they generated
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 8 Aug 2011 05:22:00 +0000 (01:22 -0400)]
Fix handling of sessiond respawn after a SIGKILL
Checking if the sessiond responds to connect() lets lttng / ltt-sessiond
check correctly if the socket files are stale files or actively used.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 8 Aug 2011 04:31:41 +0000 (00:31 -0400)]
Safe list iteration in kconsumerd: protect against free()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 8 Aug 2011 04:29:01 +0000 (00:29 -0400)]
Add --verbose-kconsumerd option to sessiond
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 8 Aug 2011 04:03:04 +0000 (00:03 -0400)]
ltt-sessiond teardown cleanup
ltt-sessiond now kills (SIGTERM) the kconsumerd before exiting, so the
LTTng module unload succeeds. Previously, the kconsumerd was still
holding a reference on ltt-relay.ko -- it was only being released after
ltt-sessiond closed its communication socket with kconsumerd.
Now, all the teardown actually wakes each thread, getting them to
return, and main() joins each of them before calling cleanup().
Previously, we had no guarantee that threads would not run concurrently
with cleanup() executed from the signal handler.
It would still be good to audit _each_ read call so we ensure that they
are performed on O_NONBLOCK fcntl fds (as we did in the kconsumerd), so
all the blocking is done in a poll() call, which can be woken up by the
sessiond termination file descriptor too (from the signal handler).
Failure to respect this could lead to races where sessiond blocks on a
file descriptor and never really honour the signal for a thread, thus
leading to blocking of the main() thread on a join.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 6 Aug 2011 18:57:08 +0000 (14:57 -0400)]
Version 2.0-pre7
Mathieu Desnoyers [Sat, 6 Aug 2011 18:21:51 +0000 (14:21 -0400)]
Add calibrate.txt
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 6 Aug 2011 18:04:46 +0000 (14:04 -0400)]
mkdir_recursive: keep original prototype
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 6 Aug 2011 17:55:23 +0000 (13:55 -0400)]
Cleanup mkdir_recursive indent
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 6 Aug 2011 15:05:04 +0000 (11:05 -0400)]
Make "please specify tracer" comment more helpful
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 6 Aug 2011 06:33:48 +0000 (02:33 -0400)]
Add calibrate command
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 6 Aug 2011 05:50:23 +0000 (01:50 -0400)]
Fix module unload order
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 5 Aug 2011 20:28:01 +0000 (16:28 -0400)]
Unload lttng modules when sessiond quits
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 4 Aug 2011 01:43:39 +0000 (21:43 -0400)]
Remove all remaining sessiond kernel command
All command now uses the lttng_domain
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Thu, 4 Aug 2011 01:21:12 +0000 (21:21 -0400)]
Change disable event command to be per domain
Removes LTTNG_KERNEL_DISABLE_EVENT and use a generic command based on
lttng domain.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Thu, 4 Aug 2011 01:03:27 +0000 (21:03 -0400)]
Remove path and session from session message
Replace the two by a lttng_session structure.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Thu, 4 Aug 2011 00:55:02 +0000 (20:55 -0400)]
Change disable channel command to be per domain
Removes LTTNG_KERNEL_DISABLE_CHANNEL and use a generic command based on
lttng domain.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 3 Aug 2011 22:50:13 +0000 (18:50 -0400)]
Rewrite the add context command of sessiond
Introduce context.c/.h which contains code to manage lttng context.
The add context command is now based on the lttng domain removing the
LTTNG_KERNEL_ADD_CONTEXT to simply LTTNG_ADD_CONTEXT.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 3 Aug 2011 21:23:56 +0000 (17:23 -0400)]
Remove session daemon kernel list events command
Replace this command by list tracepoints and use the domain for listing.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 3 Aug 2011 21:11:44 +0000 (17:11 -0400)]
Improve protection around strncpy and memcpy calls
Add copy_string which check for null pointer and add the null terminated
byte by default.
All pointer pass to memcpy are checked for null value.
All lttng_domain pointer are checked also for null value.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 3 Aug 2011 20:28:21 +0000 (16:28 -0400)]
Change list kernel events to list tracepoints
Remove lttng_list_kernel_events to lttng_list_tracepoints(domain).
Make it generic to lttng domain and specific for tracepoints which are
static instrumentation.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 3 Aug 2011 20:06:55 +0000 (16:06 -0400)]
Fix uninitialized variable
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 3 Aug 2011 19:56:54 +0000 (15:56 -0400)]
Improve the lttng list feature
Introduce three new functions to the public API which are
lttng_list_channels, lttng_list_events and lttng_list_domains.
Also add the lttng_list_kernel_events which list available tracing
events of the kernel.
Adds new options to the lttng list command for listing a lot more
details of a tracing session including channels, events and domains.
Also adds the enabled flag to the lttng_event and lttng_channel
structure.
Fix a bad pointer cast in list events.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Mathieu Desnoyers [Tue, 2 Aug 2011 17:46:52 +0000 (13:46 -0400)]
Update quickstart
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Mon, 1 Aug 2011 17:37:49 +0000 (13:37 -0400)]
Fix missing session list unlock
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Mathieu Desnoyers [Fri, 29 Jul 2011 18:45:36 +0000 (14:45 -0400)]
Update quickstart
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Fri, 29 Jul 2011 15:30:44 +0000 (11:30 -0400)]
Update version to 2.0-pre6
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Mathieu Desnoyers [Thu, 28 Jul 2011 22:45:37 +0000 (18:45 -0400)]
Add kretprobe support (new --function implementation)
Add kretprobe support (new --function implementation)
Also support probe "symbol" (without +offset) by checking first
character with isalpha().
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Fri, 29 Jul 2011 15:15:20 +0000 (11:15 -0400)]
Fix multiple enable events
The session name was not set after the first event enabled.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Thu, 28 Jul 2011 19:33:11 +0000 (15:33 -0400)]
Update version to 2.0-pre5
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Thu, 28 Jul 2011 17:15:32 +0000 (13:15 -0400)]
Print trace output patch on lttng create
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Thu, 28 Jul 2011 17:12:34 +0000 (13:12 -0400)]
Fix adding multiple kernel context at once
The session name was not set when multiple add-context was asked.
Also fix error message and session daemon return error when one add
kernel context fails.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Thu, 28 Jul 2011 16:13:35 +0000 (12:13 -0400)]
Fix auto session path duplication
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Thu, 28 Jul 2011 16:13:02 +0000 (12:13 -0400)]
Fix bad strncmp length
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 27 Jul 2011 20:32:27 +0000 (16:32 -0400)]
Update version to 2.0-pre4
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 27 Jul 2011 20:26:21 +0000 (16:26 -0400)]
Fix channel creation when enabling an event
If the channel is not found when enabling an event, that channel will be
created.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 27 Jul 2011 20:15:24 +0000 (16:15 -0400)]
Add event count in channel structure
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 27 Jul 2011 20:13:46 +0000 (16:13 -0400)]
Fix uninitialized kprobe attributes
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 27 Jul 2011 19:01:29 +0000 (15:01 -0400)]
Fix bad address conversion
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Tue, 26 Jul 2011 15:43:35 +0000 (11:43 -0400)]
Trace path creation made on the client side
The traces output path is set on the client side with the date and time
if no output path is specified.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Tue, 26 Jul 2011 14:59:20 +0000 (10:59 -0400)]
Fix safe list iteration
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Tue, 26 Jul 2011 14:45:43 +0000 (10:45 -0400)]
Add reset of the session message
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Tue, 26 Jul 2011 14:01:26 +0000 (10:01 -0400)]
Fix comments in main.c
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Tue, 26 Jul 2011 13:45:34 +0000 (09:45 -0400)]
Increase possible verbose level for session daemon
Using -vv, the kernel consumer goes into verbose mode.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Tue, 26 Jul 2011 13:33:42 +0000 (09:33 -0400)]
Fix set session command
The command was appending a new session name and not replacing it.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 25 Jul 2011 20:50:12 +0000 (16:50 -0400)]
Add kernel trace data structure test
Test all kernel data structure found in ltt-sessiond/trace.c/.h.
Also adds a utils.h having a pretty print for OK and FAIL. The session
test is modified to use those prints.
Better runall.sh which iterates over an array containing test binaries
name and terminates when one test fails.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 25 Jul 2011 20:48:50 +0000 (16:48 -0400)]
Fix missing pointer initialisation
Channel and event context pointer was not set to NULL at creation.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 25 Jul 2011 17:36:00 +0000 (13:36 -0400)]
Add tracing session test
Tests the tracing session functions found in ltt-sessiond/session.h/.c
Creation, destruction and iteration is tested.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Sat, 23 Jul 2011 17:06:07 +0000 (13:06 -0400)]
Update version to 2.0-pre3
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Mathieu Desnoyers [Sat, 23 Jul 2011 08:36:38 +0000 (04:36 -0400)]
Fix perf hw cache counter config values
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Fri, 22 Jul 2011 20:20:08 +0000 (16:20 -0400)]
Update version to 2.0-pre2
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Fri, 22 Jul 2011 20:00:26 +0000 (16:00 -0400)]
Add missing fprintf format
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Mathieu Desnoyers [Fri, 22 Jul 2011 19:06:23 +0000 (15:06 -0400)]
UI print cleanup
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 22 Jul 2011 19:04:48 +0000 (15:04 -0400)]
Use "probe" rather than "kprobe" for UI
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 22 Jul 2011 19:04:30 +0000 (15:04 -0400)]
Update quickstart for new perf UI
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 22 Jul 2011 18:38:58 +0000 (14:38 -0400)]
Update handling of perf counters in add-context
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 22 Jul 2011 18:38:17 +0000 (14:38 -0400)]
Remove assert from kconsumerd (multi-fd handling is ok)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 22 Jul 2011 18:05:53 +0000 (14:05 -0400)]
Cleanup header
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 21 Jul 2011 20:40:24 +0000 (16:40 -0400)]
Add string options for add-context
List of strings can be used for context type, perf type and perf id.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Mathieu Desnoyers [Thu, 21 Jul 2011 18:16:05 +0000 (14:16 -0400)]
Fix sending fd through sendmsg/recvmsg ancillary data
ltt-kconsumerd was only reading a "char" rather than an integer. It
worked fine on little endian for values below 256, and failed on big
endian machines (always reading "0").
Also cleanup msg initialization.
Also perform final msg.msg_controllen = cmsg->cmsg_len; after memcpy, as
done in cmsg(3) example (extra safety).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 21 Jul 2011 16:07:43 +0000 (12:07 -0400)]
Improve add-context command
Better multiple context type handling using a linked list at args
parsing.
Change some error message.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Thu, 21 Jul 2011 14:47:55 +0000 (10:47 -0400)]
Update and add to the quickstart guide
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 21:18:58 +0000 (17:18 -0400)]
Merge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Wed, 20 Jul 2011 21:18:07 +0000 (17:18 -0400)]
Rename binary installation path define
INSTALL_PATH --> INSTALL_BIN_PATH
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Mathieu Desnoyers [Wed, 20 Jul 2011 21:11:51 +0000 (17:11 -0400)]
Fix double-unlock in kconsumerd_find_session_fd()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Wed, 20 Jul 2011 20:40:41 +0000 (16:40 -0400)]
Fix error handling
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Simon Marchi [Wed, 20 Jul 2011 19:31:49 +0000 (15:31 -0400)]
Remove format strings warnings when compiling on 32 bits
On 32 bits, %lu expects a 32 bits integer, so changed some %lu for PRIu64 when printing a 64 bits integer.
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 20:17:29 +0000 (16:17 -0400)]
Use install path for exec()
Add INSTALL_PATH define for binary execution path.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 19:47:11 +0000 (15:47 -0400)]
Fix set but no use variables warnings
Shown with gcc >= 4.6.0
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 16:38:53 +0000 (12:38 -0400)]
Update version to 2.0-pre1
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 16:18:59 +0000 (12:18 -0400)]
Update authors
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 15:39:36 +0000 (11:39 -0400)]
Change bzip2 for dist tarball
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 15:38:31 +0000 (11:38 -0400)]
Fix session trace output message
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 15:28:34 +0000 (11:28 -0400)]
Add usage section to README
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 15:07:31 +0000 (11:07 -0400)]
Fix README and add doc to tarball
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 14:23:16 +0000 (10:23 -0400)]
Fix build system for valid make dist
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Wed, 20 Jul 2011 13:41:49 +0000 (09:41 -0400)]
Remove debug mode at kconsumerd exec
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 22:14:08 +0000 (18:14 -0400)]
Fix wrong spacing
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 21:55:58 +0000 (17:55 -0400)]
Fix invalid channel creation
Also add a message when all events are successfully enabled.
Reported-by: Simon Marchi <simon.marchi@ericsson.com>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Julien Desfossez [Sun, 17 Jul 2011 16:46:08 +0000 (12:46 -0400)]
Make the receiving thread non blocking
Avoids the risk of blocking indefinitely on the command socket when the
ltt-sessiond is not available and allow the signal handler to stop the
process when necessary.
Signed-off-by: Julien Desfossez <julien.desfossez@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 21:49:02 +0000 (17:49 -0400)]
Change licensing
Public API lttng.h and liblttngctl.c is licensed LGPLv2.1.
The rest of the code is licensing GPLv2 and NOT later.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 21:17:25 +0000 (17:17 -0400)]
Change lttng.h API char to const char
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 20:47:58 +0000 (16:47 -0400)]
New public API for lttng control
Introduce the lttng domain that is used to identify the tracer.
Remove all 'kernel' from the functions name and now take the domain
struct as first parameter.
Add channel feature is removed and merged with enable-channel.
Move kernel specific data structure from lttng.h to lttng-kernel.h which
is copied from the LTTng kernel modules ABI. Genereic structures are
used to create a generic view of lttng event and attributes (agnostif of
the Kernel and user-space).
Default channel is NOT created unless it is needed.
A lot of comments has been added to lttng.h
Fix a bug in the liblttngctl. A return value was not set correctly.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 14:57:49 +0000 (10:57 -0400)]
Remove connect/disconnect sessiond from lttng API
Those actions are made internally when a command to the session daemon
is done so no need for them to be public.
Move code around to make things clearer and fit static declaration.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Mathieu Desnoyers [Mon, 18 Jul 2011 15:43:52 +0000 (11:43 -0400)]
quickstart guide review
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Mon, 18 Jul 2011 14:50:47 +0000 (10:50 -0400)]
Makes kprobe attribute specific to kernel
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 14:37:48 +0000 (10:37 -0400)]
Fix tracing events data structure
Make lttng_kernel_output generic to user-space and kernel becoming
lttng_event_output.
Renaming enum to fit kernel ABI.
Add comments.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 00:34:02 +0000 (20:34 -0400)]
Remove libustctl and libustcomm
Those libs are part of the soon to be deprecated user-space tracer. The
code is removed but not the directories and Makefile.am.
lttng-tools will only support UST 2.0 which is not yet released at this
point in time. Thus, this is not useful anymore and will be readded
later on to support the new user-space tracer.
Also disable a small portion of code in the session daemon that uses
libustctl. This code however remains relevant for future UST
integration.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 00:26:45 +0000 (20:26 -0400)]
Remove not working test
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Mon, 18 Jul 2011 00:21:45 +0000 (20:21 -0400)]
Add quick start tracing guide
First draft of a quick start guide. For now, there is only the kernel
tracing guide since ust 2.0 is not released at this point.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Sun, 17 Jul 2011 23:43:33 +0000 (19:43 -0400)]
Add session daemon model RFC
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Sun, 17 Jul 2011 23:35:20 +0000 (19:35 -0400)]
Add short option for no sessiond feature
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Sun, 17 Jul 2011 17:10:44 +0000 (13:10 -0400)]
Add error message if event not found
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Sun, 17 Jul 2011 17:04:14 +0000 (13:04 -0400)]
Fix return code to 0 on success and 1 on error
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Sun, 17 Jul 2011 16:50:25 +0000 (12:50 -0400)]
Fix session list locking
The session list lock was not used correctly when a client requested the
session list. The session counter and iteration over the list is
protected by a single critical section now.
Move get_lttng_sessions to the main.c in order to remove lttng.h
dependency to session.c/.h and to make easier for the session list
locking.
Remove the get_session_count which is useless since the counter is now
in the session list structure. Access the counter by locking the list
and reading 'count'.
This adds two function to lock and unlock the session list.
Reported-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Sun, 17 Jul 2011 16:23:54 +0000 (12:23 -0400)]
Fix bad cleanup of context structure
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Sat, 16 Jul 2011 22:22:16 +0000 (18:22 -0400)]
Fix bad exit conditions
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
David Goulet [Sat, 16 Jul 2011 22:05:32 +0000 (18:05 -0400)]
Clean exit cleanup of the session daemon
Remove the pthread_cancel and introduce the *thread_quit_pipe* that is
used to tell a thread that it should exit cleanly. This pipe is added to
the pollfd set of the thread and has to be close in order to trigger the
clean exit of the threads.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
This page took 0.040292 seconds and 4 git commands to generate.