Nils Carlson [Tue, 15 Mar 2011 14:08:33 +0000 (15:08 +0100)]
libust: Remove lots of dead code and comments in tracer.c
Remove lots of code that wasn't being called or did nothing
as well as lots of commented code and unnecessary comments.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Nils Carlson [Tue, 15 Mar 2011 13:17:34 +0000 (14:17 +0100)]
libust: New transport mutex v2
Changes since v1:
Add a nesting comment
Make the locking around the transport list more intelligent, give
it its own mutex.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Tue, 15 Mar 2011 09:49:17 +0000 (10:49 +0100)]
Changelog and version updates for v0.12
Nils Carlson [Thu, 10 Mar 2011 12:55:27 +0000 (13:55 +0100)]
libustfork: link against libust
libustfork needs to link against libust as it makes calls into
libust.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Thu, 10 Mar 2011 10:27:42 +0000 (11:27 +0100)]
libust: Remove some unused variables
More spring cleaning.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Thu, 10 Mar 2011 10:23:24 +0000 (11:23 +0100)]
libust: Remove the now useless open_buffers list.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Thu, 10 Mar 2011 10:12:35 +0000 (11:12 +0100)]
libust: remove process_simple_client_cmd function
It was only used by one command, so move the command into
the big case statement and remove a now unnecessary function.
Spring cleaning.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Thu, 10 Mar 2011 09:58:44 +0000 (10:58 +0100)]
Change force_subbuffer switch to be per trace
Change force_subbuffer switch to act on a per trace basis becuase this
is what we want almost all the time. This will simplify periodic flushing
of some traces and other features we might want in the future.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Mon, 7 Mar 2011 16:20:34 +0000 (17:20 +0100)]
libustconsumer: Fix a fd leak of the pipe_fd
libustconsumer wasn't properly closing pipe_fds sent by
libust. Make it do so.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Yannick Brosseau [Fri, 4 Mar 2011 18:53:40 +0000 (13:53 -0500)]
Add a test for urcu 0.5.4 which we now depends on
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 4 Mar 2011 17:32:35 +0000 (12:32 -0500)]
Update liburcu dependency to 0.5.4
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 4 Mar 2011 17:31:32 +0000 (12:31 -0500)]
Use liburcu-bp before/after fork (parent/child) callbacks
Handle fork() gracefully with urcu-bp. Dependency on urcu-bp 0.5.4.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Nils Carlson [Fri, 4 Mar 2011 15:08:39 +0000 (16:08 +0100)]
test: fix the valgrind test-case to not hang if valgrind crashes
In previous version of the test-case the test-case would hang forever
if valgrind crashes (which it does on my debian squeeze PPC).
Fix this by checking that valgrind is alive.
Also cleanup leftover fifos in /tmp
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Mathieu Desnoyers [Fri, 4 Mar 2011 14:13:15 +0000 (09:13 -0500)]
Remove duplicated marker id dump
Marker ID is already dumped at:
- trace start (with marker dump)
- when a marker is enabled (probe callback associated with marker).
So this should cover all cases:
- either we have a marker in a lib/program that is already enabled, and start
tracing after a library is loaded, for which the marker dump will catch the
marker id.
- or we have a marker in a lib/program that is not enabled, and start tracing
after a library is loaded. If after that we enable the marker, an event
describing the marker ID will be generated.
- or if have tracing running, and then we enable a marker (connect probe to
marker) for a marker located in a yet-unloaded library. In this case, the
marker ID event is generated when we connect the probe to the marker, even if
the library is not yet loaded.
The cases are similar for the marker format, except that it is valid to have an
unknown marker format when we connect a marker probe. In that case, the format
will be written into the trace by marker_set_format, called upon library load.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 4 Mar 2011 14:10:40 +0000 (09:10 -0500)]
Fix off-by-one in open_memstream
size returned by open_memstream does not include the final \0. We have to add
1 to the size of the message sent.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 4 Mar 2011 13:01:50 +0000 (08:01 -0500)]
Debug message cleanup
We cannot use the number of pointers - 1 to know the number of markers/tp/tc,
because we can have more than one NULL pointer per shared object.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 3 Mar 2011 23:21:52 +0000 (18:21 -0500)]
Add pthread cleanup to listener (to cleanup mutex)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 3 Mar 2011 20:57:14 +0000 (15:57 -0500)]
Remove dummy markers/tracepoints/trace events
Add a null pointer in the marker/tp/te tables instead of a full-blown dummy
marker. Skip the null pointers in the marker/tp/te iterators.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 3 Mar 2011 18:17:16 +0000 (13:17 -0500)]
finish_consuming_dead_subbuffer: cleanup
Use the same iterator as error printing to iterate on the last subbuffers.
Removes a lot of iterator duplication and extra unneeded modulo operations.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 3 Mar 2011 17:53:52 +0000 (12:53 -0500)]
finish_consuming_dead_subbuffer: fix data_size read race, reread new consumed count
Make sure finish_consuming_dead_subbuffer always see a data_size that is non
0xffffffff only when the buffer data is entirely readable, else the code rely on
the commit_seq counter which is the proper solution.
The consumed count should be re-read in each test within the loop, otherwise the
mathematic formula to get the amount of data to read does not work wrt
buffer-size wrap-around.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 3 Mar 2011 16:59:42 +0000 (11:59 -0500)]
libustconsumer: check read subuffer return value
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 3 Mar 2011 16:46:20 +0000 (11:46 -0500)]
fork: child should issue synchronize_rcu() for urcu-bp garbage collection
After a fork(), the child process should execute synchronize_rcu() before any
new thread can be created. Failure to do so could lead to a deadlock in the
unlikely scenario where a thread ID appearing in the parent is reused in the
child before GC is performed.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 3 Mar 2011 16:38:47 +0000 (11:38 -0500)]
Add missing listener threads data vs fork() protection
The following races are problematic:
- fork() occurs concurrently with listener thread receiving commands.
- Mutexes and data structures can be left in incoherent state.
- fork() occurs concurrently with ust library destructor.
- listen_sock can be left in incoherent state in the child.
Protect these resources with their own specific mutex.
listener_thread_data_mutex protects all data/mutexes touched by the listener
thread. It is also held across fork to make sure the child see a coherent
version of these structures.
listen_sock_mutex protects the listen_sock teardown (pthread cancel done at
libust destructor). Is is also held across fork() to protect from concurrent
teardown of listen_sock. We add a check around listen_sock teardown to see if it
has already been deleted (which could happen if the destructor runs concurrently
with fork().
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 3 Mar 2011 15:48:11 +0000 (10:48 -0500)]
Code base to fix the print errors in UST (v4)
Update:
v2: Use commit_seq instead of commit_count to fix a consumerd segfault when
accessing commit_count, since it is not mapped.
v3: Remove commented out code
v4: Remove unused variable
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jason Wessel [Thu, 3 Mar 2011 02:21:07 +0000 (21:21 -0500)]
ustctl: Fix memory allocation problem with compatibility args
The parenthesis were missing to make the malloc math have the correct
precedence. The addition needs to occur before the multiplication.
The result is the same but for clarity also change change char ** to
char * because we are allocating an array of char pointers.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Nils Carlson [Fri, 25 Feb 2011 08:39:03 +0000 (09:39 +0100)]
ustctl: fix a broken format string
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Jason Wessel [Thu, 24 Feb 2011 20:40:12 +0000 (21:40 +0100)]
Allow backward compatibility to ustctl <= 0.11 for some commands
The rewrite of the ustctl broke all the existing scripts
that make use of ustctl. This allows the original commands,
examples, and external scripts to continue working properly.
This covers the commands:
--list-markers
--list-trace-events
--alloc-trace
--start-trace
--stop-trace
--create-trace
--destroy-trace
--enable-marker
--disable-marker
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Fri, 4 Feb 2011 07:24:51 +0000 (08:24 +0100)]
libustctl: use direct socket communication
This patch changes libustctl to be socket instead of pid oriented.
The user is expected to connect to a pid using
ustctl_connect_pid(pid_t) which returns a socket file-descriptor and
then use the socket for the rest of the api. This reduces the amount
of open and closing systemcalls and also makes it possible for a
session daemon to detect process shutdown by the socket closing.
David, this ones for you. :-)
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Nils Carlson [Thu, 24 Feb 2011 08:54:28 +0000 (09:54 +0100)]
tests: Add a comment in libustctl function tests
Add a comment regarding activation of non-existent markers
and fix a trailing whitespace.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Yannick Brosseau [Wed, 23 Feb 2011 17:46:22 +0000 (18:46 +0100)]
Fix libustctl_function_tests
After discussions, we concluded that the enable a non existing marker is a valid case, so we
move it to the working case section.
While being there, check that the re-enable a marker set the right errno
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Wed, 23 Feb 2011 12:34:41 +0000 (13:34 +0100)]
libust: Fix multiple fd close during fork v2
Remove superfluous fd closes during fork and also destroy all
traces instead of just "auto".
Changes since v1: Also stop all traces
Reported-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Yannick Brosseau [Wed, 23 Feb 2011 15:10:31 +0000 (10:10 -0500)]
Also use short signal name for the trap function
Following the switch from bash to sh, as for
commit
a1bece556695c05c03d4eb83066df553c2fc56b9,
the signal name used by the trap function also need to be changed
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Tue, 22 Feb 2011 23:30:30 +0000 (00:30 +0100)]
Initialize _res_header variable to zero before use in process_client_cmd
This use of a non-initialized variable was detected by the valgrind test.
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Acked-by: Nils Carlson <nils.carlson@ericsson.com>
Yannick Brosseau [Tue, 22 Feb 2011 23:25:19 +0000 (00:25 +0100)]
Change the valgrind test to use the libraries from the build directory
Also add the $USER name to all temp files so multiple users don't conflict.
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Acked-by: Nils Carlson <nils.carlson@ericsson.com>
Yannick Brosseau [Mon, 21 Feb 2011 19:36:09 +0000 (20:36 +0100)]
TESTS: Add a delay at the start of the fork test for a more uniform testing.
Add a sleep to leave time for the ustconsumer thread to initialize correctly
before the fork.
Most of the time the consumer was not yet started at the time of the fork so
a bunch of initializations were not done and the fork code path was not
tested properly.
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Acked-by: Nils Carlson <nils.carlson@ericsson.com>
Mathieu Desnoyers [Wed, 23 Feb 2011 04:22:44 +0000 (23:22 -0500)]
Cleanup error handling in open_channel
Reported-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jason Wessel [Tue, 22 Feb 2011 22:37:25 +0000 (17:37 -0500)]
usttrace: use short signal names for busybox compatibility
The kill command in coreutils will accept the short signal name, but
various versions of busybox will not accept the long signal name. For
compatibility with busybox use the short signal name.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jason Wessel [Tue, 22 Feb 2011 22:36:03 +0000 (17:36 -0500)]
usttrace: Use /bin/sh instead of /bin/bash for busybox compatibility
The busybox posix like shell does not understand the "function"
directive nor does it understand the syntax for redirecting a file via
a shell expanded variable with $(<$pidfilepath). Busybox also does
not typically provide a link to /bin/bash since busybox does not
provide bash.
It is possible to work around all these limitations in order to allow
user space tracing to work properly in a busybox based environment
with several syntax changes to the usttrace script.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jason Wessel [Tue, 22 Feb 2011 22:34:09 +0000 (17:34 -0500)]
add ARM specific support for UST
Add the link definition and the inline assembly required for User
Space Trace support on ARM.
[ edit: coding style cleanup ]
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 22 Feb 2011 22:29:31 +0000 (17:29 -0500)]
Add arch-agnostic fls() fallback
In preparation for ARM port.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 22 Feb 2011 17:31:48 +0000 (12:31 -0500)]
markers: ensure assembly is portable by using .hword instead of .word
http://www.chemie.fu-berlin.de/chemnet/use/info/gas/gas_7.html
.hword expressions
This expects zero or more expressions, and emits a 16 bit number for each.
This directive is a synonym for `.short'; depending on the target architecture,
it may also be a synonym for `.word'.
(caused marker struct layout discrepancy on ARM)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 22 Feb 2011 16:39:54 +0000 (11:39 -0500)]
markers: fix: teardown should be tagged with "destructor" attribute
..rather than "constructor", which led to the core markers being removed from
the list before doing anything useful.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Nils Carlson [Mon, 21 Feb 2011 13:12:14 +0000 (14:12 +0100)]
tests: skip the non-functioning tracepoint test
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Mon, 21 Feb 2011 09:17:26 +0000 (10:17 +0100)]
fix valgrind test valgrind check
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Mathieu Desnoyers [Tue, 22 Feb 2011 14:15:48 +0000 (09:15 -0500)]
Fix marker/tracepoint/trace_event lib list: expected to be sorted
Sort library lists.
List operations expect the library lists to be sorted by pointer addresses (this
was needed for iteration on kernel modules without having to hold the mutex
across read system calls). It's usefulness in userspace is debatable, but there
is clearly a bug here, since the code that iterates on the lists still expects
them to be sorted.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Mon, 21 Feb 2011 01:30:05 +0000 (20:30 -0500)]
Use the libust.so and libustinstr-malloc.so from the build directory
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Sun, 20 Feb 2011 15:19:36 +0000 (10:19 -0500)]
tests: fix tap.c use of uninitialized pipe_r_file
[ Edit: updated patch header ]
The _tap_comment_stdout thread can start using pipe_r_file when it
is still uninitialized. Fix it by moving the initialization before the pthread
creation.
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Fri, 18 Feb 2011 21:34:06 +0000 (16:34 -0500)]
Test for the presence of the tracepoint_test file before running the test
Since the test is disabled in the makefile, don't try to execute it in the
script.
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Fri, 18 Feb 2011 21:58:21 +0000 (16:58 -0500)]
Add missing -lpthread to some tests
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Fri, 18 Feb 2011 21:57:43 +0000 (16:57 -0500)]
Test for the presence of valgrind in the valgrind test
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Fri, 18 Feb 2011 21:57:07 +0000 (16:57 -0500)]
Use usttrace and libraries from the build directory in the test scripts
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Fri, 18 Feb 2011 21:55:25 +0000 (16:55 -0500)]
Try harder to find a usable lttv in the tests scripts v2
Add many more attempts to auto-detect the path to the lttv executable or
the runlttv script in trace comparison tests.
Also support setting the LTTV env variable to directly set a path the
the lttv executable in addition to the RUNLTTV variable
Changelog:
Correctly manage multiple traces
[ Edit: fix merge conflict ]
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Fri, 18 Feb 2011 21:39:07 +0000 (16:39 -0500)]
Fix segfault in ust_fork
Move the ltt_trace_destroy after the iteration of open_buffer_list. The destroy
free the pointers used in the open_buffer_list
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 17 Feb 2011 20:19:06 +0000 (15:19 -0500)]
Remove marker 8-byte alignment
The pointer array should not by 8-byte aligned, because it breaks 32-bit archs.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 17 Feb 2011 20:15:20 +0000 (15:15 -0500)]
Remove "progbits" section flag
progbits is set by default on all architectures, and the ARM gcc does not like
when it's explicitely there. So remove it.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 17 Feb 2011 19:55:57 +0000 (14:55 -0500)]
markers: fix use of ptrs
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 17 Feb 2011 19:55:41 +0000 (14:55 -0500)]
Tracepoints: fix use of __ptrs
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 17 Feb 2011 19:34:55 +0000 (14:34 -0500)]
Tracepoints: refer to new section name
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 17 Feb 2011 19:32:06 +0000 (14:32 -0500)]
Trace event: export pointer array
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 17 Feb 2011 19:18:08 +0000 (14:18 -0500)]
markers: export pointer array instead of struct marker
Ensures we don't end up running in gcc/linker structure alignment problems by
exporting an array of pointers instead of the structures per se.
Same fix as done for tracepoints for the mainline kernel.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 17 Feb 2011 18:25:52 +0000 (13:25 -0500)]
tracepoints: export pointer array
Fixes odd alignment issues between linker and compiler, caused by compiler
using larger alignment values than expected for structures -- and the linker
adding unexpected padding within the sections. Use the same technique recently
introduced for Linux kernel tracepoints.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 17 Feb 2011 18:25:19 +0000 (13:25 -0500)]
test_functions.sh: don't override RUNLTTV
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 14 Feb 2011 17:22:26 +0000 (12:22 -0500)]
markers: assembly definition should also align on 128
Needed to match the expected C layout.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 14 Feb 2011 17:03:09 +0000 (12:03 -0500)]
UST markers: fix structure alignment for recent gcc
GCC 4.5 (and possibly some late 4.4) choose to align structures on large
multiples, which breaks the __marker section (adding extra padding between
object sections). Increase the structure alignment to fix this issue.
Note that kernel tracepoints have recently been changed to use an array of
pointers (which are pointing to the actual tracepoint structures), thus removing
the requirement for these odd structure alignments.
But given that markers are in "maintainance mode", let's do the quick fix and
just increase the minimum alignment size.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 14 Feb 2011 16:54:45 +0000 (11:54 -0500)]
Remove trace clock warning on non x86 systems
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Fri, 11 Feb 2011 21:16:11 +0000 (16:16 -0500)]
UST-wide warning fixes
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 10 Feb 2011 21:11:02 +0000 (16:11 -0500)]
type-serializer: check is cpu id is out of bound.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 10 Feb 2011 19:29:24 +0000 (14:29 -0500)]
Fix test build issue by commenting test in makefile. to fix.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 10 Feb 2011 18:36:54 +0000 (13:36 -0500)]
UST-wide warning fixes/bugfixes
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 10 Feb 2011 18:34:48 +0000 (13:34 -0500)]
usterr: check print format even in non UST_DEBUG configs
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 10 Feb 2011 17:46:42 +0000 (12:46 -0500)]
ust_safe_snprintf should check print format
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Thu, 10 Feb 2011 15:51:41 +0000 (10:51 -0500)]
Remove PowerPC specific time reading function
The PPC version of the trace_clock_read64 was using the TB register
which is not constant accross implementations. The currently
measured time base on PPC was not accurate.
So, for now, we rely on the CLOCK_MONOTONIC.
This patch remove a bunch of #ifdef for x86 and PPC, since we now rely on
the same base clock. It also fix the build on PPC that was currently broken
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Wed, 9 Feb 2011 19:11:53 +0000 (14:11 -0500)]
Add all tests executable to gitignore
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 9 Feb 2011 19:09:11 +0000 (14:09 -0500)]
Add getcpu error validation
This check is important for the case where getcpu(2) is not implemented by the
Kernel. So, the CPU 0 is the fallback.
Reported-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 2 Feb 2011 21:59:17 +0000 (16:59 -0500)]
Merge branch 'master' of ssh://git.dorsal.polymtl.ca/home/git/ust
Mathieu Desnoyers [Wed, 2 Feb 2011 21:57:53 +0000 (16:57 -0500)]
Remove sys/timerfd.h include from test program
This include is not required, and adds a dependency on relatively recent
distributions (breaks Debian Lenny).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Nils Carlson [Fri, 28 Jan 2011 08:52:08 +0000 (09:52 +0100)]
Rename libustcmd to libustctl
This patch renames libustcmd to libustctl mostly because libustctl
sounds much better but also to clarify the connection between ustctl
and libustctl.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Acked-by: David Goulet <david.goulet@polymtl.ca>
Nils Carlson [Thu, 20 Jan 2011 11:15:54 +0000 (12:15 +0100)]
Update documentation for new ustctl cli
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Thu, 20 Jan 2011 12:34:49 +0000 (13:34 +0100)]
Update test-cases for new ustctl cli
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Fri, 7 Jan 2011 14:41:27 +0000 (15:41 +0100)]
ustctl cli rewrite
Completely re-write the ustctl cli making it behave in a similar
fashion to git. This makes more sense than using long-options
as commands.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Mathieu Desnoyers [Tue, 25 Jan 2011 17:26:51 +0000 (12:26 -0500)]
Add UST vs SystemTAP scalability test
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Nils Carlson [Fri, 14 Jan 2011 21:15:18 +0000 (22:15 +0100)]
ChangeLog and version updates for release 0.11
Nils Carlson [Fri, 14 Jan 2011 21:08:59 +0000 (22:08 +0100)]
Fix a minor ugliness
Variable was defined in middle of a block
David Goulet [Fri, 14 Jan 2011 17:14:31 +0000 (18:14 +0100)]
Fix variable declaration of the clock source v2
The ust_clock_source was static in clock.h header file.
Thus, tracectl.c was not able to modify that variable for
the trace clock read function. Bad timestamp was always
returned if CLOCK_TRACE was not available.
v2:
Comment by Mathieu Desnoyers, set clock source variable
to extern in clock.h
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Acked-by: Nils Carlson <nils.carlson@ericsson.com>
Yannick Brosseau [Fri, 14 Jan 2011 16:05:27 +0000 (17:05 +0100)]
Fix the URCU version detection for autoconf version 2.65 and older
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Acked-by: David Goulet <david.goulet@polymtl.ca>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Nils Carlson [Fri, 14 Jan 2011 08:02:16 +0000 (09:02 +0100)]
ChangeLog and version updates for ust 0.10
Mathieu Desnoyers [Tue, 11 Jan 2011 16:52:29 +0000 (11:52 -0500)]
usttrace fix variable name clash
Fix some variable name errors in the shell scripts. It does not fix my
hang, but might help.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Acked-by: Nils Carlson <nils.carlson@ericsson.com>
Julien Desfossez [Wed, 12 Jan 2011 08:36:37 +0000 (09:36 +0100)]
At runtime, UST checks if the LTTng clock source is available
If not, CLOCK_MONOTONIC is the default fallback.
This makes UST use the LTTng kernel clock source. With this
clock support, LTTng and UST traces are perfectly synchronize.
Traces from these two tracer can be merged for analysis.
LTTng 0.240 or higher is needed for this new clock source.
Signed-off-by: Julien Desfossez <julien.desfossez@polymtl.ca>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Acked-by: Nils Carlson <nils.carlson@ericsson.com>
Yannick Brosseau [Mon, 10 Jan 2011 19:20:56 +0000 (20:20 +0100)]
Add a test to valide that we use URCU with a minimum version of 0.5
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Acked-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Wed, 5 Jan 2011 12:53:43 +0000 (13:53 +0100)]
Rename libustd to libustconsumer and ustd to ust-consumerd
This is a fargoing but necessary renaming of some ust components.
The point of the renaming is to allow for a new daemon, ustd, which
will be able to keep track of tracing sessions and connect applications
with consumers. Also, the current names were non-sensical.
This patch is a step on the way towards creating a session daemon
that can connect trace producers and consumers in a nice way.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Wed, 29 Dec 2010 14:01:06 +0000 (15:01 +0100)]
Generalize some ustcomm functionality
There were multiple cases of only a single text field being sent
with ustcomm. This commit merges these into a single case.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Tue, 30 Nov 2010 13:36:30 +0000 (14:36 +0100)]
Fix freeing of channels and buffers in buffers.c v2
Changes since v1:
Handle new naming conventions
buffers.c appeared to be very convoluted full of krefs and in
general very bad shape. I have tried to make the freeing and
unmapping of shared memory symmetrical in the sense that every
open has a corresponding close and every map has a corresponding
unmap.
I have removed all use of krefs. Assuming no concurrency this
should be fine. The kref usage was anyway broken.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Nils Carlson [Fri, 3 Dec 2010 14:41:41 +0000 (15:41 +0100)]
ChangeLog and version updates for release 0.9
Nils Carlson [Tue, 30 Nov 2010 13:11:23 +0000 (14:11 +0100)]
Fix info automake and clean doc automake
Fix so that info is built using automake and also clean up the
automake process so that make clean works.
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Sat, 27 Nov 2010 19:09:32 +0000 (14:09 -0500)]
Update manpage for option -o of usttrace
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Sat, 27 Nov 2010 19:08:06 +0000 (14:08 -0500)]
Remove unuse header disable.h
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Sat, 27 Nov 2010 19:07:08 +0000 (14:07 -0500)]
Remove kref from kcompat's headers and code
It contains the exact same code of urcu_ref.h. The kref
struct and methods are replaced by those from liburcu.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Sat, 27 Nov 2010 19:05:07 +0000 (14:05 -0500)]
Remove hlist from kcompat's headers and code
The hlist structure is no longer needed since it's the exact
same implementation in liburcu.
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 26 Nov 2010 01:01:51 +0000 (20:01 -0500)]
Fix Bug#604955: ust: FTBFS
> Regarding the above subject, Your package FTBFS on ubuntu due to
> indirect linking
Fixed the test program by adding "-lpthread -lrt" to Makefile.am.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Nov 2010 04:27:24 +0000 (23:27 -0500)]
Rename for the new liburcu API namespace
This commit makes UST compatible with liburcu 0.5.2
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.042131 seconds and 4 git commands to generate.