Michael Jeanson [Wed, 14 Oct 2015 20:11:48 +0000 (16:11 -0400)] 
Port: Replace flock with fnctl
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 6 Oct 2015 21:38:35 +0000 (17:38 -0400)]
Port: make bootstrap script work on most shells
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 17 Sep 2015 16:47:00 +0000 (12:47 -0400)]
Port: removed unused clone() compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 17 Sep 2015 16:43:40 +0000 (12:43 -0400)]
Port: Add macro for socket linking on solaris
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:05:38 +0000 (16:05 -0400)]
Port: Add Solaris support to mman compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:02:45 +0000 (16:02 -0400)]
Port: Replace dirent->d_type by stat
dirent->d_type is Linux specific while 'stat' is part of POSIX
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 17 Sep 2015 14:49:53 +0000 (10:49 -0400)]
Add missing include for memset()
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 19:35:21 +0000 (15:35 -0400)]
Port: Add Solaris support to socket compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 19:11:40 +0000 (15:11 -0400)]
Port: name clash on Solaris, rename sun to s_un
'sun' is a reserved keyword on Solaris
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:55:14 +0000 (14:55 -0400)]
Port: move memset of anc_buf inside ifdef
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 19 Oct 2015 03:44:30 +0000 (23:44 -0400)] 
Port: Add Solaris fls compat
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 20:56:12 +0000 (16:56 -0400)]
Port: Add Solaris string compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:35:36 +0000 (14:35 -0400)]
Port: Use LTTNG_PATH_MAX instead of PATH_MAX
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:33:43 +0000 (14:33 -0400)]
Port: Use LTTNG_HOST_NAME_MAX instead of HOST_NAME_MAX
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:31:03 +0000 (14:31 -0400)]
Port: Use LTTNG_NAME_MAX instead of NAME_MAX
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:16:30 +0000 (14:16 -0400)]
Port: Add Solaris support to socket compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:15:10 +0000 (14:15 -0400)]
Port: Add Solaris support to poll compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 18:06:04 +0000 (14:06 -0400)]
Port: Add Solaris support to fcntl compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 17:54:38 +0000 (13:54 -0400)]
Port: Add Solaris endian.h compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 17:33:59 +0000 (13:33 -0400)]
Fix: Use 'echo' in a portable way
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 17:32:51 +0000 (13:32 -0400)]
Fix: Use result of AC_PROG_* when using sed / grep
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 17 Oct 2015 20:44:36 +0000 (16:44 -0400)]
Cleanup: Remove commented-out constant
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 17 Sep 2015 20:42:35 +0000 (16:42 -0400)] 
Fix: use start and stop sessiond from utils.sh
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 30 Sep 2015 20:48:12 +0000 (16:48 -0400)]
Fix: Remove dependency on glibc 2.12 caused by pthread_setname_np
prctl() can be used to set the same attribute set by
pthread_setname_np, but doesn't introduce a dependency on a newer
glibc. Using prctl(PR_SET_NAME) introduces a soft dependency on
Linux 2.6.9. However, the worker won't fail to launch if the call
fails as it is set out of convenience (debugger output).
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 29 Sep 2015 16:19:00 +0000 (12:19 -0400)]
Fix: Log and ignore SIGINT and SIGTERM in run_as worker
The run_as worker is in the same process group as its parent and
will receive both SIGINT and SIGTERM. However, we want to give
the worker a chance to tear itself down gracefully when its
parent closes the command socket.
The run_as worker will now ignore these signals (although it will
log them) and wait for the parent to induce the teardown.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 29 Sep 2015 16:18:49 +0000 (12:18 -0400)]
Add logging to the run_as worker
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 24 Sep 2015 18:20:42 +0000 (14:20 -0400)]
Fix: Handle EINTR of waipid in run-as worker
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 24 Sep 2015 16:34:49 +0000 (12:34 -0400)]
Fix: Handle EINTR of waitpid when spawning a session daemon
waitpid may fail for various reasons, being interrupted being
the most frequent. In such a case, status is left uninitialized
which results in the WIFSIGNALED and WIFEXITED macros returning
undefined value, resulting in surprising logging statements such
as "killed by signal 114".
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 22 Sep 2015 21:14:45 +0000 (17:14 -0400)]
Fix: tests: support systems where PAGE_SIZE is not 4096
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 22 Sep 2015 17:55:34 +0000 (13:55 -0400)]
Test: jul/log4j: use -a instead of '*' to disable all events
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 22 Sep 2015 16:12:20 +0000 (12:12 -0400)]
Reword warning on event disable
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 22 Sep 2015 15:59:44 +0000 (11:59 -0400)]
Clean-up: Remove unused test launchers
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Mon, 21 Sep 2015 22:43:57 +0000 (18:43 -0400)]
Help: add -j -l -p option to help string
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Mon, 21 Sep 2015 22:43:56 +0000 (18:43 -0400)]
man: update disable-event section
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Mon, 21 Sep 2015 22:43:55 +0000 (18:43 -0400)]
Use empty event name on disable -a for ust and agent domain
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Mon, 21 Sep 2015 22:43:54 +0000 (18:43 -0400)]
Fix: disable kernel event based on name and event type
The -a argument is interpreted as a zero-length event name
instead of '*' which is actually a valid wildcard event
name by itself. This simplifies how a disable command is
handled by the session daemon.
The event type can now be passed as argument and is a
new criteria while disabling kernel events. The default
is to disable for all event types.
UST and agent domain do not yet support disabling by event
type.
e.g:
# Only disable kernel event of type tracepoint.
lttng disable -a -k --tracepoint
# Only disable the event with name '*' and type syscall.
lttng disable -k '*' --syscall
# Disable all kernel event of all type.
lttng disable -a -k
Fixes #925
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 21 Sep 2015 22:14:02 +0000 (18:14 -0400)]
Tests: Clean-up test-crash on SIGTERM and SIGINT
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Mon, 21 Sep 2015 20:31:25 +0000 (16:31 -0400)]
Fix: Possible dereference of null pointers
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 21 Sep 2015 20:38:01 +0000 (16:38 -0400)]
Fix: Break out of loop when searching for a domain's agent
The list command never check if a domain's agent has been found
and lists the events of every agent.
This has two direct effects:
1) Memory leak of all agents' event descriptions, except the last
2) The session daemon lists the wrong agent's events
This fix check the agent's domain and breaks out of the loop once
one is found.
Fixes #906
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Mon, 21 Sep 2015 19:19:30 +0000 (15:19 -0400)]
Fix: int printed as uint
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 19:09:10 +0000 (15:09 -0400)] 
Fix: add subdir-objects to Makefile.am
Fixes the following warning introduced by the runas worker changes. Use
the same technique used in src/bin/lttng/Makefile.am.
src/common/Makefile.am:17: warning: source file 'sessiond-comm/unix.c' is in a subdirectory,
src/common/Makefile.am:17: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled. For now, the corresponding output
automake: object file(s) will be placed in the top-level directory. However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 18:10:50 +0000 (14:10 -0400)]
Fix: tests: skip UST perf tests if not root
Some distributions like Debian (e.g. Debian kernel 4.1.0-2-amd64) have
some grsecurity options enabled, such as CONFIG_GRKERNSEC_PERF_HARDEN.
Unfortunately, this option makes it impossible to use the SW page-fault
perf event as a normal user. It only leaves some HW events. However, we
can only use SW events within virtual machines.
Therefore, only run this test as root for now until we find a better
approach.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 21:03:14 +0000 (17:03 -0400)]
Fix: Check use_clone() instead of worker in run_as
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 20:16:35 +0000 (16:16 -0400)]
Fix: Perform rcu barrier before tearing down the run-as worker
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 19:50:02 +0000 (15:50 -0400)]
Fix: Handle hang-up gracefully in run-as
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 19:35:21 +0000 (15:35 -0400)]
Fix: Only log app handle release on failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 18 Sep 2015 18:46:23 +0000 (14:46 -0400)]
Fix: shm-path: handling of snprintf return value
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 18:39:13 +0000 (14:39 -0400)]
Fix: Wrong format specifier used in debug statement
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 18 Sep 2015 16:59:20 +0000 (12:59 -0400)]
Tests: Swap usages of pidof for pgrep --full
Some implementations of pidof (such as the one from procps-ng)
seem immune to changing a process' name using prctl() and
overwriting argv[0]. Using preg --full works around this
problem.
In time, we should ensure every deamon publishes a PID file
which can be reliably used by the tests.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 20:35:29 +0000 (16:35 -0400)]
Tests: indefinitely wait for shm buffers to be unlinked
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 18:12:34 +0000 (14:12 -0400)]
Fix: Hide run-as functions
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 17:49:22 +0000 (13:49 -0400)]
Fix: Hide sessiond-comm functions
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 16:48:41 +0000 (12:48 -0400)]
Cleanup: remove duplicated implementation of rculfhash
lttng-tools features a duplicated copy of Userspace RCU rculfhash due to
interaction issues between runas clone() and internal libc mutexes.
Now that the runas implementation has been changed to use fork() and a
worker process, we don't need this work-around anymore. Remove the
duplicated rculfhash to lessen the maintenance burden.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 16:48:40 +0000 (12:48 -0400)]
Fix: relayd: don't call lttng_ht_destroy in RCU read-side C.S.
It is forbidden to call lttng_ht_destroy() within a RCU read-side
critical section.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 17 Sep 2015 15:30:29 +0000 (11:30 -0400)]
Fix: libc internal mutex races with run_as
Implement a proper run_as worker process scheme to fix internal libc
mutex races. Those races lead to having the internal mutex held by
another process when clone() is called, thus hanging the clone child.
Now that we create the worker process when the parent process is
still single-threaded, we don't run into those issues. Implement a
standard fork + file descriptor passing over unnamed unix sockets rather
than the prior clone + shared file descriptor table, which was causing
issues with valgrind.
This adds a new process called "lttng-runas" for each sessiond
and consumerd process.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 17:29:29 +0000 (13:29 -0400)]
Fix: Hide readwrite symbols in common lib
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 17:29:11 +0000 (13:29 -0400)]
Fix: Hide pipe symbols in common lib
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 16:50:02 +0000 (12:50 -0400)]
Fix: Hide daemonize symbols in common lib
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 15:29:06 +0000 (11:29 -0400)]
Fix: Hide RCU hashtable wrapper symbols
RCU hashtable symbols shall not be exported in liblttng-ctl.so.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Sep 2015 01:11:43 +0000 (21:11 -0400)]
Clean-up: NULL free'd pointers in utils_partial_realpath
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Wed, 16 Sep 2015 06:58:40 +0000 (02:58 -0400)] 
Fix: prevent dangling pointer in utils_partial_realpath
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 16 Sep 2015 23:49:56 +0000 (19:49 -0400)]
Fix: rcu_read_unlock without parentheses has no side-effect
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 15 Sep 2015 14:37:48 +0000 (10:37 -0400)]
Fix: add missing test file to EXTRA_DIST
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 11 Sep 2015 14:46:06 +0000 (10:46 -0400)]
Format utils.sh messages
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 11 Sep 2015 14:46:05 +0000 (10:46 -0400)]
Tests: use functions from utils.sh
v2: remove redundant information in success message.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 10 Sep 2015 20:10:57 +0000 (16:10 -0400)]
Report error if any disable action fails
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 10 Sep 2015 20:10:56 +0000 (16:10 -0400)]
Fix: disable all ust events
Handle * event correctly.
Fixes #936
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 10 Sep 2015 20:10:55 +0000 (16:10 -0400)]
Bring back event_ust_disable_all_tracepoints
Revert part of
be42c96885c522f857f146fa6f7ae53856e3bed2
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Wed, 9 Sep 2015 21:08:20 +0000 (17:08 -0400)]
Fix: sessiond: disable: match app event by name
The use of a simple lookup and match on event name is insufficient
to identify the corresponding ust app event.
Fixes #914
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Wed, 9 Sep 2015 17:46:17 +0000 (13:46 -0400)]
lttng-crash: support symlink
Fixes #915
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Wed, 9 Sep 2015 17:46:16 +0000 (13:46 -0400)]
Test: lttng-crash and ust shm path
Fixes #916
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Sun, 13 Sep 2015 05:13:38 +0000 (01:13 -0400)]
Fix: dereferencing null index pointer
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Sun, 13 Sep 2015 04:54:04 +0000 (00:54 -0400)]
Fix: leaking memory from strdup in lttng-crash
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Sun, 13 Sep 2015 04:18:44 +0000 (00:18 -0400)]
Fix: memleak in utils_partial_realpath
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Sun, 13 Sep 2015 03:48:11 +0000 (23:48 -0400)]
Fix: double free on enable-event
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 15 Sep 2015 17:12:31 +0000 (13:12 -0400)]
Remove dead code from filter grammar test
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 15 Sep 2015 17:11:06 +0000 (13:11 -0400)]
Remove dead code from ir generation filter visitor
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 15 Sep 2015 17:08:50 +0000 (13:08 -0400)]
Remove dead code from session daemon
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 15 Sep 2015 17:06:47 +0000 (13:06 -0400)]
Remove dead code from view command
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 15 Sep 2015 17:03:18 +0000 (13:03 -0400)]
Remove dead code from disable-channel command
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 15 Sep 2015 17:00:40 +0000 (13:00 -0400)]
Remove dead code from disable-event command
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 2 Sep 2015 17:33:52 +0000 (13:33 -0400)] 
Fix: error on no/multiple domain options
Fixes: #927
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Fri, 4 Sep 2015 22:47:50 +0000 (18:47 -0400)]
Fix: lttng-crash: segfault when parsing options
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 15 Sep 2015 15:36:04 +0000 (11:36 -0400)]
Remove dead code from the calibrate command
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 15 Sep 2015 15:01:30 +0000 (11:01 -0400)]
Remove dead code from add-context command
This removes code ifdef-ed out from the add-context command. Code
shall either be used or ditched.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 9 Sep 2015 15:56:37 +0000 (11:56 -0400)]
Print relayd stream indexes
In debug output, print leaking stream index information when exiting
from relay daemon.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 9 Sep 2015 15:56:36 +0000 (11:56 -0400)]
Enhance relayd error reporting
relay_process_data has error cases that don't print any error to the
console. Add those cases, and enhance the information provided by error
output within handle_index_data().
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 9 Sep 2015 15:56:34 +0000 (11:56 -0400)]
Fix: relayd: handle consumerd crashes without leak
We can be clever about indexes partially received in cases where we
received the data socket part, but not the control socket part: since
we're currently closing the stream on behalf of the control socket, we
*know* there won't be any more control information for this socket.
Therefore, we can destroy all indexes for which we have received only
the file descriptor (from data socket). This takes care of consumerd
crashes between sending the data and control information for a packet.
Since those are sent in that order, we take care of consumerd crashes.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 9 Sep 2015 15:56:33 +0000 (11:56 -0400)]
Fix: LPOLLHUP and LPOLLERR when there is still data in pipe/socket
The event mask returned by poll/epoll is a bitwise mask made of all the
events observed. On bidirectional sockets, there are cases where
combinations of LPOLLHUP/LPOLLERR and LPOLLIN/LPOLLPRI can be raised at
the same time.
Currently the overall behavior in sessiond, consumerd and relayd is to
handle LPOLLHUP or LPOLLERR immediately, whether or not there is still
data to read in the socket. Unfortunately, this behavior may discard the
last information made available on the pipe or socket.
Audit all uses of LPOLLHUP and LPOLLERR on sockets on which we expect
data to ensure that we deal with LPOLLIN or LPOLLPRI, and catch the
hangup when read or recvmsg returns 0. Keep the LPOLLHUP and LPOLLERR
handling, but only when LPOLLIN is not raised, just in case some
unforeseen error happens when sending the reply.
This is one correct case where we can handle LPOLLHUP and LPOLLERR
directly without caring about LPOLLIN: sockets where we are expected to
write and then read the reply (e.g. command sockets). It is then OK
for a dedicated thread to watch for LPOLLHUP and LPOLLERR.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 8 Sep 2015 22:32:12 +0000 (18:32 -0400)]
Fix: double RCU unlock on event_agent_disable_all
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 7 Sep 2015 14:36:09 +0000 (10:36 -0400)]
Fix: unbalanced RCU read-side lock in enable event command
The event validation fails, an unpaired RCU unlock is performed, thus
underflowing the RCU nesting counter.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 7 Sep 2015 14:36:08 +0000 (10:36 -0400)]
Add rcu_read_ongoing() assertions around process_client_msg
process_client_msg ensures that RCU read-side lock should not be held
when calling it. Validate this using rcu_read_ongoing() at the entry and
exit points of this function. This allows us to catch unbalanced RCU
read-side lock within commands quickly.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 6 Sep 2015 23:40:42 +0000 (19:40 -0400)]
Clean-up and simplify event_agent_disable_all
event_agent_disable_all contains comments which make no sense since
they were blindly copy-pasted from event_agent_enable_all.
Also add an error_unlock label instead of open coding the unlock
on error.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 6 Sep 2015 23:40:13 +0000 (19:40 -0400)]
Document locking assumption of agent_find_event()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 2 Sep 2015 16:55:47 +0000 (12:55 -0400)]
Fix: disable agent events by name
The event_agent_disable() function only disables the first
agent event matching a given name. However, if multiple agent
events exist with different loglevels, but share the same name,
we want all of them to be disabled at once.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 2 Sep 2015 15:31:35 +0000 (11:31 -0400)]
sessiond: add loglevels_match()
UST and agent event loglevel matching algorithm is the same
so factor out this code into a common utility.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 2 Sep 2015 05:54:23 +0000 (01:54 -0400)]
Fix: include loglevel type in agent event's primary key
Refs: #913
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 2 Sep 2015 02:53:30 +0000 (22:53 -0400)]
Fix: include loglevel type in UST event's primary key
Refs: #913
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 2 Sep 2015 01:52:40 +0000 (21:52 -0400)]
sessiond: use `loglevel_value` and `loglevel_type` names
By using the `loglevel_value` and `loglevel_type` names instead
of `loglevel` for one or the other, some unsettling
inconsistencies are exposed.
This patch only changes the names to show the weird stuff, e.g.:
key.loglevel_type = loglevel_value;
A future patch will fix this.
The only `loglevel` names left untouched are those in public headers
as well as those in the tools<->UST ABI.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 4 Sep 2015 23:53:19 +0000 (19:53 -0400)]
Tests: kernel wildcards
Fixes #920
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.048606 seconds and 4 git commands to generate.
projects / lttng-tools.git / log
