Merge branch 'master' into benchmark

Fix wrong return value on consumer socket creation

A failing call to mkdir() returned 0 instead of an error and was
creating a segfault later on since some memory was not initialized.

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix benchmark and missing tracepoint

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: test for UST invalid channel parameters at channel creation

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: recvmsg should handle EINTR

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix error.h non-static variables for liblttng-ctl

Linking with liblttng-ctl made the variable opt_quiet and opt_verbose
undefined if nonexistent in the linked application.

Rename the variables adding the prefix lttng_* and declaring them in
liblttng-ctl as global variable. The user can now control the verbosity
of the library by simply setting them.

Future work will mostly add an API call to control verbosity.

(closes #151)

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix missing _GNU_SOURCE define

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: improve need root for kernel tracing error message

Reported-by: "Thibault, Daniel" <Daniel.Thibault@drdc-rddc.gc.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix start/stop lttng message error

Add the already started/stopped error message and print a more
meaningful error on the command line.

(closes #47)

Signed-off-by: David Goulet <dgoulet@efficios.com>

Merge branch 'master' of git://git.lttng.org/lttng-tools

Update version to v2.0.0-rc2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: meaningful error message

Show a meaningful error message to users attempting to do kernel tracing
without root sessiond/tracing group creds.

Reported-by: "Brosseau, Yannick" <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: UST consumer need to iterate on streams, just change their key

We need iteration to still be able to see the stream/channel, but not
lookups from sessiond query.

Ensure that teardown does not lookup by key.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing rcu read lock across RCU HT iteration

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kernel session closes fd 0 after create

This fix the make check test for kernel session handling. We ensure that
all FDs that are unset are set to -1.

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: sendmsg EPIPE should be quiet by default (expected)

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: thread_registration_apps should set its local sock to -1 when passing it

.. to another thread.

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: clock -> sock typo

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' of git://git.lttng.org/lttng-tools

Merge branch 'master' of git://git.lttng.org/lttng-tools

Fix: consumer race: should allow reuse of FD key

Issue was triggered by running "hello" UST test program in a loop while
tracing was active.

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' of git://git.lttng.org/lttng-tools

Fix: Use PERROR all across lttng-tools, never make it quiet

We never want to hide these errors, even in quiet mode. For those
"errors" that are expected and part of the normal operation (e.g. send
consumer channel: Socket operation on non-socket), we will have to
handle the return values and errno explicitly in the code.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: test all close return values in sessiond

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: All perror turned into PERROR to show file and line number

Needed to find error culprits.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: large audit of close() use in sessiond main.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: main.c client/apps sockets and kernel_trace_fd close(0)

thread_registration_apps and thread_manage_clients threads are closing
sock == 0 in error handling path, which is an error.

They also may use kernel_tracer_fd at 0 value if no kernel tracer has
been found. cleanup() can close this 0 socket too, which should never
happen.

Set all these sockets as "-1" when unset.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: incorrect close of fd 0 for syscall kernel event destroy

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: sessiond has incorrect missing 0 value in FD check

When run with daemon(), the 0 file descriptor can be re-used for
something else than stdout.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' into compat-freebsd

Fix: sessiond app listening: use posix-compliant poll flags

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: consumer printf type should match ssize_t (%zd)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: make ust consumer posix compliant for poll flags

poll flags can have both POLLHUP and POLLIN set, which is not expected
by the consumer. Do not depend on this implementation-specific behavior.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix security permission on lttng run directory

Add execute flag for other (r+x) on the lttng run directory at
/var/run/lttng so instrumented application *not* in the tracing group
can register to the global session daemon running as root.

(refs #141)

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: sessiond app listening: use posix-compliant poll flags

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: consumer printf type should match ssize_t (%zd)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: make ust consumer posix compliant for poll flags

poll flags can have both POLLHUP and POLLIN set, which is not expected
by the consumer. Do not depend on this implementation-specific behavior.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Display right loglevel_type in error message

Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix documentation in lttng.h

Some functions in lttng.h are not aimed to be used only for kernel but
also for UST. This patch changes only the references made to 'kernel' to
make the documentation generic in the comments.

(closes #126)

Signed-off-by: David Goulet <dgoulet@efficios.com>

Merge branch 'master' into benchmark

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: lttng UST and kernel consumer: fix ret vs errno mixup

- errno should be set to -ret (not the opposite!)
  The main effect is that the perror errors were meaningless.

- errno should always be compared with positive values.
  This was also causing consumerd error handling mistakes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: restart consumerd and sessiond when interrupted in poll()

When poll() is interrupted (e.g. by a debugger attaching), it should
restart instead of exiting with an error.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: lttng UST and kernel consumer: fix ret vs errno mixup

- errno should be set to -ret (not the opposite!)
  The main effect is that the perror errors were meaningless.

- errno should always be compared with positive values.
  This was also causing consumerd error handling mistakes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: restart consumerd and sessiond when interrupted in poll()

When poll() is interrupted (e.g. by a debugger attaching), it should
restart instead of exiting with an error.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Debugger support: introduce LTTNG_DEBUG_NOCLONE env. var.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' into compat-freebsd

Fix: handling bad channel when sending to consumer

If the channel object is NULL it means that it's not created on the
tracer.

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix useless variable

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix add-context returned error

Commit closes #99

Signed-off-by: David Goulet <dgoulet@efficios.com>

fix: add missing break in command handling

fix missing break in switch statement introduced in commit
2e09ba096b399ff18769cdd794c3946e54194491

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

fix: command handling: do not check domain for commands not requiring domain

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

fix: if tracing group does not exist, do not report a client error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: run_as error handling

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

FreeBSD port: lttng_clone_files should execute handler

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: add missing break in command handling

fix missing break in switch statement introduced in commit
2e09ba096b399ff18769cdd794c3946e54194491

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: command handling: do not check domain for commands not requiring domain

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: if tracing group does not exist, do not report a client error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

runas: freebsd do not redefine MAP_STACK

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

freebsd: do not use MAP_STACK

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

runas: freebsd compat for mmap flags

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: run_as error handling

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

freebsd creds: Add missing braces

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Freebsd creds: do not overwrite recv len

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement FreeBSD credential support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

tests: use LDFLAGS instead of CFLAGS for libraries

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Freebsd support: check for libc/libdl dlopen

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

bsd compat: add missing #elif -> #elif defined()

Add a missing warning too.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

bsd compat headers: #elif -> #elif defined

Also update warning messages.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

freebsd: fchmod is not supported on posix shm

It is OK not to the the fchmod. However, if UST apps start before
lttng-sessiond, they will have write access to the futex shm.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement CLONE_FILES compat layer with rfork

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix usage note on -a

This option also enable syscall tracing, just clarify it in doc.

Signed-off-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Multiple fix for FreeBSD compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix consumer to handle compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix rest of the code to support compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>

Add multiple FreeBSD compat layer

Adds clone, posix_fadvise and splice compatibility layer.

This commit ENOSYS those function for now and better implementation
will come in the future.

Signed-off-by: David Goulet <dgoulet@efficios.com>

Add FreeBSD compat layer for splice and sync_file_range

Signed-off-by: David Goulet <dgoulet@efficios.com>

Support XSI strerror_r in error.h

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add FreeBSD compat layer for socket.h

Signed-off-by: David Goulet <dgoulet@efficios.com>

Add FreeBSD compat layer for endian.h

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix FreeBSD support for rculfhash mmap

Signed-off-by: David Goulet <dgoulet@efficios.com>

Revert FreeBSD compatibility layer

Move those commits to the compat-freebsd branch instead of master branch
which is currently between release canditate and stable and this compat
layer will NOT go into 2.0-stable.

Revert "Fix rest of the code to support compat layer"
This reverts commit a440509044c2828bf6dbfb05e8d9d6d0277ce1a4.

Revert "Fix consumer to handle compat layer"
This reverts commit fbb2c21aac1386b7752f6254b2bd0bf001fa0ac1.

Revert "Multiple fix for FreeBSD compat layer"
This reverts commit bcc5eeb02fcad910c4de961b040351dad31b6f9f.

Revert "Add multiple FreeBSD compat layer"
This reverts commit d50813007e79158828e8ee6e1b5444950bc90847.

Revert "Add FreeBSD compat layer for splice and sync_file_range"
This reverts commit 826a02a292d2bd409be87ea96ba2fccbccee76b1.

Revert "Support XSI strerror_r in error.h"
This reverts commit e672cc585c3d67ee80278e29b538a3aed65df825.

Revert "Add FreeBSD compat layer for socket.h"
This reverts commit ef50a575de02a28aa158d7ba34b3d20ea329751a.

Revert "Fix FreeBSD support for rculfhash mmap"
This reverts commit e21193ea4abf7d93112b8ad3144ba11484d623c6.

Revert "Add FreeBSD compat layer for endian.h"
This reverts commit ae9d96fe577c198df432102cde69a28e82cccc1b.

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix: documented number of subbuffers is incorrect

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Document that num-subbuf and subbuf-size need to be power of 2

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' of git://git.lttng.org/lttng-tools

Fix rest of the code to support compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix consumer to handle compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>

Multiple fix for FreeBSD compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>

Add multiple FreeBSD compat layer

Adds clone, posix_fadvise and splice compatibility layer.

This commit ENOSYS those function for now and better implementation
will come in the future.

Signed-off-by: David Goulet <dgoulet@efficios.com>

Add FreeBSD compat layer for splice and sync_file_range

Signed-off-by: David Goulet <dgoulet@efficios.com>

Support XSI strerror_r in error.h

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add FreeBSD compat layer for socket.h

Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix FreeBSD support for rculfhash mmap

Signed-off-by: David Goulet <dgoulet@efficios.com>

Add FreeBSD compat layer for endian.h

Signed-off-by: David Goulet <dgoulet@efficios.com>

Update version to v2.0.0-rc1

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Standardize lttng-modules header version

refs #79

Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng-sessiond: Set group permissions explicitly

If root has a restrictive umask, e.g. 0077 when starting the session
daemon, users in kernel tracing group cannot access the global run
directory.

This patch drops unnecessary group mode bits and always sets the global
run dir permission regardless of umask.

Signed-off-by: Juha Niskanen <juniskane@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Fix lttcomm_close_unix_sock to actually close the socket

To all soul out there, shutdown(sock, SHUT_RDWR) does NOT close the
socket keeping it open after the call. I have to say for my defense that
the man page does not specify it clearly :P.

Reported-by: Irina Guilman <irina.guilman@ericsson.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Update version to v2.0-pre23

Signed-off-by: David Goulet <dgoulet@efficios.com>

modprobe timer instrumentation module

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

modprobe lttng-probe-signal

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>