Fix: add missing parenthesis in ubuntu version check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove regmap instrumentation for kernels < 4.1

Modifications to regmap.h instrumentation in mainline Linux kernel has
been no less than erratic. First, the public instrumentation header
regmap.h include a private driver header in Linux 4.0. Then, regmap.h
is moved to the private driver directory in Linux 4.1. To make things
worse, the 4.0 commit has been picked into stable branches of the Linux
kernel.

Since this does not appear to be an instrumentation of utmost
importance, only build this instrumentation probe if the private header
is found in the driver directory (need full kernel sources).

This removes regmap instrumentation for older kernels.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update kmem event for recent Ubuntu kernel

Ubuntu backported a patch into their 3.13 (Trusty) branch which
changes kmem event definition.

Upstream commit
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=99592d598eca62bdbbf62b59941c189176dfc614
first appears in 4.0 (and was later backported to 3.19.2).
We already have the proper check for this.

This corresponds to Ubuntu commit
http://kernel.ubuntu.com/git/ubuntu/ubuntu-trusty.git/commit/?id=d938e4bff1089a1f4757ed94a5cace803c6a363b
which was first released with 3.13.0-50.82.
This required adding a new check specifically for the
Ubuntu version.

Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: missing statedump end event when block device listing available

Incorrect handling of lttng_enumerate_block_devices() return value of 0
(which means "ok"), causing do_lttng_statedump() to return early.

To causes missing "lttng_statedump_end" in traces where block device
enumeration is available (CONFIG_KALLSYMS=y).

Reported-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: don't generate incorrect macros for debian/ubuntu version check

When the debian/ubuntu macros are unset, we end up generating macros
that have no right hand operand to "+", which seems to break compilation
on some compilers, even though it will always be optimized away.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Fix: build against Ubuntu kernels"

This reverts commit a748963b76f353d459a3faf85eecc96f52811eee.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: build against Ubuntu kernels

Recent Ubuntu kernels appear to define DEBIAN_API_VERSION, but they are
not really a Debian kernel per-se: the abi-debian-version.sh cannot find
the expected Debian kernel version string layout.

Therefore, change the conditional check to use directly the
LTTNG_DEBIAN_VERSION_CODE define, which is defined only when the
abi-debian-version.sh script figures out it builds against a Debian
kernel.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add namespace info in sched_fork and statedump

Modifications to sched_fork : Add a field for parent and child pid
namespace inode (as in /proc/$PID/ns/pid). Also add a field for the
child VTID.

Modifications to lttng_statedump_process_state : Add a field for the pid
namespace inode of the task.

Signed-off-by: Sebastien Lorrain <sebastien.lorrain01@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ext4 instrumentation: flags parameter did not exist prior to 3.11

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: printk instrumentation: remove "condition" tracepoints

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: regmap build against kernel 4.0 kernel headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add mmu_valid_gen field to mmutrace events

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing x86 mmutrace kernel header include

Needed to ensure the compiler checks prototypes of lttng-modules probe
against the kernel prototypes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: x86 mmutrace event extra field for kernels >= 3.11

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove execute flag from kvm.h file

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: build x86 kvm probes on kernels >= 4.1-rc1

iodev.h has moved to include/kvm/.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compilation on 4.1-rc1 kernel, remove unused WB_WORK_REASON

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: 4.1-rc1 Linux build and regmap instrumentation

regmap header has been privatized.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: don't clash with older Debian kernel versions

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update get_pfnblock_flags_mask wrapper for debian kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: discover Debian API

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update README.md to match reality: kernels >= 2.6.36 are supported

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: atomic.h wrapper for kernels < 2.6.37

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: disable x86 kvm instrumentation for kernels < 2.6.38

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing types.h include for older kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add hlist lttng wrappers

For older kernels (e.g. 2.6.38).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add struct file_handle forward declaration

For older kernels (e.g. 2.6.38).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: string length calculation reversed user vs kernel args

Only affects feature recently merged into master.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use lttng_rcu_dereference within lttng-syscalls.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add lttng rcu wrapper to allow tracing RCU

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: double-unlock of session mutex

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: check that class and instance prototype match

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: lttng-events.h check function takes void

The kernel nerver really emit this, but our function prototype should
not take the void *data parameter, so we are similar to the the "with
argument" prototype, which does not have the private data pointer.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: regmap instrumentation for Linux 3.19.4 and 4.0

This is necessary after commit c6b570d97c0e77f570bb6b2ed30d372b2b1e9aae
in the kernel.

[ Edit by Mathieu Desnoyers: fix DECLARE_EVENT_CLASS regmap_reg too. ]

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kernels >= 2.6.33 put utsrelease.h in generated/

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Include utsrelease.h in lttng-kernel-version.h

Including module.h includes other headers, which is an issue for the
get_pfnblock_flags_mask wrapper.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ext4 ext4_da_write_pages instrumentation for kernels < 3.11.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: old kernels need module.h included before vermagic.h

This is at least true for 3.2.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: net instrumentation for kernels 2.6.39 and below

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: version condition in makefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement wrapper around get_pfnblock_flags_mask

This is used by kmem instrumentation, and changed in 4.0.0. This change
has been backported to 3.19.2 stable kernel.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Be more restrictive in provider name check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: net instrumentation namespacing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compaction instrumentation namespacing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Support 4.x kernel versions in Makefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove stale TP_STRUCT_entry from kvm instrumentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing module.h include to lttng-probe-user.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use lttng hlist wrapper in wildcard and filter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: namespace asoc and kmem instrumentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update instrumentation after wildcard rebase

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: lttng_abi_syscall_list does not need to be exported

Fix rebase of wildcard feature.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Migrate ARM, powerpc, MIPS syscall instrumentation to TP_FIELDS

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove now unused syscalls.h from lttng-modules

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Filter: start with enabler "disabled"

Since we can create the enabler, then attach the filter, and then enable
it, ensure it is in a "disabled" state initially.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix coverity warning about sizeof(void **) != sizeof(void *)

The size of the copied data is actually void *, not void **.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix length type and text sequence base

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: TP_FIELDS: add missing headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Migrate syscall instrumentation to TP_FIELDS

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Migrate tracepoint instrumentation to TP_FIELDS

At this stage syscall instrumentation is disabled. Will come in a
following commit.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement filtering infrastructure

Implement filtering infrastructure in the enablers. It is not yet active
in the tracepoint probes, since we need to modify the
LTTNG_TRACEPOINT_EVENT() to follow lttng-ust more closely beforehand.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

syscall wildcards: apply syscall filtering

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement syscall wildcard support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement tracepoint wildcard support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Namespace all tracepoints

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement list.h wrapper for hlist in older kernels

The hlist API has changed between kernels 3.2 and recent (e.g. 3.19.2)
kernels. Implement a wrapper header to implement the macros missing from
older kernels that we support.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement listing of pid tracker content

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement PID tracking

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: mm_page_alloc_extfrag instrumentation for kernel 3.14.36

The following commit has been backported from kernel 3.19.2 into
3.14.36, introducing a change to mm_page_alloc_extfrag and therefore
provoking a build failure on a 3.14.36 kernel:

commit a4f3f96f850db69890f47984c60606a2362bee89
Author: Vlastimil Babka <vbabka@suse.cz>
Date:   Wed Feb 11 15:28:15 2015 -0800

    mm: when stealing freepages, also take pages created by splitting buddy page

    commit 99592d598eca62bdbbf62b59941c189176dfc614 upstream.

This patch adds the proper version check to allow building on 3.14.y.

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update writeback instrumentation for kernel 4.0+

Introduced by Linux kernel commit:

commit 0ae45f63d4ef8d8eeec49c7d8b44a1775fff13e8
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Mon Feb 2 00:37:00 2015 -0500

    vfs: add support for a lazytime mount option

And:

commit de1414a654e66b81b5348dbc5259ecf2fb61655e
Author: Christoph Hellwig <hch@lst.de>
Date:   Wed Jan 14 10:42:36 2015 +0100

    fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compaction mm_compaction_isolate_template update for Linux 4.0+

Updated by Linux commit:

commit b7aba6984dc048503b69c2a885098cdd430832bf
Author: Mel Gorman <mel@csn.ul.ie>
Date:   Thu Jan 13 15:45:54 2011 -0800

    mm: compaction: add trace events for memory compaction activity

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kmem instrumentation update for mm_page_alloc_extfrag kernel 3.19.2+

This commit introduces an API change for mm_page_alloc_extfrag
instrumentation:

commit cdf476685b5c9dcd20f0305791bd60212cace25d
Author: Vlastimil Babka <vbabka@suse.cz>
Date:   Wed Feb 11 15:28:15 2015 -0800

    mm: when stealing freepages, also take pages created by splitting buddy page

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kmem instrumentation: mm_page_alloc extfrag change_ownership field

Linux kernel 3.12.30 and onward changes the parameter received by this
callback. It's the same type, but the meaning differs. This is why it
did compile fine, but the data gathered did not really represent
change_ownership.

This change has been introduced in the Linux kernel by this commit:

commit 52c8f6a5aeb0bdd396849ecaa72d96f8175528f5
Author: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Date:   Tue Nov 12 15:08:19 2013 -0800

    mm: get rid of unnecessary overhead of trace_mm_page_alloc_extfrag()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: missing parenthesis in offset_align_floor

Is currently unused. Triggers a compile error when used.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: implement time.h wrapper for FD_ISSET

Kernels v3.4.0 to v3.4.7 still define FD_ISSET, but __FD_ISSET has been
removed. Therefore, we cannot use the FD_ISSET define to find out of we
need to use the new close_on_exec(). Implement a wrapper based on kernel
version detection instead.

Fixes #872

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update sched instrumentation for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update rcu instrumentation for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update scsi instrumentation for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update module instrumentation for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Add f_dentry wrapper for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: introduce lttng_get_unused_fd() wrapper for 3.19 kernels

get_unused_fd disappears in 3.19 kernel, where get_unused_fd_flags(0)
should be used instead.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: lttng_this_cpu_ptr wrapper for kernel 3.19+

Starting from kernel 3.19-rc1, __get_cpu_var() disappears, replaced by
this_cpu_ptr(). Introduce a wrapper using either depending on the kernel
version. Older kernels did not expose a this_cpu_ptr(), so keep on using
__get_cpu_var() on old kernels.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update btrfs instrumentation for 3.18 Linux kernel

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix compile error on kernel 3.0.101 with CONFIG_PERF_EVENTS

The context parameter of perf_event_create_kernel_counter() was introduced
with kernel 3.1.

Signed-off-by: David Engraf <david.engraf@sysgo.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Conditional compilation introduced by lttng-modules commit

  0007344741ef65259bc52dea72259173dfbf96c0

needs to be applied for kernels 3.12.30 and up in the 3.12.x branch.

Signed-off-by: David Engraf <david.engraf@sysgo.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compaction instrumentation update for 3.14.x stable kernels

Conditional compilation introduced by lttng-modules commit

  0007344741ef65259bc52dea72259173dfbf96c0

needs to be applied to kernels 3.14.25 and up in the 3.14.x branch.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Reported-by: Bjørn Forsman <bjorn.forsman@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: context alignment not properly handled

This issue affects only architectures without efficient unaligned
accesses, only when a context field with larger alignment follows a
context field with smaller alignment. It generates unreadable traces
when such context fields are enabled in this configuration.

Fixes #858

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix compilation on Linux kernel >= 3.18.0

Since kernel commit 8a9522d2fe compilation fails as kvm_age_page
tracepoint had its signature changed, so update it accordingly.

Tested pointing to kernels:
    git reset --hard v3.17; make init/version.o
    git reset --hard v3.18-rc1; make init/version.o

Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: build for architectures without HAVE_SYSCALL_TRACEPOINTS

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 2.6.0-rc1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Expose lttng-modules ABI version ioctl

Check compatibility between lttng-modules and tools using a version
numbering specifically for the ABI, rather than relying on the major
version of lttng-modules per se. This takes into account that we
sometimes depend on lock-step updates of the toolchain, including tools
and modules.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: syscall list ioctl number conflict

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng-modules: fix build for non-x86

Since commit 644d6e9c2807041db2b4fd9c3350d4fa243060b1 "Remove sys_
prefix from syscall names" the build has been broken for non-x86
architectures.

Remove the sys_ prefix from syscall names and related macros as has
already been done for x86.

Correct "OVVERRIDE" typo in arm and powerpc headers while we're at it.

Successfully built against v3.17 for 32- and 64-bit mips and powerpc;
runtime tested on arm, verifying that mmap2, execve, and clone syscall
events are captured.

Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: syscall listing of session

Fixes syscall listing of sessions when no syscall has been enabled.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Print build warning when writeback probe is disabled

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add atomic.h wrapper for before/after atomic

Linux 3.16 changes the name of before/after atomic functions, and
generates a warning at build time about deprecation of old ones. Create
a wrapper header to handle this.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix compilation on Ubuntu 14.10

Extend the range introduced in 2260bfd to also include Ubuntu's
3.16 kernel. The API-changing patch was also backported to that series.
This will also be required for Trusty users once the the Utopic
hardware-enablement stack, including that 3.16 kernel, comes in.

Refs #838. See comment #2 for the patch in question.

Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: export name as text array in writeback

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove unused trace_clock_read32()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use 3.17 ktime_get_mono_fast_ns() new API

The new ktime_get_mono_fast_ns() API introduced in kernel 3.17 allows
tracing NMI handlers.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Thomas Gleixner <tglx@linutronix.de>

Check for stale version.h files

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>