Fix: version checks for kernel 4.0

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Incorrect Ubuntu kernel patchlevel

The kernel version used should be the one in Makefile and generated
version.h, not the one tweaked by Ubuntu as "0" in the built package.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update kmem event for Ubuntu's 3.16 kernel

The upstream patch in question in commit 72906e1 was cherry-picked into
Ubuntu's 3.16 kernel backport branch (called lts-utopic). The version
check should also include this branch.

The other backport branch, lts-vivid, and all following ones will be
covered by the standard

  LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,2)

check, so should not require other workarounds.

References #889.

Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: RHEL 7.1 block instrumentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add RHEL version macros

RHEL 7.1 has backported upstream patches that change the kvm.h
tracepoint prototype. Add version check specific to RHEL to handle this
case.

RHEL 7.x has the required fixes backported that allow removing the 3.10
blacklist check for them, so take this into account.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing parenthesis in ubuntu version check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove regmap instrumentation for kernels < 4.1

Modifications to regmap.h instrumentation in mainline Linux kernel has
been no less than erratic. First, the public instrumentation header
regmap.h include a private driver header in Linux 4.0. Then, regmap.h
is moved to the private driver directory in Linux 4.1. To make things
worse, the 4.0 commit has been picked into stable branches of the Linux
kernel.

Since this does not appear to be an instrumentation of utmost
importance, only build this instrumentation probe if the private header
is found in the driver directory (need full kernel sources).

This removes regmap instrumentation for older kernels.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update kmem event for recent Ubuntu kernel

Ubuntu backported a patch into their 3.13 (Trusty) branch which
changes kmem event definition.

Upstream commit
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=99592d598eca62bdbbf62b59941c189176dfc614
first appears in 4.0 (and was later backported to 3.19.2).
We already have the proper check for this.

This corresponds to Ubuntu commit
http://kernel.ubuntu.com/git/ubuntu/ubuntu-trusty.git/commit/?id=d938e4bff1089a1f4757ed94a5cace803c6a363b
which was first released with 3.13.0-50.82.
This required adding a new check specifically for the
Ubuntu version.

Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: missing statedump end event when block device listing available

Incorrect handling of lttng_enumerate_block_devices() return value of 0
(which means "ok"), causing do_lttng_statedump() to return early.

To causes missing "lttng_statedump_end" in traces where block device
enumeration is available (CONFIG_KALLSYMS=y).

Reported-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: don't generate incorrect macros for debian/ubuntu version check

When the debian/ubuntu macros are unset, we end up generating macros
that have no right hand operand to "+", which seems to break compilation
on some compilers, even though it will always be optimized away.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Fix: build against Ubuntu kernels"

This reverts commit a748963b76f353d459a3faf85eecc96f52811eee.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: build against Ubuntu kernels

Recent Ubuntu kernels appear to define DEBIAN_API_VERSION, but they are
not really a Debian kernel per-se: the abi-debian-version.sh cannot find
the expected Debian kernel version string layout.

Therefore, change the conditional check to use directly the
LTTNG_DEBIAN_VERSION_CODE define, which is defined only when the
abi-debian-version.sh script figures out it builds against a Debian
kernel.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 2.6.1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: regmap build against kernel 4.0 kernel headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: mmutrace warnings about redefined macros

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing x86 mmutrace kernel header include

Needed to ensure the compiler checks prototypes of lttng-modules probe
against the kernel prototypes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: x86 mmutrace event extra field for kernels >= 3.11

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove execute flag from kvm.h file

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: build x86 kvm probes on kernels >= 4.1-rc1

iodev.h has moved to include/kvm/.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compilation warnings on 4.1-rc1 kernel

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compilation on 4.1-rc1 kernel, remove unused WB_WORK_REASON

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: 4.1-rc1 Linux build and regmap instrumentation

regmap header has been privatized.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: don't clash with older Debian kernel versions

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update get_pfnblock_flags_mask wrapper for debian kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: discover Debian API

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update README.md to match reality: kernels >= 2.6.36 are supported

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add struct file_handle forward declaration

For older kernels (e.g. 2.6.38).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: atomic.h wrapper for kernels < 2.6.37

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: disable x86 kvm instrumentation for kernels < 2.6.38

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: check that class and instance prototype match

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: lttng-events.h check function takes void

The kernel nerver really emit this, but our function prototype should
not take the void *data parameter, so we are similar to the the "with
argument" prototype, which does not have the private data pointer.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update regmap instrumentation for Linux 3.19.4 and 4.0

This is necessary after commit c6b570d97c0e77f570bb6b2ed30d372b2b1e9aae
in the kernel.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kernels >= 2.6.33 put utsrelease.h in generated/

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Include utsrelease.h in lttng-kernel-version.h

Including module.h includes other headers, which is an issue for the
get_pfnblock_flags_mask wrapper.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: old kernels need module.h included before vermagic.h

This is at least true for 3.2.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: version condition in makefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement wrapper around get_pfnblock_flags_mask

This is used by kmem instrumentation, and changed in 4.0.0. This change
has been backported to 3.19.2 stable kernel.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Support 4.x kernel versions in Makefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: mm_page_alloc_extfrag instrumentation for kernel 3.14.36

The following commit has been backported from kernel 3.19.2 into
3.14.36, introducing a change to mm_page_alloc_extfrag and therefore
provoking a build failure on a 3.14.36 kernel:

commit a4f3f96f850db69890f47984c60606a2362bee89
Author: Vlastimil Babka <vbabka@suse.cz>
Date:   Wed Feb 11 15:28:15 2015 -0800

    mm: when stealing freepages, also take pages created by splitting buddy page

    commit 99592d598eca62bdbbf62b59941c189176dfc614 upstream.

This patch adds the proper version check to allow building on 3.14.y.

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update writeback instrumentation for kernel 4.0+

Introduced by Linux kernel commit:

commit 0ae45f63d4ef8d8eeec49c7d8b44a1775fff13e8
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Mon Feb 2 00:37:00 2015 -0500

    vfs: add support for a lazytime mount option

And:

commit de1414a654e66b81b5348dbc5259ecf2fb61655e
Author: Christoph Hellwig <hch@lst.de>
Date:   Wed Jan 14 10:42:36 2015 +0100

    fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compaction mm_compaction_isolate_template update for Linux 4.0+

Updated by Linux commit:

commit b7aba6984dc048503b69c2a885098cdd430832bf
Author: Mel Gorman <mel@csn.ul.ie>
Date:   Thu Jan 13 15:45:54 2011 -0800

    mm: compaction: add trace events for memory compaction activity

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kmem instrumentation update for mm_page_alloc_extfrag kernel 3.19.2+

This commit introduces an API change for mm_page_alloc_extfrag
instrumentation:

commit cdf476685b5c9dcd20f0305791bd60212cace25d
Author: Vlastimil Babka <vbabka@suse.cz>
Date:   Wed Feb 11 15:28:15 2015 -0800

    mm: when stealing freepages, also take pages created by splitting buddy page

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kmem instrumentation: mm_page_alloc extfrag change_ownership field

Linux kernel 3.12.30 and onward changes the parameter received by this
callback. It's the same type, but the meaning differs. This is why it
did compile fine, but the data gathered did not really represent
change_ownership.

This change has been introduced in the Linux kernel by this commit:

commit 52c8f6a5aeb0bdd396849ecaa72d96f8175528f5
Author: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Date:   Tue Nov 12 15:08:19 2013 -0800

    mm: get rid of unnecessary overhead of trace_mm_page_alloc_extfrag()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 2.6.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: missing parenthesis in offset_align_floor

Is currently unused. Triggers a compile error when used.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: implement time.h wrapper for FD_ISSET

Kernels v3.4.0 to v3.4.7 still define FD_ISSET, but __FD_ISSET has been
removed. Therefore, we cannot use the FD_ISSET define to find out of we
need to use the new close_on_exec(). Implement a wrapper based on kernel
version detection instead.

Fixes #872

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update sched instrumentation for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update rcu instrumentation for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update scsi instrumentation for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update module instrumentation for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Add f_dentry wrapper for 3.19+ kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: introduce lttng_get_unused_fd() wrapper for 3.19 kernels

get_unused_fd disappears in 3.19 kernel, where get_unused_fd_flags(0)
should be used instead.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: lttng_this_cpu_ptr wrapper for kernel 3.19+

Starting from kernel 3.19-rc1, __get_cpu_var() disappears, replaced by
this_cpu_ptr(). Introduce a wrapper using either depending on the kernel
version. Older kernels did not expose a this_cpu_ptr(), so keep on using
__get_cpu_var() on old kernels.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update btrfs instrumentation for 3.18 Linux kernel

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix compile error on kernel 3.0.101 with CONFIG_PERF_EVENTS

The context parameter of perf_event_create_kernel_counter() was introduced
with kernel 3.1.

Signed-off-by: David Engraf <david.engraf@sysgo.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Conditional compilation introduced by lttng-modules commit

  0007344741ef65259bc52dea72259173dfbf96c0

needs to be applied for kernels 3.12.30 and up in the 3.12.x branch.

Signed-off-by: David Engraf <david.engraf@sysgo.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 2.6.0-rc2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compaction instrumentation update for 3.14.x stable kernels

Conditional compilation introduced by lttng-modules commit

  0007344741ef65259bc52dea72259173dfbf96c0

needs to be applied to kernels 3.14.25 and up in the 3.14.x branch.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Reported-by: Bjørn Forsman <bjorn.forsman@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: context alignment not properly handled

This issue affects only architectures without efficient unaligned
accesses, only when a context field with larger alignment follows a
context field with smaller alignment. It generates unreadable traces
when such context fields are enabled in this configuration.

Fixes #858

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix compilation on Linux kernel >= 3.18.0

Since kernel commit 8a9522d2fe compilation fails as kvm_age_page
tracepoint had its signature changed, so update it accordingly.

Tested pointing to kernels:
    git reset --hard v3.17; make init/version.o
    git reset --hard v3.18-rc1; make init/version.o

Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: build for architectures without HAVE_SYSCALL_TRACEPOINTS

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 2.6.0-rc1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Expose lttng-modules ABI version ioctl

Check compatibility between lttng-modules and tools using a version
numbering specifically for the ABI, rather than relying on the major
version of lttng-modules per se. This takes into account that we
sometimes depend on lock-step updates of the toolchain, including tools
and modules.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: syscall list ioctl number conflict

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng-modules: fix build for non-x86

Since commit 644d6e9c2807041db2b4fd9c3350d4fa243060b1 "Remove sys_
prefix from syscall names" the build has been broken for non-x86
architectures.

Remove the sys_ prefix from syscall names and related macros as has
already been done for x86.

Correct "OVVERRIDE" typo in arm and powerpc headers while we're at it.

Successfully built against v3.17 for 32- and 64-bit mips and powerpc;
runtime tested on arm, verifying that mmap2, execve, and clone syscall
events are captured.

Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: syscall listing of session

Fixes syscall listing of sessions when no syscall has been enabled.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Print build warning when writeback probe is disabled

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add atomic.h wrapper for before/after atomic

Linux 3.16 changes the name of before/after atomic functions, and
generates a warning at build time about deprecation of old ones. Create
a wrapper header to handle this.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix compilation on Ubuntu 14.10

Extend the range introduced in 2260bfd to also include Ubuntu's
3.16 kernel. The API-changing patch was also backported to that series.
This will also be required for Trusty users once the the Utopic
hardware-enablement stack, including that 3.16 kernel, comes in.

Refs #838. See comment #2 for the patch in question.

Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: export name as text array in writeback

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove unused trace_clock_read32()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use 3.17 ktime_get_mono_fast_ns() new API

The new ktime_get_mono_fast_ns() API introduced in kernel 3.17 allows
tracing NMI handlers.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Thomas Gleixner <tglx@linutronix.de>

Check for stale version.h files

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compile lttng_statedump_process_ns on Ubuntu

Fixes: #838
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Reverse version check logic in lttng_statedump_process_ns

This allows to keep the most up-to-date branch on top.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix block_rq_complete TP on Ubuntu kernel

Fixes: #814
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Introduce macros to check Ubuntu kernel version

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Sync writeback tracepoints from mainline

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: redefinition of DEFINE_WRITEBACK_EVENT

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: hander negative get_syscall_nr return value

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: statedump: close_on_exec flag backward compat

Older kernels (e.g. 3.2.62) use FD_ISSET() to test close_on_exec flag.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix instrumentation of vmscan for older kernels

Missing definition of LTTNG_TRACEPOINT_EVENT_CONDITION_MAP and
LTTNG_TRACEPOINT_EVENT_INSTANCE_CONDITION_MAP, only used for rather old
kernels (e.g. 3.2.62).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: older kernels (3.2.x) don't undefine TRACE_SYSTEM

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: syscall listing: handle "enable all syscall"

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: don't allow disabling syscalls when none are enabled

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: syscall: fail disable all if all already disabled

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: syscall filtering: NULL pointer deref

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: list syscall without syscall_entry prefix

Also full transition from syscall_enter to syscall_entry.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: syscall_list_show NULL pointer deref

Also make sure the syscall listing index matches the bitmask.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

implement syscall mask getter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: lttng-abi.h coding style

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

syscall listing: show syscall ID

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Allow events with same name to be enabled for each channel

Before, we refused to enable an event with the same name in two
different channels at the same time within a session.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ABI: use enable a syscall ABI field name

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement syscall listing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: tracepoint list anonymous file name

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: syscall filtering: disable all syscalls

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

syscall tracing: input/output parameter handling for all arch

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng-get-syscall-inout.sh depends on bash

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix generate syscall header script: add missing escape char

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>