Fix BUG_ON handling

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup tracepoint.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Increase tracepoint provider:name len limit to 255, add compile-time warning

The compiler will now complain with a warning if a tracepoint
provider:name exceeds the 255 char limit (+ \0).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use iterator on tracepoint probes instead of tracepoints per se

- Simplify iteration locking scheme by using a linked list to store all
  the tracepoints to be iterated on.
- Allow getting the loglevel in addition to the tracepoint name.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup the JNI interface options in configure.ac

Fix typos, use macros and skip a redundant check.

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add check for 'texinfo' to configure.ac

Fix for http://lttng.org/issue/252

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update .gitignore

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unused import for java tracing wrapper

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing .class in ust java makefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update tracepoint used within lttng ust java

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng_ust_java: add missing .h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update lttng-ust java provider following API change

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add TRACEPOINT_DEFINE to ust java lib

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Describe autotools/libtool/automake version dependency

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove m4_ifdef for AC_PROG_LIBTOOL (deprecated)

This trick does not seem to work anyway.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use unsigned int instead of int for bitfields

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Change API to support exporting loglevel in event listing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove loglevel iter (will be performed by tracepoint iteration)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint loglevel: setup all loglevel information at build time

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust-ctl API: ustctl_release_object() should return an error instead of assert

Communication error can cause this function to fail, so an assert is
definitely not the right approach. Return error to caller.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Divert installation of test plugins into /tmp/

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Support older autotools

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unneeded null pointer check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix demo program link dependencies

Only demo can afford not to link with liblttng-ust, not the providers.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ltt_event_create should return error values

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Apply autoupdate to configure.ac

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

demo program: only depend on libdl

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint c++ support: cast void * to function pointer

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Introduce c++ test

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add new demo files

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Allow weak binding from instrumented apps to liblttng-ust

This introduce the TRACEPOINT_DEFINE macro. See demo program for usage
example. This is an API change for instrumentation.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update tracepoint comments

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename TP_LOGLEVEL to tp_loglevel

Within the loglevel enumeration, the entries are not separated by a
comma. To match the style used for TP_FIELDS() ctf_*() entries, use
lower-case, which denotes that these entries must not be separated by
commas.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement tracepoint loglevel macros

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Handle sessiond application refusal with delayed retry

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix 32-bit compile type size warning

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Send bitness upon registration

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

USt test: fix 32-bit type warning

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix 32-bit type warning

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing patient_write.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ustctl: do not free object on release_object

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Do not install share.h (cleanup)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Do not install usterr-signal-safe

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove core.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Extend align.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement error.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unused ARRAY_SIZE macro

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement __rb_same_type

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement lttng_ust_get_cpu()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove debug output

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust-tracepoint-event: fix probe creation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Compile fix following moved headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement ust-tracepoint-events under MIT license

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement tracepoint event reset header

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix tracepoint event related build errors

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Basic tracepoint event implementation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement jhash from public domain source, apply LGPL license

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

More compile fixes

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix lib ring buffer compile errors

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix configure

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing extern to tracepoint.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Installed headers relicensing and cleanup

- Move all locally-used code outside of include/lttng.
- All headers included in applications for tracing are relicensed
  to MIT license, except for lttng/core.h and
  lttng/usterr-signal-safe.h, which both purposefully only contain
  trivial declarations are static inline functions/macros of 10 lines or
  less. They are therefore OK to include into non-GPL applications
  without being considered as derivative work under the terms of the
  LGPLv2.1 license.
- Update version number support.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

clock.h: ensure all functions are trivial (10 lines or less)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove old marker header files

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

usterr-signal-safe.h: ensure all macros are trivial (10 lines max)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement tracepoint-internal.h as LGPLv2.1 (not exported)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Relicense tests probe headers/tp.c files to MIT-style license

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove all LGPL-licensed headers

Remove all headers licensed under LGPLv2.1 for upcoming reimplementation
under the BSD-style MIT license.

Even though technically most of the content of these headers fall under
the exceptions of the LGPL:

"When a "work that uses the Library" uses material from a header file
that is part of the Library, the object code for the work may be a
derivative work of the Library even though the source code is not.
Whether this is true is especially significant if the work can be
linked without the Library, or if the work is itself a library.  The
threshold for this to be true is not precisely defined by law.

  If such an object file uses only numerical parameters, data
structure layouts and accessors, and small macros and small inline
functions (ten lines or less in length), then the use of the object
file is unrestricted, regardless of whether it is legally a derivative
work.  (Executables containing this object code plus portions of the
Library will still fall under Section 6.)"

Our intent is to make sure applications can include these headers
without having to be considered derived code.

Therefore, the license of align.h, bug.h, ringbuffer-abi.h and
ringbuffer-config.h, ust-abi.h, ust-events.h, vatomic.h are changed to
MIT license (I, Mathieu Desnoyers, am the sole author of these files and
agree to these changes).

I am removing tracepoint-event.h, tracepoint-internal.h,
tracepoint-types.h, tracepoint.h, ust-tracepoint-event-reset.h and
ust-tracepoint-event.h because those might be considered derived work
from Ftrace.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint: evaluate arguments within test block

> On Thu, 2011-11-17 at 04:55 +0100, Eric Dumazet wrote:
> > The general admitted claim of a tracepoint being on x86 a single
> > instruction :
> >
> > jmp +0
> >
> > Is not always true.
> >
> > For example in mm/slub.c, kmem_cache_alloc()
> >
> > void *ret = slab_alloc(s, gfpflags, NUMA_NO_NODE, _RET_IP_);
> > trace_kmem_cache_alloc(_RET_IP_, ret, s->objsize, s->size, gfpflags);
> > return ret;
> >
> > We can check compiler output and see that 4 extra instructions were
> > added because s->objsize & s->size are evaluated.
> >
> > I noticed this in a perf session, because these 4 extra instructions
> > added some noticeable latency/cost.
> >
> > c10e26a4:       8b 5d d8                mov    -0x28(%ebp),%ebx
> > c10e26a7:       85 db                   test   %ebx,%ebx
> > c10e26a9:       75 6d                   jne    c10e2718   (doing the memset())
> > c10e26ab:       8b 76 0c                mov    0xc(%esi),%esi   // extra 1
> > c10e26ae:       8b 5d 04                mov    0x4(%ebp),%ebx   // extra 2
> > c10e26b1:       89 75 f0                mov    %esi,-0x10(%ebp) // extra 3
> > c10e26b4:       89 5d ec                mov    %ebx,-0x14(%ebp) // extra 4
> > c10e26b7:       e9 00 00 00 00          jmp    c10e26bc
> > c10e26bc:       8b 45 d8                mov    -0x28(%ebp),%eax
> > c10e26bf:       83 c4 28                add    $0x28,%esp
> > c10e26c2:       5b                      pop    %ebx
> > c10e26c3:       5e                      pop    %esi
> > c10e26c4:       5f                      pop    %edi
> > c10e26c5:       c9                      leave
> >
> >
> > A fix would be to not declare an inline function but a macro...
> >
> > #define trace_kmem_cache_alloc(...) \
> >     if (static_branch(&__tracepoint_kmem_cache_alloc.key)) \
> >             __DO_TRACE(&__tracepoint_kmem_cache_alloc,      \
> >                     ...
> >
> > Anyone has some clever idea how to make this possible ?

Do this by moving the test into the tracepoint() macro.

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove console output that should be turned into debug

But no debug log facility for this library which is included in
sessiond (yet).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Document LGPL TRACEPOINT_CREATE_PROBES restrictions

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

tracepoint: support TP_ARGS(void)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix multiple probe generation into one single C file

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove run from makefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add demo program

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Allow release object to have -1 sock param

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

initiate lttng-ust-comm printout cleanup

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix fork handling, where child shares shm with parent

Consider that consumer does most of the finalize/flush, so we don't need
to perform them in teardown.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unused libringbuffer/ring_buffer_abi.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update comment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint API change: combine TP_PROTO and TP_VARS into TP_ARGS, remove _NOARGS macros

New API for tracepoints, combining the TP_PROTO and TP_VARS arguments
into a single "TP_ARGS" macro. It takes up to 10 parameters (from 0 to
10). The "_NOARGS" special-case is not needed anymore: it can be
achieved simply by passing an empty TP_ARGS:

  TP_ARGS(),

to the standard tracepoint event declarations.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoints: add provider mismatch check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint API change: rename TRACEPOINT_SYSTEM to TRACEPOINT_PROVIDER

Eliminates the confusion between the first TRACEPOINT_EVENT "provider"
argument and the "TRACEPOINT_SYSTEM", which need to be the same thing.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' of git.lttng.org:/home/git/lttng-ust

tracepoint API change: rename TP_ARGS to TP_VARS

In preparation of folding of both TP_PROTO and TP_ARGS into TP_ARGS.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng-ust-comm: relicense to LGPLv2.1

This internal communication library is used by both lttng-sessiond and
lttng-ust. lttng-ust is LGPLv2.1, so we need to make this library
LGPLv2.1 to ensure licensing is respected.

However, we now keep this library internal to liblttng-ust and
liblttng-ust-ctl. It is not installed into the system anymore. Only the
lttng-sessiond (or another GPLv2-compatible session daemon) is meant to
control liblttng-ust through the GPLv2 liblttng-ust-ctl control library.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Julien Desfossez <julien.desfossez@polymtl.ca>

Do not install liblttng-ust-comm and ust-comm.h

Only used internally by liblttng-ust-ctl and liblttng-ust.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix metadata tp listing filtering

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Don't list metadata tracepoint

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add delay parameter to hello test program

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Define ltt_transport_list as static

Fix uninitialized state at constructor execution.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Clean unused vars. warnings

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing core.c file

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement ustctl_tracepoint_list/list_get

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement LTTNG_UST_TRACEPOINT_LIST

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update char limit comment in tracepoint

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move libringbuffer and comm connect messages to debug level

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint API change: add provider field

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

init private data

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move struct ltt_channel to shm for consumer flush

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>