Jérémie Galarneau [Sun, 30 Aug 2015 21:38:25 +0000 (17:38 -0400)] 
Use type directly in sizeof instead of a dereferenced pointer
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 30 Aug 2015 21:37:41 +0000 (17:37 -0400)]
Prevent the addition of UST events to agent channels
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 28 Aug 2015 18:53:26 +0000 (14:53 -0400)]
Don't save log level in session configuration when unneeded
Saving the log level of events in session configurations when "ALL" log
levels are enabled may confuse both users and programs working with
session configurations.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Aug 2015 21:30:37 +0000 (17:30 -0400)]
Remove unneeded RCU lock
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Aug 2015 21:30:21 +0000 (17:30 -0400)]
Remove unneeded RCU lock
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Aug 2015 21:26:58 +0000 (17:26 -0400)]
Fix: Propagate filter status of kernel events to client
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Aug 2015 20:53:24 +0000 (16:53 -0400)]
Fix: Save kernel event filter when saving session configuration
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Aug 2015 16:55:04 +0000 (12:55 -0400)]
Docs: there is no need to SHOUT in comments
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Aug 2015 15:52:34 +0000 (11:52 -0400)]
Fix: Mention Python as part of enable-event's usage()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:05:03 +0000 (12:05 -0400)]
Grammar fix in comment
give -> given
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:04:12 +0000 (12:04 -0400)]
Fix: typo in error message
writting -> writing
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:03:38 +0000 (12:03 -0400)]
Add agent domains to lttng enable-event usage()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:02:50 +0000 (12:02 -0400)]
Docs: Add documentation explaining the meaning of "internal" events
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:00:30 +0000 (12:00 -0400)]
Report memory allocation failure when copying filter bytecode
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:00:05 +0000 (12:00 -0400)]
Fix: cmd_enable_event must return positive error codes
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 15:58:56 +0000 (11:58 -0400)]
Ensure that a filter is always passed with its filter expression
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 15:37:48 +0000 (11:37 -0400)]
Save filter expressions as part of agent events
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 15:31:45 +0000 (11:31 -0400)]
Add agent domains to the enable-event section of LTTNG(1)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 24 Aug 2015 23:24:37 +0000 (19:24 -0400)]
Use lttng_domain_type enumeration instead of bare integers
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 24 Aug 2015 16:24:18 +0000 (12:24 -0400)]
Prevent disable event on internal UST events
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 24 Aug 2015 16:17:46 +0000 (12:17 -0400)]
Remove unneeded RCU read lock
lttng_ht_get_count() now takes the RCU read lock automatically.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 24 Aug 2015 16:17:01 +0000 (12:17 -0400)]
Skip internal events when saving a session configuration
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 04:28:57 +0000 (00:28 -0400)]
Clean-up: Coding-style conformance adjustments
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 04:28:24 +0000 (00:28 -0400)]
Docs: Clarify ominous comment wording
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 03:43:21 +0000 (23:43 -0400)]
Hide internal events from session daemon clients
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 04:27:34 +0000 (00:27 -0400)]
Prevent the use of reserved UST event names
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 04:26:28 +0000 (00:26 -0400)]
Tag events created as side-effect of agent events as internal
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 03:35:22 +0000 (23:35 -0400)]
Remove unneeded RCU lock
lttng_ht_get_count() already holds the RCU read lock.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 03:24:17 +0000 (23:24 -0400)]
Remove dead code in lttng-sessiond
event_ust_enable_all_tracepoints and event_ust_disable_all_tracepoints
are both never used by the session daemon.
Jérémie Galarneau [Sun, 23 Aug 2015 04:22:45 +0000 (00:22 -0400)]
Ensure event names are NULL terminated during validation
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 19 Aug 2015 18:17:40 +0000 (14:17 -0400)] 
Fix: assert(0) when listing Python events with MI
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Fri, 21 Aug 2015 15:44:28 +0000 (11:44 -0400)]
Fix: set GLOBAL buffer type for kernel domain in list
MI is using the list command reponse's buffer type, even when listing
the kernel domain. Not setting .buf_type here results in MI reporting a
wrong buffer type for the kernel domain.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 6 Aug 2015 22:02:21 +0000 (18:02 -0400)] 
Fix: take RCU read-side lock within hash table functions
After review, a great deal of caller sites miss the RCU read-side lock
when using the hash table modification functions. This is a case where
having a slight performance degradation might be worthwhile if we can be
a bit more stability. So instead of playing whack-a-mole, add the RCU
read-side lock in the hash table modification functions to ensure
protection from ABA.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 13 Aug 2015 21:45:40 +0000 (17:45 -0400)]
Tests: Adapt MI test to change in track/untrack behaviour
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 13 Aug 2015 19:38:24 +0000 (15:38 -0400)]
Clean-up: Rename lib_func to cmd_func
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 12 Aug 2015 20:08:16 +0000 (16:08 -0400)] 
Fix: Improve the error reporting of the track/untrack command
This patch adds feedback when a track/untrack command is successful and
specific messages on errors. It also changes the behavior when tracking
an already tracked PID or untracking a PID that is not tracked from an
error to a warning with a successful exit code.
Fixes: #898
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 13 Aug 2015 18:37:14 +0000 (14:37 -0400)]
Tests: Fix flacky clock-plugin test
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 6 Aug 2015 23:00:15 +0000 (19:00 -0400)] 
Build: look for python >= 3.0 when building python bindings
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 6 Aug 2015 23:00:14 +0000 (19:00 -0400)]
Build: rename use_python to python_binding
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 6 Aug 2015 21:15:45 +0000 (17:15 -0400)]
Fix: regression tests
Fix racy session/relayd wait-after-kill scheme.
Fix racy live test where application may not have generated events yet
when we attach to the live trace.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Wed, 29 Jul 2015 21:57:52 +0000 (17:57 -0400)]
Fix: tests: stderr not correctly redirected
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Tue, 11 Aug 2015 20:29:30 +0000 (16:29 -0400)] 
Fix: TimeoutExpired in Python tests not defined globally
The `TimeoutExpired` exception is used in multiple locations
throughout the Python tests. However, it needs to be used as
`subprocess.TimeoutExpired` given that it is only defined in that
module.
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 23 Jul 2015 01:49:21 +0000 (21:49 -0400)]
Tests: ust: clock override plugin
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 10 Apr 2015 17:17:25 +0000 (13:17 -0400)]
Cleanup: reuse tracker* element from config
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 9 Apr 2015 20:38:24 +0000 (16:38 -0400)]
Test: save/load: pid_tracker basic test
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 12 Aug 2015 16:24:53 +0000 (12:24 -0400)]
Clean-up: Remove statement which has no side-effect
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 31 Mar 2015 21:15:36 +0000 (17:15 -0400)]
Save/load: pid_tracker feature.
Xml schema updated
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Sat, 28 Mar 2015 22:00:09 +0000 (18:00 -0400)]
Test: mi: track/untrack feature
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 3 Apr 2015 21:15:43 +0000 (17:15 -0400)]
Util: xml_extract: add node_exist option
The node_exist argument permit a more flexible way to extract informations
within test suites. We can check the presence of a node and not only list
the content of a final node.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 11 Aug 2015 19:15:27 +0000 (15:15 -0400)]
Mi: track/untrack: validation
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 11 Aug 2015 16:53:49 +0000 (12:53 -0400)]
Docs: Grammar fixes in mi_lttng.xsd
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 11 Aug 2015 16:44:06 +0000 (12:44 -0400)]
Fix: Ensure a valid command error code is returned by track/untrack
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 11 Aug 2015 16:23:28 +0000 (12:23 -0400)]
Clean-up: Remove java-doc annotations from function header
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 11 Aug 2015 19:14:11 +0000 (15:14 -0400)]
Mi: track/untrack/listing
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 7 Aug 2015 21:01:37 +0000 (17:01 -0400)]
Fix: intialization of ust_metadata_poll_pipe to garbage value
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 7 Aug 2015 20:17:02 +0000 (16:17 -0400)]
Fix "allocator sizeof operand mismatch" warning
Addresses benign scan-build waring:
Result of 'realloc' is converted to a pointer of type 'char *',
which is incompatible with sizeof operand type 'char **'
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 7 Aug 2015 19:10:18 +0000 (15:10 -0400)]
Clean-up: Remove java-doc style function header from session.h
While we should move to a consistent API documentation style,
this function's documentation is inconsistent with the rest
of the public LTTng API.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 7 Aug 2015 19:08:14 +0000 (15:08 -0400)]
Clean-up: remove extra space in comment
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 6 Aug 2015 19:52:37 +0000 (15:52 -0400)]
Fix: test_mi test
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 6 Aug 2015 16:39:13 +0000 (12:39 -0400)]
Tests: Java agent: Add configure switches to enable tests
This patch adds the switches --enable-test-java-agent-(jul|log4j|all) to
the configure script, the tests now need to be explicitly enabled and
their dependencies are only checked if so.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Tue, 4 Aug 2015 22:29:35 +0000 (18:29 -0400)]
Fix: incorrect script name in python logging test
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 19:05:07 +0000 (15:05 -0400)]
Docs: Document Agent reply codes
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 19:04:45 +0000 (15:04 -0400)]
Docs: Remove Java-specific comments from agent.h
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 19:02:31 +0000 (15:02 -0400)]
Docs: Grammar fix in agent header
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 19:01:50 +0000 (15:01 -0400)]
Return "Unknown" error instead of "Fatal" on unhandled agent replies
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 19:01:12 +0000 (15:01 -0400)]
Log agent reply in disable_event()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 19:00:45 +0000 (15:00 -0400)]
Log agent reply in enable_event()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 18:59:58 +0000 (14:59 -0400)]
Log agent reply in list_events()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 18:58:57 +0000 (14:58 -0400)]
Add agent reply code logging helpers
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 18:57:17 +0000 (14:57 -0400)]
Add a LOG() macro which handles dynamic severity levels
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 02:03:29 +0000 (22:03 -0400)]
Fix: Discard disable event command filter payload
liblttng-ctl sends both the filter expression and filter bytecode
whenever lttng_disable_event_ext() is used _or_ when it is used
implicitly by lttng_disable_event() on an Agent domain (Log4j,
JUL or Python).
As of now, the session daemon ignores this filter payload.
However, on some rare occasions (the frequency of which depends
on the system's configuration and load), the second call to
sendmsg() done by liblttng-ctl could block and return an error
when the session daemon closed the socket (EPIPE).
This fix ensures the payload is received and discarded by the
session daemon, which in turn allows the client to handle the
session daemon's reply to the command.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 01:26:34 +0000 (21:26 -0400)]
Fix: Use MSG_NOSIGNAL when calling sendmsg()
Applications using the liblttng-ctl library are most probably
not expecting the SIGPIPE signal which can be triggered by
sendmsg() on a closed socket. Use the MSG_NOSIGNAL flag to
handle such cases gracefully.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 5 Aug 2015 18:57:36 +0000 (14:57 -0400)]
Send data pending status as part of payload instead of an invalid error
This ensures that the session daemon's logs don't contain false
positives every time a data pending command is replied-to.
The use of invalid error codes 0 and 1 causes the log to contain
misleading entries of the form:
Sending response (size: 16, retcode: Unknown error code (0)) [...]
This commit also proves that it is possible, contrary to what the
previous comment indicated, to send a boolean value over a socket
without using undocumented error codes.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 5 Aug 2015 18:09:27 +0000 (14:09 -0400)]
Log error code's value when sessiond replies to a client
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 4 Aug 2015 22:21:40 +0000 (18:21 -0400)]
Tests: Java agent: update after Java agent refactoring
This patch fixes the Java agent tests which were impossible to run since
the Jar files have been renamed. It also overhauls the java part of the
configure script to match what's in UST and replace some hardcoded path
with configurable values.
The tests are now enabled when corresponding classes are found in the
CLASSPATH during configure.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 3 Aug 2015 20:48:16 +0000 (16:48 -0400)]
Set registration done Agent command version back to 0
The command version was used to indicate a workaround introducing a
change of behavior in a minor version. 2.6 was the only version affected
by this bug.
Fixes #884
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 3 Aug 2015 20:45:00 +0000 (16:45 -0400)]
Fix: Don't send agent disable event command twice
The session daemon sends a "disable event" command to agents for each
event, enabled or not, on session destroy. This had no adverse effect
of the Java agent since it suffered from an unrelated bug which ignored
any refcount decrementation.
This fix bumps the command version to "1" to indicate that this behavior
is fixed on the session daemon's end.
Fixes #884
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 1 Apr 2015 00:10:07 +0000 (20:10 -0400)]
Tests: Python agent: update after Python agent refactoring
This patch makes the tests follow the recent refactoring
of the LTTng-UST Python agent.
You need both python2 and python3 in your $PATH to run this
test now (since the agent is compatible with both versions
of Python).
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 3 Aug 2015 16:18:10 +0000 (12:18 -0400)]
Clean-up: Remove redundant variable initialization
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Sat, 1 Aug 2015 19:20:50 +0000 (15:20 -0400)]
Fix: incorrect variable being checked in libc-wrapper test
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 30 Jul 2015 20:51:03 +0000 (16:51 -0400)]
Rename Python agent event name to omit "user"
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 30 Jul 2015 20:49:49 +0000 (16:49 -0400)]
Consolidate agent event names regardless of user privilege
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 30 Jul 2015 16:48:52 +0000 (12:48 -0400)]
Clean-up: Move agent_apps_ht_by_sock definition to main.c
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 30 Jul 2015 16:46:56 +0000 (12:46 -0400)]
Fix: Initialize global agent_apps_ht_by_sock on session daemon launch
Reported-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Partha Pratim Mukherjee [Sat, 25 Jul 2015 07:55:19 +0000 (13:25 +0530)] 
Fix: set session should not set non-existent session
set-session does not check the existence of a session before setting
it as the current session. Fix it so that it gives error for a
non-existent session.
Fixes #885
Signed-off-by: Partha Pratim Mukherjee <ppm.floss@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 24 Jul 2015 21:42:59 +0000 (17:42 -0400)]
Fix: pids should be numbers only
Ruled out cases: word, number+word, word+number, number+word+number
Ex: foo, 123foo, foo123, 123foo123
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 26 Jul 2015 20:16:23 +0000 (16:16 -0400)]
Fix: Mishandled NULL short options in lttng-sessiond
set_option() ignores any option which has no short option
defined.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 26 Jul 2015 20:13:18 +0000 (16:13 -0400)]
Use popt "required_argument" and "no_argument" constants
Use popt's provided constants for the "has_arg" field of long
options instead of hardcoding 0 and 1 everywhere.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 26 Jul 2015 18:54:24 +0000 (14:54 -0400)]
Fix: Mishandled NULL short options in utils_generate_optstring()
The NULL character is used to indicate that no short option is
available for a given command.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 26 Jul 2015 00:09:23 +0000 (20:09 -0400)]
Fix: only launch a new session daemon for the "create" command
Fixes #859
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 23:50:22 +0000 (19:50 -0400)]
Fix 'daemon' typo in lttng-ctl-pc.in description
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 21:48:12 +0000 (17:48 -0400)]
Fix: clean-up agent app hash table from the main sessiond thread
The agent application hash table, which is allocated by the session
daemon's main thread, is free'd from the agent application registration
thread.
This leads to a number of interesting scenarios under which the agent
app registration thread may encounter an error, thus tearing itself down
and freeing the agent_apps_ht_by_sock hash table. Of course, nothing then
prevents the client processing thread from accessing this invalidated hash
table to list, enable or disable agent events which leads to crashes or
assertions hitting in ht_match_reg_uid().
However, it is not necessary for the agent app registration thread to
encounter an error for this to prove problematic. As shown in bug #893,
the session daemon's teardown will assert on a NULL key in
ht_match_reg_uid() whenever it is performed while a JUL, Log4J or Python
event is still enabled in a session. This happens because the session
daemon's clean-up triggers the destruction of all sessions. The destruction
of those sessions would access the free'd agent_apps_ht_by_sock to disable
the registered agent events.
Fixes #893
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 21:38:29 +0000 (17:38 -0400)]
Fix: Remove undocumented session daemon short options
Fixes #864
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 20:31:43 +0000 (16:31 -0400)]
Comment grammar correction
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 20:28:50 +0000 (16:28 -0400)]
Log userspace application hash table allocation failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 20:24:05 +0000 (16:24 -0400)]
Fix: RCU read-side lock released too early in destroy_agent_app
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 19:54:19 +0000 (15:54 -0400)]
Fix: misleading logging statement in agent_find_event
An _event_ is not found, not an agent.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 24 Jul 2015 22:01:02 +0000 (18:01 -0400)]
Fix: Unhandled domain option condition in list_agent_events
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 24 Jul 2015 21:54:47 +0000 (17:54 -0400)]
Fix: Crash on lttng list -j/-l/-p when no events are present
The lttng client will free an uninitialized pointer whenever a the
lttng list command is invoked on a domain which involves the log4j,
JUL or Python agents.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 16 Jul 2015 17:16:20 +0000 (13:16 -0400)]
Clean-up: spelling fix in a comment
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.041872 seconds and 4 git commands to generate.
projects / lttng-tools.git / log
