tracepoint: include stdio.h for NULL definition

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

manpage update: document that probes need gcc

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove # in front on extern "C" {

Fails to compile with g++.

Reported-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: don't use GNU old-style field designator extension

ustfork.c:112:38: warning: use of GNU old-style field designator extension
      [-Wgnu-designator]
                struct ustfork_clone_info info = { fn: fn, arg: arg };
                                                   ^~~
                                                   .fn =
ustfork.c:112:46: warning: use of GNU old-style field designator extension
      [-Wgnu-designator]
                struct ustfork_clone_info info = { fn: fn, arg: arg };
                                                           ^~~~
                                                           .arg =

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove padding field after variable sized array

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use unsigned long type for events discarded counter

Overflows at 64-bit on 64-bit systems.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: getcpu build with modern uClibc versions

uClibc has sched_getcpu since 0.9.33, so the compat workaround should
only be used for older uClibc versions.

Fixes #225

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: lttng-ust.pc needs to specify -ldl

Fixes #224

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: examples Makefiles should pass $(LIBS) at last

Fixes #210

Description

Since Ubuntu 11.10, the "--as-needed" option is given by default to ld
(linker). This option breaks the makefiles given with the userspace
tracing examples. Therefore the libraries against which the program
should be linked should be passed at last:
$(CC) -o $@ $^ $(LIBS)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Build a jar for the Java side of the JNI interface

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ustctl need to send the second fd upon error of 1st fd

Otherwise cause protocol discrepancy between ust and sessiond upon send
error. The sessiond will wait for an fd that never arrives.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Add missing fork test program dependency library

Only seem to affect some setups (e.g. older gcc ?) with the BSD
compatibility.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Make the JNI interface actually work

Now a user can import LTTngUst.java (which is now in a proper
package) and then define tracepoints in his application with:

LTTngUst.tracepointString(name, args);

We could eventually ship it in a .jar when the JNI interface is
enabled. It's still very basic, only string payloads are
implemented, and there is no mechanism to enable/disable trace
points call sites at runtime (they are always enabled). The event under
which these events appear is "lttng_ust_java:string".

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'dev'

Fix: stringify version description

Note: config.h is unused in lttng 2.0, so no need to backport this fix.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update version to 2.0.1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use bsd-compatible fcntl for close-on-exec on socket

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix multi-session wildcard support

Incorrectly unset loglevel information upon creation of wildcard_entry
was causing a second session with wildcard enabled to not record its
events.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix event lost count when buffer is full

The tracing channels should count lost events due to buffer full, and
the metadata channel should not (see comment), but not the opposite.
This was a mixup between the two.

Reported-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove inappropriate \n from easy-ust sample

Although \n is permitted in strings, it adds newlines in the trace
pretty-printer output, which is not that nice.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update version to 2.0.0 stable

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

make dist: Generate bzip2 instead of gzip

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update version to 2.0.0-rc4

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix out-of-bound write in ltt-events.c

Valgrind complains that the size allocated is too small for the memcpy,
rightly so (off by one).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Document LTTNG_UST_DEBUG_VALGRIND compilation flag

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update COPYING

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add exception handling to lttng-gen-tp io operations

(closes: 54)

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update version to 2.0.0-rc3

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: sendmsg should retry on EINTR, and use MSG_NOSIGNAL

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: ustcomm_close_unix_sock should close, not shutdown

.. and ensure that we actually use the API rather than doing the close()
directly in the caller.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: do not print EPIPE perror, as it is an expected error

It is perfectly valid for the other end to close its socket, so do not
report broken pipe errors as perror.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Ensure that multiplication of clock offset is done on 64-bit

This is not a bug in UST per se, because we happen to force
multiplication by a ULL number, but force cast to uint64_t anyway to
ensure we don't trigger this overflow if the constant ever happen to
change.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add 2 missing licenses in deprecated tests

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unbuild and unused (deprecated) make_shared_lib test

Was for UST 0.x.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

License text standardization, add missing licenses

- Use MIT/X11 text for BSD-style license.
- Fix FSF address.
- Use appropriate LTTNG_ prefix for ifndef (rather than LINUX).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove duplicate check for 0 num_subbuf and subbuf_size

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: power of 2 size check should apply to size_t type, not uint32_t

Fix this by using the much simpler x & (x - 1) check (rather than
hweight(x) == 1).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' into dev

Fix: recvmsg should handle EINTR

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' into dev

Make lttng-gen-tp work on python 2.6

(refs #114)

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Make lttng-gen-tp executable

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

usterr: do not include unused sys/syscall.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update version to 2.0.0-rc2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage fixes

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: dmesg printout should not print metadata warnings

Metadata channel retry when an event is dropped by the underlying
buffer. We should not print a message showing that the event has been
dropped to the user on debug console.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use transport name as channel name

Clarify lost event printout.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' into dev

Conflicts:
liblttng-ust/ltt-events.c
liblttng-ust/lttng-context-vtid.c
liblttng-ust/lttng-ust-comm.c
libringbuffer/ring_buffer_frontend.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Add signature check in tracepoint activation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add tracepoint signature at tracepoint definition site

Will enable type-checking between call site and handler.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: keep event probe signature, for use by event probe signature check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix ABI: add padding to structures shared between UST and consumer

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix ABI: add padding to tracepoint and ring buffer config public structures

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix ABI: Adding missing padding in tracepoint event structures

Add padding for future extensions.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Add include/lttng/ust-config.h to git ignore

(fixes #95)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix effect: update README about dlopen()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: fixup vtid TLS

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Conflicts:

liblttng-ust/lttng-context-vtid.c

Fix: fixup ringbuffer tls at constructor by forcing read

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Conflicts:

liblttng-ust/lttng-ust-comm.c
libringbuffer/ring_buffer_frontend.c

Fix: fix deadlock with dlopen() lttng-ust

Pre-"fault" the libuuid TLS outside of the ust lock to ensure that we
never deadlock with the linker mutex in libc. This mutex is held both
for TLS fixup of dlopen'd libs, and across execution of all
constructors. We therefore have a reverse use of this mutex wrt ust
lock, that we fix by forcing the TLS fixup to happen very early in the
lttng-ust constructor.

[fixed merge from dev branch]

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix effect: update README about dlopen()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: fixup vtid TLS

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: fixup ringbuffer tls at constructor by forcing read

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: fix deadlock with dlopen() lttng-ust

Pre-"fault" the libuuid TLS outside of the ust lock to ensure that we
never deadlock with the linker mutex in libc. This mutex is held both
for TLS fixup of dlopen'd libs, and across execution of all
constructors. We therefore have a reverse use of this mutex wrt ust
lock, that we fix by forcing the TLS fixup to happen very early in the
lttng-ust constructor.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' into dev

Fix: only print event errors every 1048576 hits

Never spam the console, even in debug mode, since it would make debug
information very much useless.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing debug printout to identify the cause of lost events

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' into dev

fix: liblttng-ust-ctl should check for incorrect parameters

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: ust comm error handling segfault

On comm errors, UST should not try to populate fields from NULL
pointers.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: ust comm error handling segfault

On comm errors, UST should not try to populate fields from NULL
pointers.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

freebsd port: use a leading / prefix for shm tmp name

FreeBSD complains if the leading / is missing.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust-endian.h: update warning message

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove gettid warning

Not so important, hides really useful warnings.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add configure amd64 support (for FreeBSD)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove O_LARGEFILE from tests

Not portable.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Wrap FLOAT_WORD_ORDER

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust-event.h: use BYTE_ORDER instead of __BYTE_ORDER

available on both Linux and FreeBSD.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Detect and document dependency on -ldl on Linux, -lc on BSD for dlopen

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove useless const qualifier

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update uuid_create type cast

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cast uuid_create parameter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add freebsd rfork support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

uuid.h should only be included when libuuid is detected

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename uuid.h wrapper to lttng-ust-uuid.h

So it does not clash with BSD system's uuid.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Create libuuid/libc uuid wrapper

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

configure.ac: check for both libuuid/libc uuid APIs

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use bsd-compatible fcntl for close-on-exec on socket

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use ENOMSG as fallback for ENODATA on freebsd

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use XSI-compliant strerror_r by default on non-Linux

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Compat layer for gettid

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

snprintf: fix namespace of snprintf types for freebsd

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add freebsd support for getcpu (use cpu nr 0)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add get proc name wrapper for FreeBSD

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix freebsd endian support

Need to use #elif defined().

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fls: use local namespace to do not clash with FreeBSD string.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add FreeBSD compat layer for endian.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Add FreeBSD compat layer for endian.h"

This reverts commit 8740da0a30986094ebf03a0f3b7448844d5e886f.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "fls: use local namespace to do not clash with FreeBSD string.h"

This reverts commit 6b95cebfaaf9f6ee862fc790d5a128769dc573bf.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Fix freebsd endian support"

This reverts commit 020760b19e351bda940b38ca273f32206ab4d03f.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Add get proc name wrapper for FreeBSD"

This reverts commit 48621a4272bdeb1e8fced511ca6bf3c4c2240c15.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>