lttng-ust.git
11 years agoFix: compile doc/ after JUL/Java
David Goulet [Fri, 22 Nov 2013 18:50:01 +0000 (13:50 -0500)] 
Fix: compile doc/ after JUL/Java

Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoJUL: add Hello.java in doc/examples
David Goulet [Wed, 20 Nov 2013 20:24:02 +0000 (15:24 -0500)] 
JUL: add Hello.java in doc/examples

Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix lttng-ust(3) manpage
Mathieu Desnoyers [Sat, 23 Nov 2013 17:55:44 +0000 (12:55 -0500)] 
Fix lttng-ust(3) manpage

Describe that TRACEPOINT_CREATE_PROBES is needed.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoJUL: fix enable all event for delayed Logger
David Goulet [Wed, 20 Nov 2013 16:35:35 +0000 (11:35 -0500)] 
JUL: fix enable all event for delayed Logger

This adds a HashMap containing the enabled Logger names (and wildcard
'*'). This is used to make sure we don't enable twice the same Logger
for the '*' event name (enable all -a).

Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: typo in JNICALL for the JUL tracepoint
David Goulet [Wed, 20 Nov 2013 15:04:04 +0000 (10:04 -0500)] 
Fix: typo in JNICALL for the JUL tracepoint

Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: move va_end to outermost label
Mathieu Desnoyers [Tue, 19 Nov 2013 02:16:06 +0000 (21:16 -0500)] 
Fix: move va_end to outermost label

Coverity:

** CID 1021237:  Missing varargs init or cleanup  (VARARGS)
/snprintf/vfprintf.c: 955 in ust_safe_vfprintf()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: add missing NULL check after allocation
Mathieu Desnoyers [Tue, 19 Nov 2013 02:07:13 +0000 (21:07 -0500)] 
Fix: add missing NULL check after allocation

Found by coverity:

** CID 1021246:  Dereference null return value  (NULL_RETURNS)
/libringbuffer/shm.c: 80 in shm_object_table_create()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix cleanup: all spaces before flags
Mathieu Desnoyers [Fri, 15 Nov 2013 19:52:41 +0000 (14:52 -0500)] 
Fix cleanup: all spaces before flags

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agofix: lttng-gen-tp: add missing spaces around flags
Mathieu Desnoyers [Fri, 15 Nov 2013 19:43:45 +0000 (14:43 -0500)] 
fix: lttng-gen-tp: add missing spaces around flags

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoVersion 2.4.0-rc1 v2.4.0-rc1
Mathieu Desnoyers [Fri, 15 Nov 2013 18:55:22 +0000 (13:55 -0500)] 
Version 2.4.0-rc1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agodoc/examples: error out when a subdir make fails
Mathieu Desnoyers [Fri, 15 Nov 2013 18:48:28 +0000 (13:48 -0500)] 
doc/examples: error out when a subdir make fails

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoJUL: fix out of tree build
Mathieu Desnoyers [Fri, 15 Nov 2013 18:24:40 +0000 (13:24 -0500)] 
JUL: fix out of tree build

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoJava/jul: fix make dist
Mathieu Desnoyers [Fri, 15 Nov 2013 17:17:02 +0000 (12:17 -0500)] 
Java/jul: fix make dist

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoJUL: install documentation and jar file
Mathieu Desnoyers [Fri, 15 Nov 2013 16:59:46 +0000 (11:59 -0500)] 
JUL: install documentation and jar file

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd missing copyrights to test scripts
Mathieu Desnoyers [Fri, 15 Nov 2013 15:46:08 +0000 (10:46 -0500)] 
Add missing copyrights to test scripts

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoEscape minus signs in lttng-ust-cyg-profile manpage
Jon Bernard [Fri, 15 Nov 2013 14:12:47 +0000 (09:12 -0500)] 
Escape minus signs in lttng-ust-cyg-profile manpage

By default, "-" chars are interpreted as hyphens (U+2010) by groff, not
as minus signs (U+002D). Since options to programs use minus signs
(U+002D), this means for example in UTF-8 locales that you cannot cut
and paste options, nor search for them easily.

Source: http://lintian.debian.org/tags/hyphen-used-as-minus-sign.html

Signed-off-by: Jon Bernard <jbernard@tuxion.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix spelling mistake in lttng-ust manpage
Jon Bernard [Fri, 15 Nov 2013 14:12:33 +0000 (09:12 -0500)] 
Fix spelling mistake in lttng-ust manpage

Signed-off-by: Jon Bernard <jbernard@tuxion.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix tests/benchmark
Zifei Tong [Fri, 15 Nov 2013 15:04:55 +0000 (23:04 +0800)] 
Fix tests/benchmark

Add copyright notice.

Remove extern C guard with respect to #597.

Signed-off-by: Zifei Tong <soariez@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoImplement base-address-state tracing
Paul Woegerer [Thu, 14 Nov 2013 18:39:49 +0000 (19:39 +0100)] 
Implement base-address-state tracing

Dump the base-address state (executable and shared objects) into session
on session-enable (per-session events).

Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoBase-address tracing for dlopen and dlclose
Paul Woegerer [Thu, 14 Nov 2013 17:03:25 +0000 (18:03 +0100)] 
Base-address tracing for dlopen and dlclose

Provide an LD_PRELOAD library to allow tracing of calls to dlopen and
dlclose.

Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd a check against excluders
JP Ikaheimonen [Thu, 7 Nov 2013 10:22:35 +0000 (12:22 +0200)] 
Add a check against excluders

When matching enablers with events, first check against all
excluders of the enabler. If the event matches with any of the excluders,
then the event does not match with the enabler.

[ Edit by Mathieu Desnoyers: apply coding style changes. ]

Signed-off-by: JP Ikaheimonen <jp_ikaheimonen@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd handler for LTTNG_UST_EXCLUSION in UST ABI
JP Ikaheimonen [Thu, 7 Nov 2013 10:22:34 +0000 (12:22 +0200)] 
Add handler for LTTNG_UST_EXCLUSION in UST ABI

Add message handler for the LTTNG_UST_EXCLUSION command in
UST ABI. Copy the exclusion data into a lttng_ust_excluder_node
structure and pass it to the enabler command handler.

Signed-off-by: JP Ikaheimonen <jp_ikaheimonen@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoStore exclusions to enablers
JP Ikaheimonen [Thu, 7 Nov 2013 10:22:33 +0000 (12:22 +0200)] 
Store exclusions to enablers

Implement a function that adds exclusions to the list in the enabler.
Call this function in the enabler command handler when the
LTTNG_UST_EXCLUSION command is received.

Signed-off-by: JP Ikaheimonen <jp_ikaheimonen@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd excluders to enabler structure
JP Ikaheimonen [Thu, 7 Nov 2013 10:22:32 +0000 (12:22 +0200)] 
Add excluders to enabler structure

Define a structure that holds excluders and can be used in lists.
Add a list holding these structures to the enabler structure.
Initialize and destroy the list when the enabler is initialized
and destroyed.

Signed-off-by: JP Ikaheimonen <jp_ikaheimonen@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoSend exclusion data through ustcomm
JP Ikaheimonen [Thu, 7 Nov 2013 10:22:31 +0000 (12:22 +0200)] 
Send exclusion data through ustcomm

Define a function ustctl_set_exclusion that sends the
exclusion data through ustcomm with the LTTNG_UST_EXCLUSION
command message.

Signed-off-by: JP Ikaheimonen <jp_ikaheimonen@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoDefine exclusion structure for UST ABI
JP Ikaheimonen [Thu, 7 Nov 2013 10:22:30 +0000 (12:22 +0200)] 
Define exclusion structure for UST ABI

Define a structure for holding exception data. The last data item
is a flexible array that contains a variable number of
exclusions names.

Signed-off-by: JP Ikaheimonen <jp_ikaheimonen@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoDefine a new command LTTNG_UST_EXCLUSION
JP Ikaheimonen [Thu, 7 Nov 2013 10:22:29 +0000 (12:22 +0200)] 
Define a new command LTTNG_UST_EXCLUSION

Define a new command id for attaching exclusions to enablers.
Define the structure for passing the command.

Signed-off-by: JP Ikaheimonen <jp_ikaheimonen@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: package of LTTngUst.h was renamed without renaming target in makefile
Michael Jeanson [Wed, 13 Nov 2013 17:21:47 +0000 (12:21 -0500)] 
Fix: package of LTTngUst.h was renamed without renaming target in makefile

Signed-off-by: Michael Jeanson <mjeanson@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: check for java .class in package subfolders
Michael Jeanson [Wed, 13 Nov 2013 17:16:18 +0000 (12:16 -0500)] 
Fix: check for java .class in package subfolders

Signed-off-by: Michael Jeanson <mjeanson@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: java library to use user define JDK at compile time
David Goulet [Mon, 11 Nov 2013 17:52:23 +0000 (12:52 -0500)] 
Fix: java library to use user define JDK at compile time

Signed-off-by: David Goulet <dgoulet@efficios.com>
11 years agoAdd liblttng-ust-jul for JUL support
David Goulet [Thu, 7 Nov 2013 21:34:23 +0000 (16:34 -0500)] 
Add liblttng-ust-jul for JUL support

The build system creates a jar file named liblttng-ust-jul.jar to be
linked with the Java application. A public library named
liblttng-ust-jul.so is also created and must be in the library path of
the Java application in order for the LTTngAgent to use it for the
tracer's JNI call.

A unit test is also added and integrated with the "make check" command.

Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: application SIGBUS when starting in parallel with sessiond
Mathieu Desnoyers [Wed, 6 Nov 2013 12:03:10 +0000 (07:03 -0500)] 
Fix: application SIGBUS when starting in parallel with sessiond

There is a race between application startup and sessiond startup, where
there is an intermediate state where applications can SIGBUS if they see
a zero-sized shm, if the shm has been created, but not ftruncated yet.

On the UST side, fix this by ensuring that UST can read the shared
memory file descriptor with a read() system call before they try
accessing it through a memory map (which triggers the SIGBUS if the
access goes beyond the file size).

On the sessiond side, another commit needs to ensure that the shared
memory is writeable by applications as long as its size is 0, which
allow applications to perform ftruncate and extend its size.

Fixes #623

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: Minor corrections to the lttng-ust man page
Jérémie Galarneau [Wed, 23 Oct 2013 16:09:06 +0000 (12:09 -0400)] 
Fix: Minor corrections to the lttng-ust man page

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoDocumentation cleanup: Overhaul of the lttng-gen-tp man page
Jérémie Galarneau [Wed, 23 Oct 2013 16:08:15 +0000 (12:08 -0400)] 
Documentation cleanup: Overhaul of the lttng-gen-tp man page

Fix a couple of typos, mistakes and out-of date informations.

[Mathieu: added extra fix recommended by Daniel Thibault]

Acked-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoWarning cleanup: add missing padding initializer
Mathieu Desnoyers [Thu, 31 Oct 2013 12:21:55 +0000 (08:21 -0400)] 
Warning cleanup: add missing padding initializer

Reported-by: Marcus Tomlinson <themarcustomlinson@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: socket connect hang on heavy loads
Mathieu Desnoyers [Fri, 11 Oct 2013 19:03:24 +0000 (15:03 -0400)] 
Fix: socket connect hang on heavy loads

We need to perform both connect and sending registration message before
doing the next connect otherwise we may reach unix socket connect queue
max limits and block on the 2nd connect while the session daemon is
awaiting the first connect registration message.

This happens in scenarios where unix socket connect queues are nearly
full.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoCleanup: fix typo
Mathieu Desnoyers [Fri, 11 Oct 2013 18:41:39 +0000 (14:41 -0400)] 
Cleanup: fix typo

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: ust-comm recvmsg should handle partial receive
Mathieu Desnoyers [Fri, 11 Oct 2013 18:20:22 +0000 (14:20 -0400)] 
Fix: ust-comm recvmsg should handle partial receive

Handles cases where unix socket buffer is full. Without this fix, the
session daemon kicks out application that happen to have their
registration message split into multiple recvmsg on the sessiond side.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agogcc warning fix: -Wextra
Mathieu Desnoyers [Tue, 8 Oct 2013 21:35:15 +0000 (17:35 -0400)] 
gcc warning fix: -Wextra

For the "ordered comparison of pointer with integer zero" warning, fix
this by comparing (type) -1 against (type) 0 instead of just 0, so if
"type" is a pointer type, this pointer type will be applied to the right
operand too, thus fixing the warning.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd usage reference count for tracepoints
Ikaheimonen, JP [Mon, 7 Oct 2013 13:33:02 +0000 (09:33 -0400)] 
Add usage reference count for tracepoints

Keep track of how many libraries use a tracepoint, and disable the
tracepoint when the number of users drops to zero.

A new reference counter is added to tracepoint_entry. This keeps track
of how many callsites use that tracepoint.

When you have libraries and/or executables sharing tracepoints, you
cannot just disable your tracepoints when the library is unregistered.
You must check that the tracepoint is not used by any other libraries
before you disable it.

Function lib_disable_tracepoints becomes unnecessary, and is removed.

Signed-off-by: Ikaheimonen, JP <jp_ikaheimonen@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agotracepoint.c: Move add_callsite/remove_callsite further down in file
Mathieu Desnoyers [Mon, 7 Oct 2013 13:30:52 +0000 (09:30 -0400)] 
tracepoint.c: Move add_callsite/remove_callsite further down in file

In preparation for calling disable_tracepoint() from those functions.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoStore the callsites into the library callsite list
Ikaheimonen, JP [Thu, 3 Oct 2013 06:46:27 +0000 (06:46 +0000)] 
Store the callsites into the library callsite list

Fix the issue where the callsites are registered but never
properly unregistered.

[ Edit by Mathieu Desnoyers: minor coding style fix: remove parenthesis. ]

Signed-off-by: Ikaheimonen, JP <jp_ikaheimonen@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix linking warning
Mohamad Gebai [Mon, 30 Sep 2013 20:47:30 +0000 (16:47 -0400)] 
Fix linking warning

lttng_static_ctx should be extern in this header to avoid getting a
warning when --warn-common is used.

PS: Thanks to Yannick Brosseau for his help.

Signed-off-by: Mohamad Gebai <mohamad.gebai@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoPer-stream ioctl to get the current timestamp
Julien Desfossez [Thu, 19 Sep 2013 17:51:55 +0000 (13:51 -0400)] 
Per-stream ioctl to get the current timestamp

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoLTTng ringbuffer ABI calls for index generation
Julien Desfossez [Thu, 19 Sep 2013 17:51:54 +0000 (13:51 -0400)] 
LTTng ringbuffer ABI calls for index generation

These new calls export the data required for the consumer to
generate the index while tracing :
- timestamp begin
- timestamp end
- events discarded
- context size
- packet size
- stream id

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoSpecialize lttng_ust_lib_ring_buffer_client_cb
Julien Desfossez [Thu, 19 Sep 2013 17:51:53 +0000 (13:51 -0400)] 
Specialize lttng_ust_lib_ring_buffer_client_cb

Prepare the ring-buffer config to have custom callbacks. These custom
callbacks are not related to the ring-buffer operations but allow
applications to add custom functions.
No additional feature or change in behaviour in this patch.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd tracing instrumentation for pthread mutex lock functions
Stefan Seefeld [Wed, 4 Sep 2013 14:01:50 +0000 (10:01 -0400)] 
Add tracing instrumentation for pthread mutex lock functions

Signed-off-by: Stefan Seefeld <stefan_seefeld@mentor.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoVersion 2.3.0 v2.3.0
Mathieu Desnoyers [Tue, 3 Sep 2013 21:53:23 +0000 (17:53 -0400)] 
Version 2.3.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoVersion 2.3.0-rc2 v2.3.0-rc2
Mathieu Desnoyers [Fri, 30 Aug 2013 18:36:33 +0000 (14:36 -0400)] 
Version 2.3.0-rc2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agodoc/examples/gen-tp: pass automake CPPFLAGS/CFLAGS/LDFLAGS
Mathieu Desnoyers [Mon, 26 Aug 2013 15:26:09 +0000 (11:26 -0400)] 
doc/examples/gen-tp: pass automake CPPFLAGS/CFLAGS/LDFLAGS

Fix cross-build.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agotools/lttng-gen-tp: honor CPPFLAGS and LDFLAGS
Mathieu Desnoyers [Mon, 26 Aug 2013 15:24:26 +0000 (11:24 -0400)] 
tools/lttng-gen-tp: honor CPPFLAGS and LDFLAGS

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: doc/examples cross-build
Mathieu Desnoyers [Mon, 26 Aug 2013 15:14:56 +0000 (11:14 -0400)] 
Fix: doc/examples cross-build

We need to pass automake's CPPFLAGS and LDFLAGS to examples. Add CFLAGS
too for completeness.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: liblttng_ust.la should depend on liblttng-ust-tracepoint.la
Mathieu Desnoyers [Thu, 22 Aug 2013 21:59:06 +0000 (17:59 -0400)] 
Fix: liblttng_ust.la should depend on liblttng-ust-tracepoint.la

Changing -llttng-ust-tracepoint to liblttng-ust-tracepoint.la, so it
appears in the build dependencies.

Fixes #325

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoIntroduce configure --with-lttng-system-rundir
Mathieu Desnoyers [Mon, 19 Aug 2013 18:38:02 +0000 (14:38 -0400)] 
Introduce configure --with-lttng-system-rundir

Allow overriding the path where the system-wide sessiond is expected to
keep its runtime files.

It does _not_ allow multiple instances of system-wide sessiond to run in
parallel though, because the wait shm files still requires having only
one single system-wide sessiond at any given time.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoexamples: tracepoint probes don't need extern C
Mathieu Desnoyers [Thu, 15 Aug 2013 18:21:41 +0000 (14:21 -0400)] 
examples: tracepoint probes don't need extern C

Fix all UST demo applications under doc/examples/

Fixes #597

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoTracepoint probes don't need extern C
Mathieu Desnoyers [Thu, 15 Aug 2013 14:55:30 +0000 (10:55 -0400)] 
Tracepoint probes don't need extern C

tracepoint.h has the proper extern C guards, so every liblttng-ust API
called from the probe has the proper linkage.

The rest of the symbols are only meaningful within the probe, so we
don't care if they are mangled or not.

This fixes the two examples, and lttng-gen-tp.

Fixes #597

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd trace support for memalign and posix_memalign
Stefan Seefeld [Wed, 7 Aug 2013 18:34:02 +0000 (14:34 -0400)] 
Add trace support for memalign and posix_memalign

Signed-off-by: Stefan Seefeld <stefan_seefeld@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agomalloc instrumentation: remove dependency on pthread
Mathieu Desnoyers [Wed, 7 Aug 2013 15:48:50 +0000 (11:48 -0400)] 
malloc instrumentation: remove dependency on pthread

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd trace support for calloc and realloc.
Stefan Seefeld [Wed, 7 Aug 2013 15:28:12 +0000 (11:28 -0400)] 
Add trace support for calloc and realloc.

Signed-off-by: Stefan Seefeld <stefan_seefeld@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: allow make check to run in VPATH build
Mathieu Desnoyers [Tue, 6 Aug 2013 15:50:02 +0000 (11:50 -0400)] 
Fix: allow make check to run in VPATH build

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoUpdate .gitignore
Zifei Tong [Tue, 6 Aug 2013 15:36:20 +0000 (11:36 -0400)] 
Update .gitignore

Signed-off-by: Zifei Tong <soariez@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoUpdate obsolete benchmark test
Zifei Tong [Tue, 6 Aug 2013 15:35:13 +0000 (11:35 -0400)] 
Update obsolete benchmark test

Update the test to use lttng-ust 2.x API and output result to TAP
format.

[ Update by Mathieu Desnoyers: README is EXTRA_DIST within Makefile.am ]

Signed-off-by: Zifei Tong <soariez@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoCleanup tests (2nd commit)
Zifei Tong [Wed, 24 Jul 2013 17:14:14 +0000 (13:14 -0400)] 
Cleanup tests (2nd commit)

Move TAP related code to tests/utils.
Remove scripts only used by obsolete tests.

[ Mathieu : my previous commit was missing some files. ]

Signed-off-by: Zifei Tong <soariez@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoCleanup tests
Zifei Tong [Wed, 24 Jul 2013 16:33:34 +0000 (12:33 -0400)] 
Cleanup tests

Move TAP related code to tests/utils.
Remove scripts only used by obsolete tests.

Signed-off-by: Zifei Tong <soariez@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: doc/examples VPATH build
Mathieu Desnoyers [Sun, 21 Jul 2013 21:42:16 +0000 (17:42 -0400)] 
Fix: doc/examples VPATH build

Fixes #577

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoVersion 2.3.0-rc1 v2.3.0-rc1
Mathieu Desnoyers [Thu, 18 Jul 2013 01:46:57 +0000 (21:46 -0400)] 
Version 2.3.0-rc1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: Unchecked asprintf/vasprintf return values
Jérémie Galarneau [Fri, 12 Jul 2013 17:09:51 +0000 (13:09 -0400)] 
Fix: Unchecked asprintf/vasprintf return values

strp·may·be·modified·even·in·case·of·failure·according·to·the
ASPRINTF(3) man page.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoMissing NULL pointer init in tap.c
Mathieu Desnoyers [Fri, 12 Jul 2013 15:41:10 +0000 (11:41 -0400)] 
Missing NULL pointer init in tap.c

Could lead to free() of unitialized pointer.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoDisable doc/examples build
Mathieu Desnoyers [Tue, 25 Jun 2013 21:40:57 +0000 (17:40 -0400)] 
Disable doc/examples build

This breaks VPATH build.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd python3 support to lttng-gen-tp
Zifei Tong [Fri, 12 Jul 2013 13:37:23 +0000 (09:37 -0400)] 
Add python3 support to lttng-gen-tp

Fixes #585

Tested-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Zifei Tong <soariez@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoBump ABI major to 5
Mathieu Desnoyers [Thu, 11 Jul 2013 19:19:12 +0000 (15:19 -0400)] 
Bump ABI major to 5

Bump major version between UST-sessiond-consumerd.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agocallsite: add "ip" context
Mathieu Desnoyers [Wed, 10 Jul 2013 13:08:07 +0000 (09:08 -0400)] 
callsite: add "ip" context

Add caller's instruction pointer context.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAllow environment variable LTTNG_HOME to override HOME
Amit Margalit [Mon, 8 Jul 2013 16:10:31 +0000 (12:10 -0400)] 
Allow environment variable LTTNG_HOME to override HOME

Patch functionality - If LTTNG_HOME environment variable exists, it is
used instead of HOME.  Reason for patch - We are trying to deploy LTTng
on a system where $HOME is on a filesystem mounted read-only, but cannot
afford to run lttng as a different user and cannot move the home
directories of users to writeable locations.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: libs order in Makefile
Julien Desfossez [Thu, 4 Jul 2013 16:01:04 +0000 (12:01 -0400)] 
Fix: libs order in Makefile

Since commit 16c96fc0224145192f803fecbdb20ec05fdaf5e2, the examples
don't build well on Ubuntu. The gcc -l argument needs to be the last
one.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: ring buffer: get_subbuf() checks should be performed on "consumed" parameter
Mathieu Desnoyers [Wed, 3 Jul 2013 22:33:37 +0000 (18:33 -0400)] 
Fix: ring buffer: get_subbuf() checks should be performed on "consumed" parameter

This triggers lots of false-positive -EAGAIN errors in flight recorder
snapshots.

Reported-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoIntroduce ustctl_write_one_packet_to_channel
Julien Desfossez [Tue, 2 Jul 2013 18:22:08 +0000 (14:22 -0400)] 
Introduce ustctl_write_one_packet_to_channel

This function allows the consumer to write at most one packet of data to
the channel, that way we can push data to the ring buffer without
risking to block on subbuffer switch.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agobuild: Fix out-of-tree build
Otavio Salvador [Tue, 2 Jul 2013 15:18:48 +0000 (11:18 -0400)] 
build: Fix out-of-tree build

To allow out-of-tree build, we need to include top_buildir in include
directories or the generated config header won't be found.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: SWITCH_FLUSH new sub-buffer checks
Mathieu Desnoyers [Mon, 1 Jul 2013 22:18:06 +0000 (18:18 -0400)] 
Fix: SWITCH_FLUSH new sub-buffer checks

The SWITCH_FLUSH, when performed on a completely empty sub-buffer, was
missing some checks (imported from space reservation).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: ring buffer: handle concurrent update in nested buffer wrap around check
Mathieu Desnoyers [Mon, 1 Jul 2013 21:10:52 +0000 (17:10 -0400)] 
Fix: ring buffer: handle concurrent update in nested buffer wrap around check

With stress-test loads that trigger sub-buffer switch very frequently
(small 4kB sub-buffers, frequent flush) in lttng-modules, we currently
observe this kind of warnings once every few minutes:

[65335.896208] ring buffer relay-overwrite-mmap, cpu 5: records were lost. Caused by:
[65335.896208]   [ 0 buffer full, 1 nest buffer wrap-around, 0 event too big ]

It appears that the check for nested buffer wrap-around does not take
into account that a concurrent execution contexts (either nested for
per-cpu buffers, or from another CPU or nested for global buffers) can
update the commit_count value concurrently.

What we really want to do with this check is to ensure that if we enter
a sub-buffer that had an unbalanced reserve/commit count, assuming there
is no hope that this gets rebalanced promptly, we detect this and drop
the current event. However, in the case where the commit counter has
been concurrently updated by another reserve or a switch, we want to
retry the entire reserve operation.

One way to detect this is to sample the reserve offset twice, around the
commit counter read, along with the appropriate memory barriers.
Therefore, we can detect if the mismatch between reserve and commit
counter is actually caused by a concurrent update, which necessarily has
updated the reserve counter.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoCleanup: lib_ring_buffer_switch_new_end() only calls subbuffer_set_data_size()
Mathieu Desnoyers [Mon, 1 Jul 2013 17:18:54 +0000 (13:18 -0400)] 
Cleanup: lib_ring_buffer_switch_new_end() only calls subbuffer_set_data_size()

lib_ring_buffer_switch_new_end() is always called when an event exactly
fills a sub-buffer, which makes padding_size always 0. However, there is
one side-effect that lib_ring_buffer_switch_new_end() needs to have: it
calls subbuffer_set_data_size() to update the size of the data to be
read from the sub-buffer.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: doc/examples: gen-tp path
Mathieu Desnoyers [Mon, 1 Jul 2013 17:06:06 +0000 (13:06 -0400)] 
Fix: doc/examples: gen-tp path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoRevert "Cleanup: ring buffer: remove lib_ring_buffer_switch_new_end()"
Mathieu Desnoyers [Sun, 30 Jun 2013 22:36:47 +0000 (18:36 -0400)] 
Revert "Cleanup: ring buffer: remove lib_ring_buffer_switch_new_end()"

This reverts commit 019fbcb65ec7eec2c86019ad1afce8fa47dc1269.

Breaks regression tests of lttng-tools.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: handle writes of length 0
Mathieu Desnoyers [Sun, 30 Jun 2013 21:45:32 +0000 (17:45 -0400)] 
Fix: handle writes of length 0

lib_ring_buffer_write() could be passed a length of 0. This typically
has no side-effect as far as writing into the buffers is concerned,
except for one detail: in overwrite mode, there is a check to make sure
the sub-buffer can be written into. This check is performed even if
length is 0. In the case where this would fall exactly at the end of a
sub-buffer, the check would fail, because the offset would fall exactly
at the beginning of the next sub-buffer.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoCleanup: ring buffer: remove lib_ring_buffer_switch_new_end()
Mathieu Desnoyers [Sun, 30 Jun 2013 19:36:52 +0000 (15:36 -0400)] 
Cleanup: ring buffer: remove lib_ring_buffer_switch_new_end()

lib_ring_buffer_switch_new_end() is a leftover from the days where an
event that would exactly fill the current sub-buffer would automatically
trigger a sub-buffer switch into the next sub-buffer.

Even before the ring buffer code has been moved into lttng-modules, this
behavior had been changed: an event that exactly fills a sub-buffer only
fills this current sub-buffer, and does not need to switch into the
next one to populate the sub-buffer header. This change had been done so
periodical timer switch, which shares the same semantic as an event
exactly filling a sub-buffer, would not create tons of empty
sub-buffers.

However, when doing this change, lib_ring_buffer_switch_new_end() has
not been removed, but clearly should have been. Its job is now performed
by the event "commit".

lib_ring_buffer_switch_new_end() has no effect, since padding_size is
always 0.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: lttng-events VPATH build
Mathieu Desnoyers [Tue, 25 Jun 2013 21:10:13 +0000 (17:10 -0400)] 
Fix: lttng-events VPATH build

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAllow #include in template (.tp) file
Yannick Brosseau [Sat, 22 Jun 2013 17:48:27 +0000 (13:48 -0400)] 
Allow #include in template (.tp) file

The #include directive won't be parsed, but will be copied to the
generated .h files.

Also add a verbose (-v) mode to display some debugging output

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agotests/hello.cxx: rename tp.cpp into tp-cpp.cpp
Mathieu Desnoyers [Fri, 21 Jun 2013 21:27:16 +0000 (17:27 -0400)] 
tests/hello.cxx: rename tp.cpp into tp-cpp.cpp

Takes care of autotools issue caused by renaming tp.c to tp.cpp. make
distclean was required when switching between old and newer versions.
It's not needed anymore.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agodoc/examples: build gen-tp example by default
Mathieu Desnoyers [Thu, 20 Jun 2013 13:38:52 +0000 (09:38 -0400)] 
doc/examples: build gen-tp example by default

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agodoc/examples: support BSD make
Mathieu Desnoyers [Thu, 20 Jun 2013 13:30:20 +0000 (09:30 -0400)] 
doc/examples: support BSD make

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoTracepoint.h: replace assertion by fprintf and abort()
Mathieu Desnoyers [Tue, 18 Jun 2013 14:07:57 +0000 (10:07 -0400)] 
Tracepoint.h: replace assertion by fprintf and abort()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoRemove unused assert.h from bitfield.h
Mathieu Desnoyers [Tue, 18 Jun 2013 14:05:29 +0000 (10:05 -0400)] 
Remove unused assert.h from bitfield.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoClarify probe registration documentation/errors
Mathieu Desnoyers [Tue, 18 Jun 2013 14:02:00 +0000 (10:02 -0400)] 
Clarify probe registration documentation/errors

Fixes #513

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: Check C++ designated initializers support before compiling 'hello.cxx' test
Zifei Tong [Tue, 18 Jun 2013 13:48:21 +0000 (09:48 -0400)] 
Fix: Check C++ designated initializers support before compiling 'hello.cxx' test

Tested on a Ububtu system with g++ 4.6, g++ 4.7 and clang++.

Fixes #557

Signed-off-by: Zifei Tong <soariez@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoAdd mising include in ust.h
Mathieu Desnoyers [Tue, 18 Jun 2013 01:00:03 +0000 (21:00 -0400)] 
Add mising include in ust.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agolttng-gen-tp: Fix include guard name with file using non valid characters
Yannick Brosseau [Mon, 17 Jun 2013 16:07:11 +0000 (12:07 -0400)] 
lttng-gen-tp: Fix include guard name with file using non valid characters

Now, the include guard will be generated with all the non
alpha-numeric characters replace with an '_'

Fixes #511

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: segfault when print invalid command
Mathieu Desnoyers [Mon, 17 Jun 2013 15:19:22 +0000 (11:19 -0400)] 
Fix: segfault when print invalid command

Fixes #556

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: Add --no-as-needed to the demo example's Makefile
Jérémie Galarneau [Fri, 14 Jun 2013 21:33:47 +0000 (17:33 -0400)] 
Fix: Add --no-as-needed to the demo example's Makefile

Some distributions now ship with the --as-needed linker flag
set by default (Ubuntu 13.04). This will cause the linker to
remove the references to lttng-ust from the provider objects
thus causing the application to fail when preloading them.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agozmalloc: attribute always_inline
Mathieu Desnoyers [Fri, 14 Jun 2013 15:55:08 +0000 (11:55 -0400)] 
zmalloc: attribute always_inline

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoFix: liblttng-ust process startup hang when sessiond is stopped
Mathieu Desnoyers [Thu, 30 May 2013 13:49:05 +0000 (09:49 -0400)] 
Fix: liblttng-ust process startup hang when sessiond is stopped

Ensure the listener thread owns socket and notify_socket, so they don't
have to hold the ust_lock() while connecting to the sessiond and reading
from this socket.

Therefore, after process fork, we can safely cleanup those retources,
because the thread has been removed by the operating system. On exit,
however, let the OS teardown those sockets, so exit path does not race
with the listener thread.

Fixes #545

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
11 years agoMove include directive from CFLAGS to LOCAL_CPPFLAGS in examples' Makefiles
Jérémie Galarneau [Thu, 30 May 2013 14:32:12 +0000 (10:32 -0400)] 
Move include directive from CFLAGS to LOCAL_CPPFLAGS in examples' Makefiles

The use of LOCAL_* flags and override directives ensures that the build
succeeds even if the user explicitly overrides CFLAGS/CPPFLAGS/LDFLAGS.

Fixes #537

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.042727 seconds and 4 git commands to generate.