lttng-tools.git
9 years agoFix: Handle empty daemon configuration file lines
Jérémie Galarneau [Sun, 23 Nov 2014 16:30:33 +0000 (11:30 -0500)] 
Fix: Handle empty daemon configuration file lines

Empty daemon configuration file lines such as
my_option=

will cause set_option to be called with an arg value of length 0
which should display a warning.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: missing strdup oom check in lttng create.c
Mathieu Desnoyers [Wed, 26 Nov 2014 17:27:29 +0000 (12:27 -0500)] 
Fix: missing strdup oom check in lttng create.c

Introduce tmp_path to ensure that no code path can possibly try to free
the return value of utils_get_home_dir(). Re-using alloc_path for both
static and dynamically allocated pointer is error-prone.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: lttng add_context.c: use zmalloc
Mathieu Desnoyers [Wed, 26 Nov 2014 17:25:55 +0000 (12:25 -0500)] 
Fix: lttng add_context.c: use zmalloc

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: add missing str*dup oom check in sessiond main.c
Mathieu Desnoyers [Wed, 26 Nov 2014 17:18:07 +0000 (12:18 -0500)] 
Fix: add missing str*dup oom check in sessiond main.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: add missing sessiond kernel-consumer missing str*dup oom checks
Mathieu Desnoyers [Wed, 26 Nov 2014 17:17:26 +0000 (12:17 -0500)] 
Fix: add missing sessiond kernel-consumer missing str*dup oom checks

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: add missing strdup OOM check
Mathieu Desnoyers [Wed, 26 Nov 2014 17:16:19 +0000 (12:16 -0500)] 
Fix: add missing strdup OOM check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix: Live tracing does not honor live timer after first tracefile with tracefile...
Mathieu Desnoyers [Fri, 21 Nov 2014 17:31:39 +0000 (18:31 +0100)] 
Fix: Live tracing does not honor live timer after first tracefile with tracefile rotation

When we pass to the 2nd sub-file (or following sub-files) of a stream in
relayd, the live timer has no visible effect from a live reader
perspective, and then everything is flushed when we reach the following
sub-file.

This is caused by the reset of stream->total_index_received after each
tracefile rotation. It should keep on incrementing to match what is
expected by check in check_index_status():

  (rstream->total_index_received <= vstream->last_sent_index)

Fixes #863

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoDocs: Add -f/--config option to lttng-sessiond man page
Jérémie Galarneau [Sun, 23 Nov 2014 15:37:06 +0000 (10:37 -0500)] 
Docs: Add -f/--config option to lttng-sessiond man page

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
src/bin/lttng-sessiond/main.c

9 years agoFix: relayd: unbalanced RCU read-side lock/unlock
Mathieu Desnoyers [Fri, 21 Nov 2014 17:38:37 +0000 (18:38 +0100)] 
Fix: relayd: unbalanced RCU read-side lock/unlock

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: relayd: unbalanced RCU read lock/unlock
Mathieu Desnoyers [Fri, 21 Nov 2014 17:42:05 +0000 (18:42 +0100)] 
Fix: relayd: unbalanced RCU read lock/unlock

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: lttng-relayd: unhandled out of memory error
Mathieu Desnoyers [Fri, 21 Nov 2014 17:47:52 +0000 (18:47 +0100)] 
Fix: lttng-relayd: unhandled out of memory error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
9 years agoFix: relayd viewer stream: unhandled out of memory error
Mathieu Desnoyers [Fri, 21 Nov 2014 17:49:08 +0000 (18:49 +0100)] 
Fix: relayd viewer stream: unhandled out of memory error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: Missing rcu_read_lock in cmd_list_channels()
Jérémie Galarneau [Tue, 18 Nov 2014 19:19:43 +0000 (14:19 -0500)] 
Fix: Missing rcu_read_lock in cmd_list_channels()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: Missing rcu_read_lock in cmd_snapshot_list_outputs()
Jérémie Galarneau [Tue, 18 Nov 2014 19:10:14 +0000 (14:10 -0500)] 
Fix: Missing rcu_read_lock in cmd_snapshot_list_outputs()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: Missing rcu_read_lock in ust_app_get_nb_stream()
Jérémie Galarneau [Tue, 18 Nov 2014 18:37:29 +0000 (13:37 -0500)] 
Fix: Missing rcu_read_lock in ust_app_get_nb_stream()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: UST subbuffers silently dropped on moderate trace traffic
Mathieu Desnoyers [Tue, 18 Nov 2014 16:33:23 +0000 (17:33 +0100)] 
Fix: UST subbuffers silently dropped on moderate trace traffic

Well, it looks like we really screwed up on this one.

lttng-tools commit 02b3d1769d5f8a33e4109b1e681141c9295dfda6 introduced
an important regression for lttng-ust tracing in the consumer daemon:
after reading a sub-buffer, a check has been added to see whether there
are more sub-buffers available to read, and if it is the case, it
ensures the wakeup pipe will be awakened again.

The issue lies in the use of ustctl_put_next_subbuf() in this check.
This acts as if the sub-buffer has been read, when in reality it has not
been read. It therefore trashes the data contained by this sub-buffer.

This check should use ustctl_put_subbuf(), which does not move the
consumer position.

This is a severe bug, and the fix needs to be applied to stable-2.6,
stable-2.5, and stable-2.4.

Fixes #861

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: Missing rcu_read_lock in get_session_max_subbuf_size()
Jérémie Galarneau [Tue, 18 Nov 2014 14:35:48 +0000 (09:35 -0500)] 
Fix: Missing rcu_read_lock in get_session_max_subbuf_size()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: create/destroy a splice_pipe per stream
Julien Desfossez [Wed, 12 Nov 2014 23:36:17 +0000 (18:36 -0500)] 
Fix: create/destroy a splice_pipe per stream

We had a per-thread splice_pipe (one for data and one for metadata), but
in case of error, we would end up filling the write side of the pipe and
never emptying it. This could lead to leaking data from one session to
the other, but also to stall the consumer trying to splice into a full
pipe.

Now we create a splice_pipe per-stream, so it is destroyed when the
session is destroyed.

Fixes: #726
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: return EINVAL if agent registration fails
David Goulet [Tue, 7 Oct 2014 19:05:48 +0000 (15:05 -0400)] 
Fix: return EINVAL if agent registration fails

The errno value might be 0 thus not returning an error if so. It has
been seen with an unstable python agent code base which means it could
happen in the future if a third part decides to create an agent.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoNote find_ust_app_context must be called with RCU read lock
Jérémie Galarneau [Wed, 12 Nov 2014 20:19:49 +0000 (15:19 -0500)] 
Note find_ust_app_context must be called with RCU read lock

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: check userspace perf counter name when looking up contexts
Jérémie Galarneau [Thu, 6 Nov 2014 22:34:08 +0000 (17:34 -0500)] 
Fix: check userspace perf counter name when looking up contexts

create_ust_app_channel_context() looks for a context's existance
in a channel before adding it. However, it only checks for
context types. This is valid for all context types except for
LTTNG_UST_CONTEXT_PERF_THREAD_COUNTER since multiple perf
thread counters may be enabled at the same time.

This fix ensures that the perf counter name is taken into
consideration when checking for a context's presence in a
channel.

Reported-by: Alexander Grigoriev <alexgri@tbricks.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: empty indexes_ht before destroying it.
Julien Desfossez [Tue, 11 Nov 2014 20:57:48 +0000 (15:57 -0500)] 
Fix: empty indexes_ht before destroying it.

Fixes: #722
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: removed useless key from relay_index
Julien Desfossez [Tue, 11 Nov 2014 20:57:47 +0000 (15:57 -0500)] 
Fix: removed useless key from relay_index

This field was never used except in debug messages (instead of using the
good value that is part of index_n).

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: filter bytecode and string memory leak on error
Mathieu Desnoyers [Thu, 13 Nov 2014 22:18:16 +0000 (17:18 -0500)] 
Fix: filter bytecode and string memory leak on error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: HT must not be destroyed with a rcu_read_lock held
Jérémie Galarneau [Sat, 15 Nov 2014 04:38:36 +0000 (23:38 -0500)] 
Fix: HT must not be destroyed with a rcu_read_lock held

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: missing rcu_read_lock in cmd_start_trace()
Jérémie Galarneau [Thu, 13 Nov 2014 21:09:57 +0000 (16:09 -0500)] 
Fix: missing rcu_read_lock in cmd_start_trace()

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: filter attach vs event enable race
Mathieu Desnoyers [Wed, 12 Nov 2014 23:18:32 +0000 (18:18 -0500)] 
Fix: filter attach vs event enable race

In order to correctly handle the use-case where events are enabled
_after_ trace is started, and _after_ applications are already being
traced, the event should be created in a "disabled" state, so that it
does not trace events until its filter is attached.

This fix needs to be done both in lttng-tools and lttng-ust. In order to
keep ABI compatibility between tools and ust within a stable release
cycle, we introduce a new "disabled" within struct lttng_ust_event
padding (previously zeroed). Newer LTTng-UST checks this flag, and
fallback on the old racy behavior (enabling the event on creation) if it
is unset.

Therefore, old session daemon works with newer lttng-ust of the same
stable release, and vice-versa. However, building lttng-tools requires
an upgraded lttng-ust, which contains the communication protocol with
the new "disabled" field.

This patch should be backported to stable-2.4, stable-2.5, stable-2.6
branches.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoBuild fix: use ret directly in error handling path
Jérémie Galarneau [Mon, 10 Nov 2014 22:35:26 +0000 (17:35 -0500)] 
Build fix: use ret directly in error handling path

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: Warn the user when enabling an event in a new domain
Christian Babeux [Fri, 7 Nov 2014 23:18:43 +0000 (18:18 -0500)] 
Fix: Warn the user when enabling an event in a new domain

This patch warn the user when trying to enable an event in a new domain
that was not configured prior to the tracing start.

Fixes #826

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: Don't report an error when listing a session with no channels
Jérémie Galarneau [Fri, 7 Nov 2014 23:07:07 +0000 (18:07 -0500)] 
Fix: Don't report an error when listing a session with no channels

The LTTng sessiond daemon reports an error when the list_channel
command is invoked on a session which only has a metadata channel.

The error lies in assuming that a session which has an enabled
domains also has (user-visible) channels.

The metadata channel should be listed in a future fix.

Fixes #855

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
src/bin/lttng/commands/list.c

10 years agoFix: Add missing URCU_TLS access to error_log_time
Christian Babeux [Fri, 7 Nov 2014 17:17:02 +0000 (12:17 -0500)] 
Fix: Add missing URCU_TLS access to error_log_time

Fixes #849

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoUpdate version to v2.5.2 v2.5.2
Jérémie Galarneau [Thu, 6 Nov 2014 01:19:05 +0000 (20:19 -0500)] 
Update version to v2.5.2

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoUpdate maintainer section of the man pages
Jérémie Galarneau [Wed, 5 Nov 2014 22:34:14 +0000 (17:34 -0500)] 
Update maintainer section of the man pages

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoUpdate maintainer section of README
Jérémie Galarneau [Wed, 5 Nov 2014 20:53:22 +0000 (15:53 -0500)] 
Update maintainer section of README

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: add README to documentation files
Jérémie Galarneau [Tue, 4 Nov 2014 22:59:29 +0000 (17:59 -0500)] 
Fix: add README to documentation files

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
10 years agoFix: UST consumer sync all available metadata
David Goulet [Fri, 31 Oct 2014 17:23:29 +0000 (13:23 -0400)] 
Fix: UST consumer sync all available metadata

In live mode, the sync metadata function was only working on one single
metadata stream of a given session ID. However, we can have multiple
metadata stream for the same session ID thus failing to send the data in
live mode correctly for the other streams.

This fixes it by simply iterating over all metadata stream for a session
ID and syncing them all.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoUpdate version to v2.5.1 v2.5.1
David Goulet [Mon, 20 Oct 2014 19:47:39 +0000 (15:47 -0400)] 
Update version to v2.5.1

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: handle sysconf possible negative returned value
David Goulet [Wed, 1 Oct 2014 18:57:36 +0000 (14:57 -0400)] 
Fix: handle sysconf possible negative returned value

Fixes Coverity issue 1019947.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: channel deref. after NULL check in kernel consumer
David Goulet [Wed, 1 Oct 2014 18:52:33 +0000 (14:52 -0400)] 
Fix: channel deref. after NULL check in kernel consumer

Fixes Coverity issue 1040158.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: check for kernel session metadata during init
David Goulet [Wed, 1 Oct 2014 18:49:42 +0000 (14:49 -0400)] 
Fix: check for kernel session metadata during init

Fixes Coverity issue 1040159.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: incorrect cast in ust consumer assert
David Goulet [Wed, 1 Oct 2014 18:32:12 +0000 (14:32 -0400)] 
Fix: incorrect cast in ust consumer assert

Fixes Coverity issue 1068813.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: bad handling of incoming data in consumer thread
David Goulet [Wed, 1 Oct 2014 18:16:07 +0000 (14:16 -0400)] 
Fix: bad handling of incoming data in consumer thread

This will fix Coverity issue 1019892.

The issue uncovered a more serious problem. The loop on ready FDs of the
thread was exiting at each branch thus not going on all fd. This is
problematic when the thread quit pipe is triggered and when there is
also at the same time a request for metadata from the consumer since the
metadata request could have been ignored.

This patch makes sure we go through all FDs in the loop when the thread
quit pipe or the metadata fd is triggered.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: disable event for JUL domain
David Goulet [Fri, 5 Sep 2014 19:17:31 +0000 (15:17 -0400)] 
Fix: disable event for JUL domain

Could not be backported from master. Ref. commit is
0dcfcf94b356c12e3936fa27f350896d96724e4e

This fixes the disable event for JUL that was not working and fixes the
buggy test.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: send disable ALL command code if event is *
David Goulet [Fri, 5 Sep 2014 16:12:38 +0000 (12:12 -0400)] 
Fix: send disable ALL command code if event is *

$ lttng disable-event -a
and
$ lttng disable-event '*'

Both commands should do the same meaning send the DISABLE_EVENT_ALL
command to the session daemon.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: make sure no index is in flight before using inactivity beacons
Julien Desfossez [Wed, 27 Aug 2014 17:59:21 +0000 (13:59 -0400)] 
Fix: make sure no index is in flight before using inactivity beacons

Since the index is sent in two parts on two separate connections from
the consumer, there can be cases where we receive an inactivity beacon
between the index creation and the data reception.

This fix prevents from using the inactivity beacon if we know a data
index is coming.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Parenthesize previous statement when adding conditions to a filter
Jérémie Galarneau [Thu, 28 Aug 2014 16:53:43 +0000 (12:53 -0400)] 
Fix: Parenthesize previous statement when adding conditions to a filter

Not parenthesizing the clauses in a filter string causes JUL events to be
traced even though they are not enabled when an enable-event command is
issued with a filter and the --loglevel-only option.

For instance,

lttng enable-event -j "my_event" --loglevel-only JUL_CONFIG -f "int_loglevel > 0 || int_loglevel < 0"

results in the following filter being applied:

int_loglevel > 0 || int_loglevel < 0 && logger_name == "my_event" && int_loglevel == 700

The resulting expression will always evaluate to true, regardless of the logger
name.

This fix parenthesizes each clause to ensure they are all independently
evaluated and not unintuitively affected by operator precedence.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: parse_prob_opts return the actual success of the function
Jonathan Rajotte Julien [Wed, 27 Aug 2014 19:46:57 +0000 (15:46 -0400)] 
Fix: parse_prob_opts return the actual success of the function

This bug have been triggered by the mi merging and the use of a
command_ret in enable_events functions. Previously, enable_events was
reusing the ret variable for another operation and always replacing ret.
Parse_probe_event returned the last output of sscanf which represent
the number of match and not the success of the operation.

Fixes #830

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Man page typos
Jérémie Galarneau [Thu, 14 Aug 2014 20:17:22 +0000 (16:17 -0400)] 
Fix: Man page typos

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: disable JUL event on destroy
David Goulet [Tue, 29 Jul 2014 18:11:48 +0000 (14:11 -0400)] 
Fix: disable JUL event on destroy

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: unbalanced ustconsumer32_data.pid_mutex lock
Mathieu Desnoyers [Mon, 28 Jul 2014 00:38:50 +0000 (20:38 -0400)] 
Fix: unbalanced ustconsumer32_data.pid_mutex lock

It is never locked in this function, but should be. This is triggering
spurious runtime failures on my system, where it seems that sessiond was
sometimes breaking the communication pipe with liblttng-ctl when the
unbalanced unlock is reached.

This should be backported to stable-2.4 and stable-2.5.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoUpdate version to v2.5.0 v2.5.0
David Goulet [Wed, 16 Jul 2014 20:06:20 +0000 (16:06 -0400)] 
Update version to v2.5.0

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: validate file path creds in autoload mode
David Goulet [Wed, 16 Jul 2014 19:50:31 +0000 (15:50 -0400)] 
Fix: validate file path creds in autoload mode

Validate the credentials only when in auto load mode for the auto/
directory. The lttng load command now checks the session file creds and
validate if it's readable before trying to do so.

Thus with this, a user can load a session from the system wide directory
as long as she/he has the rights to read it.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: change session file loading order
David Goulet [Wed, 16 Jul 2014 18:02:56 +0000 (14:02 -0400)] 
Fix: change session file loading order

Libconfig now tries to load a session file from the user directory
followed by the system wide. A user session file should always
supersedes the system wide.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add Loading Sessions section to lttng-sessiond.8
David Goulet [Wed, 16 Jul 2014 17:06:17 +0000 (13:06 -0400)] 
Fix: add Loading Sessions section to lttng-sessiond.8

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add default session conf. dir to manpage
David Goulet [Wed, 16 Jul 2014 16:52:08 +0000 (12:52 -0400)] 
Fix: add default session conf. dir to manpage

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: on session load, add it to the .lttngrc
David Goulet [Tue, 15 Jul 2014 18:28:38 +0000 (14:28 -0400)] 
Fix: on session load, add it to the .lttngrc

Fixes #818

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: clarify session conf. directory in man
David Goulet [Tue, 15 Jul 2014 18:21:56 +0000 (14:21 -0400)] 
Fix: clarify session conf. directory in man

Fixes #817

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: filter error path could free invalid ptr
David Goulet [Tue, 15 Jul 2014 13:16:54 +0000 (09:16 -0400)] 
Fix: filter error path could free invalid ptr

Also add a check for a NULL pointer when freeing the filter bytecode so
we don't deref an invalid ptr.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Create a lock file to prevent multiple session daemons
Jérémie Galarneau [Mon, 14 Jul 2014 18:57:10 +0000 (14:57 -0400)] 
Fix: Create a lock file to prevent multiple session daemons

A lock file is used to ensure that only one session daemon per UID is
running on the system. The lock file is created in the rundir.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: relayd stream set close_flag on stream close
David Goulet [Mon, 14 Jul 2014 20:37:05 +0000 (16:37 -0400)] 
Fix: relayd stream set close_flag on stream close

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: ustctl_get_stream_id without UST support
David Goulet [Mon, 14 Jul 2014 19:49:02 +0000 (15:49 -0400)] 
Fix: ustctl_get_stream_id without UST support

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: avoid freeing invalid ptr in filter bytecode
David Goulet [Mon, 14 Jul 2014 18:32:10 +0000 (14:32 -0400)] 
Fix: avoid freeing invalid ptr in filter bytecode

Reported-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: get the stream_id when generating live beacons
Julien Desfossez [Mon, 14 Jul 2014 18:05:48 +0000 (14:05 -0400)] 
Fix: get the stream_id when generating live beacons

When we send an empty index (beacon), we need to extract the stream_id
to avoid stalling the client on inactive streams on startup.
Since the live clients need to know this feature is implemented, we had
to bump the lttng-live protocol version.

This fix should be backported to stable-2.4 as well.

Refs: #811

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
10 years agoFix: use biggest subbuffer size for snapshot max-size
David Goulet [Wed, 9 Jul 2014 19:24:04 +0000 (15:24 -0400)] 
Fix: use biggest subbuffer size for snapshot max-size

Instead of using the output max size divided by the total amount of
streams in the session, we find the largest subbuffer in the session's
channels. Using that value, we multiply it by the total amount of
streams which gives us the lower limit of the snapshot size. That is
enough to make sure that we can take the snapshot or not.

Once done, the max stream size possible used for the snapshot record is
the largest subbuffer size in the session. This is to make sure that
every channel can extract the same amount of data which ensure fairness
between each channel in the session.

Fixes #783

Acked-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Possible memory leak when multiple config files are loaded
Jérémie Galarneau [Fri, 11 Jul 2014 19:22:18 +0000 (15:22 -0400)] 
Fix: Possible memory leak when multiple config files are loaded

Some configuration options could leak when initialized multiple times
from different configuration files and from the command line arguments.
The previous options are now freed' before being set.

Fixes #796

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Clamp verbosity value read from config file
Jérémie Galarneau [Thu, 10 Jul 2014 21:41:08 +0000 (17:41 -0400)] 
Fix: Clamp verbosity value read from config file

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Unchecked strdup return values in set_option
Jérémie Galarneau [Thu, 10 Jul 2014 21:04:19 +0000 (17:04 -0400)] 
Fix: Unchecked strdup return values in set_option

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoUpdate version to v2.5.0-rc2
David Goulet [Fri, 27 Jun 2014 14:38:10 +0000 (10:38 -0400)] 
Update version to v2.5.0-rc2

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoTest: add JUL disable event tests
David Goulet [Wed, 18 Jun 2014 13:11:19 +0000 (09:11 -0400)] 
Test: add JUL disable event tests

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: disable JUL event on UST side
David Goulet [Tue, 17 Jun 2014 19:42:39 +0000 (15:42 -0400)] 
Fix: disable JUL event on UST side

With the new root logger patch in liblttng-ust-jul, we have to disable
the JUL logger on the UST tracer side for the multi session support.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add test UST perf to extra dist
David Goulet [Fri, 27 Jun 2014 14:18:48 +0000 (10:18 -0400)] 
Fix: add test UST perf to extra dist

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add a get HOME dir fallback to getpwuid
David Goulet [Thu, 10 Jul 2014 20:02:02 +0000 (16:02 -0400)] 
Fix: add a get HOME dir fallback to getpwuid

If the $HOME or $LTTNG_HOME is not defined, fallback on getpwuid(3) of
the process uid.

Fixes #815

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: signedness of the session live timer
David Goulet [Thu, 10 Jul 2014 19:45:02 +0000 (15:45 -0400)] 
Fix: signedness of the session live timer

Fixes #806

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: logger name dropped from filter condition when loglevels are used
Jérémie Galarneau [Thu, 10 Jul 2014 18:24:59 +0000 (14:24 -0400)] 
Fix: logger name dropped from filter condition when loglevels are used

This fix ensures that the loglevel expression is appended to the filter
expression and does not overwrite the current one.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: refactor function that fixes memory leak also
David Goulet [Thu, 10 Jul 2014 17:04:24 +0000 (13:04 -0400)] 
Fix: refactor function that fixes memory leak also

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: memory leak in lttng_enable_event_with_exclusions
Jérémie Galarneau [Wed, 9 Jul 2014 22:20:03 +0000 (18:20 -0400)] 
Fix: memory leak in lttng_enable_event_with_exclusions

lttng_enable_event_with_exclusions leaks a filter expression when
automatically generated filter statements are used. This happens when
loglevel and logger name filtering are used when enabling JUL events.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: check malloc return value
Jérémie Galarneau [Fri, 4 Jul 2014 19:33:49 +0000 (15:33 -0400)] 
Fix: check malloc return value

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: static array larger than necessary
Jérémie Galarneau [Fri, 4 Jul 2014 19:28:42 +0000 (15:28 -0400)] 
Fix: static array larger than necessary

The longest string that can be returned should be 20 chars long, as per
the comment.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add missing URCU_TLS to logging time variable
Martin Townsend [Wed, 9 Jul 2014 20:46:54 +0000 (16:46 -0400)] 
Fix: add missing URCU_TLS to logging time variable

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: auto load session in the auto/ directory
David Goulet [Thu, 26 Jun 2014 19:41:42 +0000 (15:41 -0400)] 
Fix: auto load session in the auto/ directory

The session daemon will now automatically load sessions from the auto/
directory in the session config path. Both system config path and home
config path are used. The session is only loaded if the UID of the
session file matches the UID of the session daemon (or root).

For that, a autoload parameter has been added to the
config_load_session() function to indicate that we want to auto load
sessions.

Fixes #812

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: accept override flag even without a load path
David Goulet [Thu, 26 Jun 2014 17:56:13 +0000 (13:56 -0400)] 
Fix: accept override flag even without a load path

Part of the bug #807 have been fixed also by the previous commit.

Fixes #807

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: bad error code path when loading session
David Goulet [Thu, 26 Jun 2014 17:32:39 +0000 (13:32 -0400)] 
Fix: bad error code path when loading session

Fixes #810

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: set session in output mode if URL are set afterwards
David Goulet [Wed, 25 Jun 2014 20:35:54 +0000 (16:35 -0400)] 
Fix: set session in output mode if URL are set afterwards

Fixes #809

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add a kernel context list to the channel
David Goulet [Wed, 25 Jun 2014 19:42:15 +0000 (15:42 -0400)] 
Fix: add a kernel context list to the channel

The internal state of the session daemon was recording only one context
per channel thus overwriting the previous one if multiple context were
added causing a memory leak.

This commit adds a list inside a kernel channel which keeps track of all
context added. It also fixes the save command that now saves all of
them.

Fixes #205

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Add vpid, vppid and vtid info in add-context help
Francis Deslauriers [Thu, 19 Jun 2014 02:19:40 +0000 (22:19 -0400)] 
Fix: Add vpid, vppid and vtid info in add-context help

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: wrong behavior of save command when no session name is provided
Jonathan Rajotte Julien [Tue, 17 Jun 2014 19:59:41 +0000 (15:59 -0400)] 
Fix: wrong behavior of save command when no session name is provided

No session name and no option --all should default to --all.

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: missing context type string in save for ust context
Jonathan Rajotte Julien [Mon, 9 Jun 2014 19:45:39 +0000 (15:45 -0400)] 
Fix: missing context type string in save for ust context

Return string for LTTNG_UST_CONTEXT_PERF_THREAD_COUNTER was missing and
caused an error on save when a context of PERF_THREAD_COUNTER type was
present (Error: Invalid parameter).

Fixes #804

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: wrong casting of return value
Jonathan Rajotte Julien [Mon, 9 Jun 2014 15:40:36 +0000 (11:40 -0400)] 
Fix: wrong casting of return value

The function uri_parse_str_urls return a ssize_t and the return was
casted to a size_t. This caused the following error checking to fail as
-1 was interpreted as 18446744073709551615.

Fixes #803

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add dependency to libcommon for python binding
Paul Woegerer [Thu, 5 Jun 2014 10:39:48 +0000 (12:39 +0200)] 
Fix: add dependency to libcommon for python binding

This patch adds the missing dependency to libcommon that contains the
definition of log_add_time.

Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: remove the default GIT_VERSION
Raphaël Beamonte [Tue, 3 Jun 2014 18:30:09 +0000 (14:30 -0400)] 
Fix: remove the default GIT_VERSION

This is to allow different version control other than git.

Tested-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoUpdate version to v2.5.0-rc1 v2.5.0-rc1
David Goulet [Wed, 28 May 2014 15:21:36 +0000 (11:21 -0400)] 
Update version to v2.5.0-rc1

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAdd missing test files to EXTRA_DIST
David Goulet [Wed, 28 May 2014 15:04:09 +0000 (11:04 -0400)] 
Add missing test files to EXTRA_DIST

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAdd hidden attribute to some common functions
David Goulet [Wed, 28 May 2014 14:56:12 +0000 (10:56 -0400)] 
Add hidden attribute to some common functions

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAdd the load session API call
David Goulet [Wed, 28 May 2014 14:52:16 +0000 (10:52 -0400)] 
Add the load session API call

Introduce lttng_load_session(attr) and some setter/getter for the
attribute object.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: alignment problems on targets not supporting unaligned access.
Fredrik Markström [Fri, 16 May 2014 01:10:07 +0000 (09:10 +0800)] 
Fix: alignment problems on targets not supporting unaligned access.

Accessing floats, doubles and 64 bit int at unaligned addresses is not
supported on all configurations of arm processors and if it is it's
emulated and slow. This patch replaces direct assignments with memcpy.

Signed-off-by: Fredrik Markström <fredrik.markstrom@gmail.com>
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAdd gen-ust-tracef binary to gitignore
David Goulet [Tue, 27 May 2014 20:34:01 +0000 (16:34 -0400)] 
Add gen-ust-tracef binary to gitignore

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoImplement test_event_tracef
Mathieu Desnoyers [Tue, 27 May 2014 20:25:26 +0000 (16:25 -0400)] 
Implement test_event_tracef

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoImplement tracef test application "gen-ust-tracef"
Mathieu Desnoyers [Tue, 27 May 2014 20:25:25 +0000 (16:25 -0400)] 
Implement tracef test application "gen-ust-tracef"

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: out of tree build
David Goulet [Tue, 27 May 2014 14:55:42 +0000 (10:55 -0400)] 
Fix: out of tree build

Reported-by: Daniel Olivier <daniel.olivier@ericsson.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoList session event loglevel for the JUL domain
David Goulet [Mon, 26 May 2014 18:52:58 +0000 (14:52 -0400)] 
List session event loglevel for the JUL domain

Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.042631 seconds and 4 git commands to generate.