Use bsd-compatible fcntl for close-on-exec on socket

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix multi-session wildcard support

Incorrectly unset loglevel information upon creation of wildcard_entry
was causing a second session with wildcard enabled to not record its
events.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix event lost count when buffer is full

The tracing channels should count lost events due to buffer full, and
the metadata channel should not (see comment), but not the opposite.
This was a mixup between the two.

Reported-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove inappropriate \n from easy-ust sample

Although \n is permitted in strings, it adds newlines in the trace
pretty-printer output, which is not that nice.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update version to 2.0.0 stable

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

make dist: Generate bzip2 instead of gzip

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update version to 2.0.0-rc4

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix out-of-bound write in ltt-events.c

Valgrind complains that the size allocated is too small for the memcpy,
rightly so (off by one).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Document LTTNG_UST_DEBUG_VALGRIND compilation flag

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update COPYING

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add exception handling to lttng-gen-tp io operations

(closes: 54)

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update version to 2.0.0-rc3

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: sendmsg should retry on EINTR, and use MSG_NOSIGNAL

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: ustcomm_close_unix_sock should close, not shutdown

.. and ensure that we actually use the API rather than doing the close()
directly in the caller.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: do not print EPIPE perror, as it is an expected error

It is perfectly valid for the other end to close its socket, so do not
report broken pipe errors as perror.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Ensure that multiplication of clock offset is done on 64-bit

This is not a bug in UST per se, because we happen to force
multiplication by a ULL number, but force cast to uint64_t anyway to
ensure we don't trigger this overflow if the constant ever happen to
change.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add 2 missing licenses in deprecated tests

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unbuild and unused (deprecated) make_shared_lib test

Was for UST 0.x.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

License text standardization, add missing licenses

- Use MIT/X11 text for BSD-style license.
- Fix FSF address.
- Use appropriate LTTNG_ prefix for ifndef (rather than LINUX).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove duplicate check for 0 num_subbuf and subbuf_size

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: power of 2 size check should apply to size_t type, not uint32_t

Fix this by using the much simpler x & (x - 1) check (rather than
hweight(x) == 1).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: recvmsg should handle EINTR

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Make lttng-gen-tp work on python 2.6

(refs #114)

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Make lttng-gen-tp executable

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update version to 2.0.0-rc2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Manpage fixes

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: dmesg printout should not print metadata warnings

Metadata channel retry when an event is dropped by the underlying
buffer. We should not print a message showing that the event has been
dropped to the user on debug console.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use transport name as channel name

Clarify lost event printout.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Add signature check in tracepoint activation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add tracepoint signature at tracepoint definition site

Will enable type-checking between call site and handler.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: keep event probe signature, for use by event probe signature check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix ABI: add padding to structures shared between UST and consumer

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix ABI: add padding to tracepoint and ring buffer config public structures

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix ABI: Adding missing padding in tracepoint event structures

Add padding for future extensions.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Add include/lttng/ust-config.h to git ignore

(fixes #95)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix effect: update README about dlopen()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: fixup vtid TLS

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Conflicts:

liblttng-ust/lttng-context-vtid.c

Fix: fixup ringbuffer tls at constructor by forcing read

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Conflicts:

liblttng-ust/lttng-ust-comm.c
libringbuffer/ring_buffer_frontend.c

Fix: fix deadlock with dlopen() lttng-ust

Pre-"fault" the libuuid TLS outside of the ust lock to ensure that we
never deadlock with the linker mutex in libc. This mutex is held both
for TLS fixup of dlopen'd libs, and across execution of all
constructors. We therefore have a reverse use of this mutex wrt ust
lock, that we fix by forcing the TLS fixup to happen very early in the
lttng-ust constructor.

[fixed merge from dev branch]

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: only print event errors every 1048576 hits

Never spam the console, even in debug mode, since it would make debug
information very much useless.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing debug printout to identify the cause of lost events

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: liblttng-ust-ctl should check for incorrect parameters

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: ust comm error handling segfault

On comm errors, UST should not try to populate fields from NULL
pointers.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Add FreeBSD compat layer for endian.h"

This reverts commit 8740da0a30986094ebf03a0f3b7448844d5e886f.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "fls: use local namespace to do not clash with FreeBSD string.h"

This reverts commit 6b95cebfaaf9f6ee862fc790d5a128769dc573bf.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Fix freebsd endian support"

This reverts commit 020760b19e351bda940b38ca273f32206ab4d03f.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Add get proc name wrapper for FreeBSD"

This reverts commit 48621a4272bdeb1e8fced511ca6bf3c4c2240c15.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Add freebsd support for getcpu (use cpu nr 0)"

This reverts commit dbafbbf5527d2e291b216216fd2c5b7dc4df66ed.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "snprintf: fix namespace of snprintf types for freebsd"

This reverts commit 18d0b33ab9884b3f7bac0dd918993dc05a7c43fd.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Compat layer for gettid"

This reverts commit 36e2ba2a19ec6698ed8dfb8c9bde683368334372.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Use XSI-compliant strerror_r by default on non-Linux"

This reverts commit 7705281be801c16b35349f9ab17f67419cac1c34.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Use ENOMSG as fallback for ENODATA on freebsd"

This reverts commit e5757a9047b04cb2fb94d9dfdf7153e963eafa95.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Use bsd-compatible fcntl for close-on-exec on socket"

This reverts commit 4171df999bf0c0c552fa35cea9a12fa4d82faae6.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "configure.ac: check for both libuuid/libc uuid APIs"

This reverts commit eade58d0cba1a300e37a4b1fd4b2588f134d08c9.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Create libuuid/libc uuid wrapper"

This reverts commit 67107619135ff344f0de2783ec2d48e558deaf9a.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Rename uuid.h wrapper to lttng-ust-uuid.h"

This reverts commit f194f3b00d042154c35f1f9ec262e25f2cd83b8a.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "uuid.h should only be included when libuuid is detected"

This reverts commit ce32a22799df2d99926df4563e3a52059e3e180a.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Add freebsd rfork support"

This reverts commit 16295480956eae5c1c3a83546353143bef1885ba.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Cast uuid_create parameter"

This reverts commit f1a74d692e1469c197fba0ce5c7519da222cfaf2.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Update uuid_create type cast"

This reverts commit a58a54609106b5dc7f9cb0ff5514de8b175e4b01.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Remove useless const qualifier"

This reverts commit 277d6e1d016e69184fd49b867ff1268d3ff668f5.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Detect and document dependency on -ldl on Linux, -lc on BSD for dlopen"

This reverts commit 90cefaa31af0a85593a155fba8570e04c653225a.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "ust-event.h: use BYTE_ORDER instead of __BYTE_ORDER"

This reverts commit 52367557562008ab80a94adbaf047dd44b282d15.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Wrap FLOAT_WORD_ORDER"

This reverts commit c759fe81a6251b9feddf5cd9576278ffedf92ac3.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Remove O_LARGEFILE from tests"

This reverts commit 626cb7f6174c4d9c22364f10d3d6a0915e53d5f3.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Add configure amd64 support (for FreeBSD)"

This reverts commit 404d9909a392de0e0044c7f49a932d1765c9d813.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Remove gettid warning"

This reverts commit 4f41890f998c2c3778213ed2a8938534fb3060e1.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Return -EINVAL instead of print warning if non power of 2 size/num_subbuf

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: on exit, leave thread/mmap reclaim to OS

Do NOT join threads: use of sys_futex makes it impossible to join the
threads without using async-cancel, but async-cancel is delivered by a
signal, which could hit the target thread anywhere in its code path,
including while the ust_lock() is held, causing a deadlock for the other
thread. Let the OS cleanup the threads if there are stalled in a
syscall.

wait_shm_mmap is used by listener threads outside of the ust lock, so we
cannot tear it down ourselves, because we cannot join on these threads.
Leave this task to the OS process exit.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: Handle sys_futex with async cancel, add missing pthread_join

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix: Only munmap the wait page when not exiting from process

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use CPPFLAGS instead of CFLAGS for -I

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix type range comparison always false for 64-bit arch

ltt-events.c: In function 'ltt_event_create':
ltt-events.c:498: warning: comparison is always false due to limited
range of data type

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove gettid warning

Not so important, hides really useful warnings.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

demo: remove useless libs

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add configure amd64 support (for FreeBSD)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove O_LARGEFILE from tests

Not portable.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

tests: include missing headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Wrap FLOAT_WORD_ORDER

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust-event.h: use BYTE_ORDER instead of __BYTE_ORDER

available on both Linux and FreeBSD.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Detect and document dependency on -ldl on Linux, -lc on BSD for dlopen

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove useless const qualifier

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update uuid_create type cast

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cast uuid_create parameter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add freebsd rfork support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

uuid.h should only be included when libuuid is detected

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename uuid.h wrapper to lttng-ust-uuid.h

So it does not clash with BSD system's uuid.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Create libuuid/libc uuid wrapper

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

configure.ac: check for both libuuid/libc uuid APIs

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use bsd-compatible fcntl for close-on-exec on socket

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use ENOMSG as fallback for ENODATA on freebsd

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use XSI-compliant strerror_r by default on non-Linux

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Compat layer for gettid

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

snprintf: fix namespace of snprintf types for freebsd

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add freebsd support for getcpu (use cpu nr 0)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add get proc name wrapper for FreeBSD

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix freebsd endian support

Need to use #elif defined().

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fls: use local namespace to do not clash with FreeBSD string.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add FreeBSD compat layer for endian.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing limits.h include for NAME_MAX

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>