Fix: lttng trace-clock needs to disable preemption

We use a per-cpu data structure, and some contexts (e.g. buffer create)
call this function with preemption enabled. This is the case also for
buffer flush operation.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint event: add "TP_code_post()"

Useful for probes that need to perform teardown after serialization,
e.g. allocate temporary memory in TP_code_pre() and free it in
TP_code_post(). Be careful to only use memory allocation from contexts
allowing it.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement array and sequence bitfields

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kmem: add mm.h include

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add page frame number (pfn) to kmem page events

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use pfn rather than struct page in ring buffer array

First step to support permanent memory (e.g. pmem) which does not have
struct page.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement clock plugin support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Command to regenerate the metadata of a session

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: writeback instrumentation update for 4.3 Linux kernel

Linux upstream commit:

commit 5634cc2aa9aebc77bc862992e7805469dcf83dac
Author: Tejun Heo <tj@kernel.org>
Date:   Tue Aug 18 14:54:56 2015 -0700

    writeback: update writeback tracepoints to report cgroup

Updated the tracepoint signatures for writeback probes. Follow this
change. Don't add extra data (cgroup information) yet.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update sched wakeup instrumentation for 4.3 kernel

Change introduced in upstream Linux:

commit fbd705a0c6184580d0e2fbcbd47a37b6e5822511
Author: Peter Zijlstra <peterz@infradead.org>
Date:   Tue Jun 9 11:13:36 2015 +0200

    sched: Introduce the 'trace_sched_waking' tracepoint

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: lttng-test build failure for kernels < 3.0

Fixes an undefined reference to kstrtouint_from_user.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use 3.18 syscall instrumentation for MIPS32

Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update the MIPS32 syscall instrumentation to 3.18

Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Move pipe override to the arch specific pointers_override.h

The MIPS architecture has a non-standard calling convention for pipe()
and cannot use the provided override for the pipe event.

Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement lttng test module

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove logically dead code

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: filter validator use after free

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use after free in channel release

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: non-enabler events should be disabled by default

The session daemon expects that all events (enablers and events) are
disabled when created, so we can attach a filter before enabling them.

Also fix the kretprobe to ensure we can enable/disable both the entry
and return probe (--function instrumentation).

Fixes: #926
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: build failure on 2.6.36

Fixes build failure on the 2.6.36 kernel branch which misses the
vzalloc() function.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: split bdi_dirty_ratelimit with ifdef into separate macros

Makes the code easier to maintain in the long run.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: writeback instrumentation for 4.2 kernels

Bandwidth related fields were moved by this commit:

commit a88a341a73be4ef035ca26170c849f002797da27
Author: Tejun Heo <tj@kernel.org>
Date:   Fri, 22 May 2015 17:13:28 -0400

    writeback: move bandwidth related fields from backing_dev_info into
    bdi_writeback

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: mm_page_alloc_extfrag instrumentation for kernel 3.18.10

The following commit has been backported from kernel 3.19.2 into
3.18.10, introducing a change to mm_page_alloc_extfrag and therefore
provoking a build failure on a 3.18.10 kernel:

commit a4f3f96f850db69890f47984c60606a2362bee89
Author: Vlastimil Babka <vbabka@suse.cz>
Date:   Wed Feb 11 15:28:15 2015 -0800

    mm: when stealing freepages, also take pages created by splitting buddy page

    commit 99592d598eca62bdbbf62b59941c189176dfc614 upstream.

This patch adds the proper version check to allow building on 3.18.y.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add stream instance id to the packet header

This new field allows the viewer to distinguish between trace files
belonging to the same packet stream (in LTTng: the same CPU in the same
channel).

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add a packet sequence number

This allows the viewer to identify the gaps between trace packets.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kmem probe with Ubuntu 3.13 kernels

Fixes an undefined reference to get_pageblock_flags_mask.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: disable kvm probe if lapic.h isn't found

In a typical distribution if just linux-headers is installed, lapic.h
will not be installed. We should check if that file exists and not build
the module.

Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: timer instrumentation for 4.2 kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ext4 instrumentation for 4.2 kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kvm instrumentation for 4.2 kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: allow LTTng to be built within kernel tree

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 2.7.0-rc1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Building the event list fails on fragmented memory

On a small arm imx6 solo with 256MB RAM it often happens that memory
becomes fragmented rather quickly, so that kmalloc will not be able to
get enough consecutive pages (enocuntered for example if you enable all
kernel events: lttng enable-event -k syscall --all).

This patch switches the allocation to vmalloc. Tested for x86 on Ubuntu
12.04 Lts and on imx6 solo 256MB RAM

If this patch is not applied, you can identify low and/or fragmented
memory failures by looking at the kernel ring buffer (please ignore DMA,
it is due to some memory setup misconfiguration, should read Normal):

...
[  321.993820] lttng-sessiond: page allocation failure: order:4, mode:0x1040d0
...
[  321.994711] lowmem_reserve[]: 0 0 0
[  321.994727] DMA: 801*4kB (UEMC) 424*8kB (EMC) 355*16kB (UEMC) 344*32kB (MC) 340*64kB (C) 8*128kB (C) 0*256kB 0*512kB 0*1024kB 0*2048kB 0*4096kB 0*8192kB 0*16384kB 0*32768kB = 46068kB

[ Edit by Mathieu: use vzalloc() rather than vmalloc() + memset 0. ]

Signed-off-by: Martin Leisener <martin@leisener.de>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use after free on metadata cache reallocation

When the metadata cache is expanded (reallocated) by
lttng_metadata_printf(), the metadata cache reader
(lttng_metadata_output_channel()) may use freed memory, because the
metadata cache is not protected from concurrent read accesses. The
metadata cache updates are protected from each other by the sessions
mutex, but metadata cache reads do not hold the sessions mutex.
Actually, the comment on top of lttng_metadata_output_channel() stating
"We have exclusive access to our metadata buffer (protected by the
sessions_mutex)" is simply wrong, because this mutex is never held when
calling lttng_metadata_output_channel().

Promote the per-stream lock to the metadata cache used by each of those
metadata streams, thus ensuring mutual exclusion between metadata cache
reallocation and readers.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: version checks for kernel 4.0

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Incorrect Ubuntu kernel patchlevel

The kernel version used should be the one in Makefile and generated
version.h, not the one tweaked by Ubuntu as "0" in the built package.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: cpu-id context should use int type

cycles_t makes no sense as type for cpu-id context.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement cpu-id context

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement cpu_id context for filtering

cpu_id context can now be used for filtering, e.g.:

lttng enable-event -k sched_switch --filter '$ctx.cpu_id==1'

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: context printk mismatch on error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: misleading comment about deferrable timer

Timer in lttng-modules are not deferrable, because we cannot hook into
the Linux kernel CPU idle events, because no notifiers are exposed for
those.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: arm-32 build

The current master branch of lttng-modules doesn't seem to compile for
arm-32 builds.

The patch below repairs the build for arm (and still builds on a x86)
(tested on Ubuntu 12.04 LTS x86 + imx6 solo)

Signed-off-by: Martin Leisener <martin@leisener.de>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update kmem event for Ubuntu's 3.16 kernel

The upstream patch in question in commit 72906e1 was cherry-picked into
Ubuntu's 3.16 kernel backport branch (called lts-utopic). The version
check should also include this branch.

The other backport branch, lts-vivid, and all following ones will be
covered by the standard

  LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,2)

check, so should not require other workarounds.

References #889.

Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: RHEL 7.1 block instrumentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add RHEL version macros

RHEL 7.1 has backported upstream patches that change the kvm.h
tracepoint prototype. Add version check specific to RHEL to handle this
case.

RHEL 7.x has the required fixes backported that allow removing the 3.10
blacklist check for them, so take this into account.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing parenthesis in ubuntu version check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove regmap instrumentation for kernels < 4.1

Modifications to regmap.h instrumentation in mainline Linux kernel has
been no less than erratic. First, the public instrumentation header
regmap.h include a private driver header in Linux 4.0. Then, regmap.h
is moved to the private driver directory in Linux 4.1. To make things
worse, the 4.0 commit has been picked into stable branches of the Linux
kernel.

Since this does not appear to be an instrumentation of utmost
importance, only build this instrumentation probe if the private header
is found in the driver directory (need full kernel sources).

This removes regmap instrumentation for older kernels.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update kmem event for recent Ubuntu kernel

Ubuntu backported a patch into their 3.13 (Trusty) branch which
changes kmem event definition.

Upstream commit
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=99592d598eca62bdbbf62b59941c189176dfc614
first appears in 4.0 (and was later backported to 3.19.2).
We already have the proper check for this.

This corresponds to Ubuntu commit
http://kernel.ubuntu.com/git/ubuntu/ubuntu-trusty.git/commit/?id=d938e4bff1089a1f4757ed94a5cace803c6a363b
which was first released with 3.13.0-50.82.
This required adding a new check specifically for the
Ubuntu version.

Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: missing statedump end event when block device listing available

Incorrect handling of lttng_enumerate_block_devices() return value of 0
(which means "ok"), causing do_lttng_statedump() to return early.

To causes missing "lttng_statedump_end" in traces where block device
enumeration is available (CONFIG_KALLSYMS=y).

Reported-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: don't generate incorrect macros for debian/ubuntu version check

When the debian/ubuntu macros are unset, we end up generating macros
that have no right hand operand to "+", which seems to break compilation
on some compilers, even though it will always be optimized away.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Revert "Fix: build against Ubuntu kernels"

This reverts commit a748963b76f353d459a3faf85eecc96f52811eee.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: build against Ubuntu kernels

Recent Ubuntu kernels appear to define DEBIAN_API_VERSION, but they are
not really a Debian kernel per-se: the abi-debian-version.sh cannot find
the expected Debian kernel version string layout.

Therefore, change the conditional check to use directly the
LTTNG_DEBIAN_VERSION_CODE define, which is defined only when the
abi-debian-version.sh script figures out it builds against a Debian
kernel.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add namespace info in sched_fork and statedump

Modifications to sched_fork : Add a field for parent and child pid
namespace inode (as in /proc/$PID/ns/pid). Also add a field for the
child VTID.

Modifications to lttng_statedump_process_state : Add a field for the pid
namespace inode of the task.

Signed-off-by: Sebastien Lorrain <sebastien.lorrain01@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ext4 instrumentation: flags parameter did not exist prior to 3.11

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: printk instrumentation: remove "condition" tracepoints

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: regmap build against kernel 4.0 kernel headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add mmu_valid_gen field to mmutrace events

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing x86 mmutrace kernel header include

Needed to ensure the compiler checks prototypes of lttng-modules probe
against the kernel prototypes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: x86 mmutrace event extra field for kernels >= 3.11

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove execute flag from kvm.h file

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: build x86 kvm probes on kernels >= 4.1-rc1

iodev.h has moved to include/kvm/.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compilation on 4.1-rc1 kernel, remove unused WB_WORK_REASON

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: 4.1-rc1 Linux build and regmap instrumentation

regmap header has been privatized.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: don't clash with older Debian kernel versions

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update get_pfnblock_flags_mask wrapper for debian kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: discover Debian API

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Update README.md to match reality: kernels >= 2.6.36 are supported

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: atomic.h wrapper for kernels < 2.6.37

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: disable x86 kvm instrumentation for kernels < 2.6.38

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing types.h include for older kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add hlist lttng wrappers

For older kernels (e.g. 2.6.38).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add struct file_handle forward declaration

For older kernels (e.g. 2.6.38).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: string length calculation reversed user vs kernel args

Only affects feature recently merged into master.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use lttng_rcu_dereference within lttng-syscalls.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add lttng rcu wrapper to allow tracing RCU

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: double-unlock of session mutex

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: check that class and instance prototype match

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: lttng-events.h check function takes void

The kernel nerver really emit this, but our function prototype should
not take the void *data parameter, so we are similar to the the "with
argument" prototype, which does not have the private data pointer.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: regmap instrumentation for Linux 3.19.4 and 4.0

This is necessary after commit c6b570d97c0e77f570bb6b2ed30d372b2b1e9aae
in the kernel.

[ Edit by Mathieu Desnoyers: fix DECLARE_EVENT_CLASS regmap_reg too. ]

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: kernels >= 2.6.33 put utsrelease.h in generated/

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Include utsrelease.h in lttng-kernel-version.h

Including module.h includes other headers, which is an issue for the
get_pfnblock_flags_mask wrapper.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ext4 ext4_da_write_pages instrumentation for kernels < 3.11.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: old kernels need module.h included before vermagic.h

This is at least true for 3.2.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: net instrumentation for kernels 2.6.39 and below

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: version condition in makefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement wrapper around get_pfnblock_flags_mask

This is used by kmem instrumentation, and changed in 4.0.0. This change
has been backported to 3.19.2 stable kernel.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Be more restrictive in provider name check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: net instrumentation namespacing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: compaction instrumentation namespacing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Support 4.x kernel versions in Makefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: remove stale TP_STRUCT_entry from kvm instrumentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing module.h include to lttng-probe-user.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use lttng hlist wrapper in wildcard and filter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: namespace asoc and kmem instrumentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: update instrumentation after wildcard rebase

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: lttng_abi_syscall_list does not need to be exported

Fix rebase of wildcard feature.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Migrate ARM, powerpc, MIPS syscall instrumentation to TP_FIELDS

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove now unused syscalls.h from lttng-modules

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Filter: start with enabler "disabled"

Since we can create the enabler, then attach the filter, and then enable
it, ensure it is in a "disabled" state initially.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix coverity warning about sizeof(void **) != sizeof(void *)

The size of the copied data is actually void *, not void **.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>