From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Fri, 14 Apr 2023 18:39:05 +0000 (-0400)
Subject: Fix: sessiond: silent kernel notifier registration error
X-Git-Tag: v2.13.10~3
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=fffd5b5bcf81510dcb890e1d34df3dd55964e998;p=lttng-tools.git

Fix: sessiond: silent kernel notifier registration error

When a kernel notifier fails to be registered, the error is silently
ignored because of a missing jump to the error label.

This was noticed while debugging an unrelated problem where the kernel
tracer would fail to add a userspace probe to a semaphore-protected SDT
probe.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I9261ad7131b1b53152fe8960f17a6fca7029440f
---

diff --git a/src/bin/lttng-sessiond/cmd.c b/src/bin/lttng-sessiond/cmd.c
index 87676b0e7..3adbbebca 100644
--- a/src/bin/lttng-sessiond/cmd.c
+++ b/src/bin/lttng-sessiond/cmd.c
@@ -4519,6 +4519,8 @@ enum lttng_error_code synchronize_tracer_notifier_register(
 						(int) trigger_owner,
 						ret_code);
 			}
+
+			goto end_unlock_session_list;
 		}
 		break;
 	}