From: Jonathan Rajotte Date: Thu, 28 May 2020 01:29:05 +0000 (-0400) Subject: Tests: Fix: 99% fill ratio for high buffer usage is too high for larger events X-Git-Tag: v2.12.3~11 X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=fd5f40473396e65ca78a6806c269b7b4604803eb;p=lttng-tools.git Tests: Fix: 99% fill ratio for high buffer usage is too high for larger events If the event being registered is bigger than 1% of a subbuffer, the 99% ratio cannot be achieved since the "last event" necessary to go over 99% will always be dropped by the tracer. e.g: DBG1 - 19:31:07.665963875 [Notification]: [notification-thread] High buffer usage condition being evaluated: threshold = 16220, highest usage = 16196 (in evaluate_buffer_usage_condition() at notification-thread-events.c:3733) We use a ratio of 90% to keep a little headroom. Signed-off-by: Jonathan Rajotte Signed-off-by: Jérémie Galarneau Change-Id: I06180735e0b5e88209b888e51cc83b4ac7d98193 --- diff --git a/tests/regression/tools/notification/notification.c b/tests/regression/tools/notification/notification.c index 364d41895..e82c052ed 100644 --- a/tests/regression/tools/notification/notification.c +++ b/tests/regression/tools/notification/notification.c @@ -413,7 +413,7 @@ void test_notification_channel(const char *session_name, const char *channel_nam struct lttng_condition *dummy_condition = NULL; double low_ratio = 0.0; - double high_ratio = 0.99; + double high_ratio = 0.90; /* Set-up */ action = lttng_action_notify_create();