From: David Goulet <david.goulet@polymtl.ca>
Date: Thu, 2 Jun 2011 19:01:45 +0000 (-0400)
Subject: Add TODOs for session daemon
X-Git-Tag: v2.0-pre1~87
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=f7776ea71b15b00b5f83b9876ccba9f6ede8e2b4;p=lttng-tools.git

Add TODOs for session daemon

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
---

diff --git a/ltt-sessiond/main.c b/ltt-sessiond/main.c
index cbd6a3f3f..e7ad6f9b1 100644
--- a/ltt-sessiond/main.c
+++ b/ltt-sessiond/main.c
@@ -634,6 +634,7 @@ static int create_trace_dir(struct ltt_kernel_session *session)
 	/* Create all channel directories */
 	cds_list_for_each_entry(chan, &session->channel_list.head, list) {
 		DBG("Creating trace directory at %s", chan->pathname);
+		// TODO: recursive create dir
 		ret = mkdir(chan->pathname, S_IRWXU | S_IRWXG );
 		if (ret < 0) {
 			perror("mkdir trace path");
@@ -1197,6 +1198,8 @@ static void *thread_manage_clients(void *data)
 			continue;
 		}
 
+		// TODO: Validate cmd_ctx including sanity check for security purpose.
+
 		/*
 		 * This function dispatch the work to the kernel or userspace tracer
 		 * libs and fill the lttcomm_lttng_msg data structure of all the needed