From: Simon Marchi <simon.marchi@efficios.com>
Date: Mon, 25 Nov 2019 20:25:39 +0000 (-0500)
Subject: common: make some functions static in mi-lttng.c
X-Git-Tag: v2.12.0-rc1~206
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=f5a2d630c739bf23e1bb7d1ab5602d21ec12aedb;p=lttng-tools.git

common: make some functions static in mi-lttng.c

These two functions are only used in the file, so make them static.

Fixes:

      CC       mi-lttng.lo
    /home/smarchi/src/lttng-tools/src/common/mi-lttng.c:367:13: error: no previous declaration for ‘mi_lttng_eventtype_string’ [-Werror=missing-declarations]
     const char *mi_lttng_eventtype_string(enum lttng_event_type value)
                 ^~~~~~~~~~~~~~~~~~~~~~~~~
    /home/smarchi/src/lttng-tools/src/common/mi-lttng.c:1317:5: error: no previous declaration for ‘mi_lttng_event_userspace_probe’ [-Werror=missing-declarations]
     int mi_lttng_event_userspace_probe(struct mi_writer *writer,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

There are a bunch of other stuff in mi-lttng.c that could be made
static, but those were the only two problematic with
-Wmissing-declarations, because there have no declaration in the .h.

Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I9f3a6b0f71e86fac7af5d40e553a6944eb768fbe
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/mi-lttng.c b/src/common/mi-lttng.c
index 2a69d4529..c4bda37bb 100644
--- a/src/common/mi-lttng.c
+++ b/src/common/mi-lttng.c
@@ -363,7 +363,7 @@ const char *mi_lttng_logleveltype_string(enum lttng_loglevel_type value)
 	}
 }
 
-LTTNG_HIDDEN
+static
 const char *mi_lttng_eventtype_string(enum lttng_event_type value)
 {
 	switch (value) {
@@ -1313,7 +1313,7 @@ end:
 	return ret;
 }
 
-LTTNG_HIDDEN
+static
 int mi_lttng_event_userspace_probe(struct mi_writer *writer,
 		struct lttng_event *event)
 {