From: Jérémie Galarneau Date: Wed, 26 Nov 2014 21:20:21 +0000 (-0500) Subject: Fix: Unreachable error logging in set_option() X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=f3dd7ce78597e2d8b002fcc9536aa6016d1b039f;p=lttng-tools.git Fix: Unreachable error logging in set_option() *** CID 1256136: Logically dead code (DEADCODE) Signed-off-by: Jérémie Galarneau --- diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index 4bfbb9ef4..a970012c7 100644 --- a/src/bin/lttng-sessiond/main.c +++ b/src/bin/lttng-sessiond/main.c @@ -4464,6 +4464,7 @@ static int set_option(int opt, const char *arg, const char *optname) ret = -1; } +end: if (ret == -EINVAL) { const char *opt_name = "unknown"; int i; @@ -4479,7 +4480,7 @@ static int set_option(int opt, const char *arg, const char *optname) WARN("Invalid argument provided for option \"%s\", using default value.", opt_name); } -end: + return ret; }