From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Mon, 20 Aug 2018 18:51:45 +0000 (-0400)
Subject: Fix: unreported error on rotate timer stop failure
X-Git-Tag: v2.11.0-rc1~149
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=f3ce6946ed9508129491909fd56b61026bc0f054;p=lttng-tools.git

Fix: unreported error on rotate timer stop failure

A missing 'goto end' causes errors occuring when stopping
the sessiond's rotate timer to be ignored as the switch-case's
case breaks and the 'ret' value is set to LTTNG_OK.

Reported-by: Coverity Scan (1395074 Unused value)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/cmd.c b/src/bin/lttng-sessiond/cmd.c
index ba7dd3d4d..626275086 100644
--- a/src/bin/lttng-sessiond/cmd.c
+++ b/src/bin/lttng-sessiond/cmd.c
@@ -4903,6 +4903,7 @@ int cmd_rotation_set_schedule(struct ltt_session *session,
 			if (ret) {
 				ERR("Failed to disable session rotation timer in ROTATION_SET_SCHEDULE command");
 				ret = LTTNG_ERR_UNK;
+				goto end;
 			}
 		}
 		break;