From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Wed, 11 Aug 2010 14:13:42 +0000 (-0400)
Subject: UST synchronization fix
X-Git-Tag: v0.6~2
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=ee4c34673a261a035d224096db82e6b70ba085ca;p=ust.git

UST synchronization fix

Missing smp_wmb() at subbuffer switch.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/libust/buffers.c b/libust/buffers.c
index 801a878..c27b788 100644
--- a/libust/buffers.c
+++ b/libust/buffers.c
@@ -858,7 +858,7 @@ static void ltt_reserve_switch_old_subbuf(
 	 * This compiler barrier is upgraded into a smp_wmb() by the IPI
 	 * sent by get_subbuf() when it does its smp_rmb().
 	 */
-	barrier();
+	smp_wmb();
 	uatomic_add(&buf->commit_count[oldidx].cc, padding_size);
 	commit_count = uatomic_read(&buf->commit_count[oldidx].cc);
 	ltt_check_deliver(chan, buf, offsets->old - 1, commit_count, oldidx);
@@ -887,7 +887,7 @@ static void ltt_reserve_switch_new_subbuf(
 	 * This compiler barrier is upgraded into a smp_wmb() by the IPI
 	 * sent by get_subbuf() when it does its smp_rmb().
 	 */
-	barrier();
+	smp_wmb();
 	uatomic_add(&buf->commit_count[beginidx].cc, ltt_subbuffer_header_size());
 	commit_count = uatomic_read(&buf->commit_count[beginidx].cc);
 	/* Check if the written buffer has to be delivered */
@@ -932,7 +932,7 @@ static void ltt_reserve_end_switch_current(
 	 * This compiler barrier is upgraded into a smp_wmb() by the IPI
 	 * sent by get_subbuf() when it does its smp_rmb().
 	 */
-	barrier();
+	smp_wmb();
 	uatomic_add(&buf->commit_count[endidx].cc, padding_size);
 	commit_count = uatomic_read(&buf->commit_count[endidx].cc);
 	ltt_check_deliver(chan, buf,