From: Mathieu Desnoyers Date: Tue, 17 May 2016 13:11:39 +0000 (-0400) Subject: Fix: Integer overflowed argument X-Git-Tag: v2.9.0-rc1~200 X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=ec93758c0ba074a6d290b38f016348f32274f496;p=lttng-tools.git Fix: Integer overflowed argument Found by Coverity: CID 1242317 (#1 of 2): Integer overflowed argument (INTEGER_OVERFLOW)25. overflow_sink: Overflowed or truncated value (or a value computed from an overflowed or truncated value) new_nbmem * 304UL used as critical argument to function. CID 1242317 (#2 of 2): Integer overflowed argument (INTEGER_OVERFLOW)27. overflow_sink: Overflowed or truncated value (or a value computed from an overflowed or truncated value) (new_nbmem - nbmem) * 304UL used as critical argument to function. Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- diff --git a/src/bin/lttng-sessiond/syscall.c b/src/bin/lttng-sessiond/syscall.c index a994da52b..b5525640a 100644 --- a/src/bin/lttng-sessiond/syscall.c +++ b/src/bin/lttng-sessiond/syscall.c @@ -82,7 +82,7 @@ int syscall_init_table(void) /* Double memory size. */ new_nbmem = max(index, nbmem << 1); - if (new_nbmem < nbmem) { + if (new_nbmem > (SIZE_MAX / sizeof(*new_list))) { /* Overflow, stop everything, something went really wrong. */ ERR("Syscall listing memory size overflow. Stopping"); free(syscall_table);