From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 29 May 2024 18:29:23 +0000 (+0000)
Subject: clang-tidy: c_string_view: unmatched NOLINTBEGIN
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=e49a2b52c3239f5d4a159f9d9b95657ad519e397;p=lttng-tools.git

clang-tidy: c_string_view: unmatched NOLINTBEGIN

clang-tidy reports:
'NOLINTBEGIN' comment without a subsequent 'NOLINTEND' comment

If a specific warning is mentionned as part of the NOLINTBEGIN clause, it must
also be mentionned in the matching NOLINTEND clause. Otherwise, clang-tidy
doesn't match them.

Change-Id: I6adef610227b162ba8a5715c3b426e4c49a1b346
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/string-utils/c-string-view.hpp b/src/common/string-utils/c-string-view.hpp
index 6b175ea33..386ac8fda 100644
--- a/src/common/string-utils/c-string-view.hpp
+++ b/src/common/string-utils/c-string-view.hpp
@@ -47,7 +47,7 @@ public:
 	c_string_view(const std::string& str) noexcept : _str{ str.c_str() }
 	{
 	}
-	/* NOLINTEND */
+	/* NOLINTEND(google-explicit-constructor) */
 
 	/*
 	 * Makes this view view the C string `str` (may be `nullptr`).