From: David Goulet <dgoulet@efficios.com>
Date: Tue, 7 Oct 2014 19:05:48 +0000 (-0400)
Subject: Fix: return EINVAL if agent registration fails
X-Git-Tag: v2.4.3~32
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=e37c37c64ff100d236ecc0436c802e5917880ca1;p=lttng-tools.git

Fix: return EINVAL if agent registration fails

The errno value might be 0 thus not returning an error if so. It has
been seen with an unstable python agent code base which means it could
happen in the future if a third part decides to create an agent.

Signed-off-by: David Goulet <dgoulet@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/jul-thread.c b/src/bin/lttng-sessiond/jul-thread.c
index d8748f2a5..a683cdcdb 100644
--- a/src/bin/lttng-sessiond/jul-thread.c
+++ b/src/bin/lttng-sessiond/jul-thread.c
@@ -206,7 +206,7 @@ static int handle_registration(struct lttcomm_sock *reg_sock,
 
 	size = new_sock->ops->recvmsg(new_sock, &msg, sizeof(msg), 0);
 	if (size < sizeof(msg)) {
-		ret = -errno;
+		ret = -EINVAL;
 		goto error_socket;
 	}
 	pid = be32toh(msg.pid);