From: Jérémie Galarneau <jeremie.galarneau@gmail.com>
Date: Tue, 17 May 2016 16:17:05 +0000 (-0400)
Subject: Fix: unchecked posix_fadvise() return value
X-Git-Tag: v2.7.3~34
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=e2f6bedf440b97836d57c16d2d324e694d31ef33;p=lttng-tools.git

Fix: unchecked posix_fadvise() return value

Found by Coverity:

CID 1019971 (#1 of 1): Unchecked return value from library
(CHECKED_RETURN)2. check_return: Calling posix_fadvise(outfd,
orig_offset - stream->max_sb_size, stream->max_sb_size, 4) without
checking return value. This library function may fail and return an
error code.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/consumer.c b/src/common/consumer.c
index 9003005a0..a96d5165e 100644
--- a/src/common/consumer.c
+++ b/src/common/consumer.c
@@ -1233,6 +1233,7 @@ void lttng_consumer_should_exit(struct lttng_consumer_local_data *ctx)
 void lttng_consumer_sync_trace_file(struct lttng_consumer_stream *stream,
 		off_t orig_offset)
 {
+	int ret;
 	int outfd = stream->out_fd;
 
 	/*
@@ -1263,8 +1264,11 @@ void lttng_consumer_sync_trace_file(struct lttng_consumer_stream *stream,
 	 * defined. So it can be expected to lead to lower throughput in
 	 * streaming.
 	 */
-	posix_fadvise(outfd, orig_offset - stream->max_sb_size,
+	ret = posix_fadvise(outfd, orig_offset - stream->max_sb_size,
 			stream->max_sb_size, POSIX_FADV_DONTNEED);
+	if (ret) {
+		WARN("posix_fadvise() error (%i)", ret);
+	}
 }
 
 /*