From: Benjamin Poirier <benjamin.poirier@polymtl.ca>
Date: Thu, 1 Apr 2010 14:46:32 +0000 (-0400)
Subject: Display the accuracy area below the eval graphs
X-Git-Tag: 0.12.32~24
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=e2793cfa2a24ec3d0fcfb58d7f75dfcf0a79556c;p=lttv.git

Display the accuracy area below the eval graphs

Restore the trace-time graph behavior that was present before "Calculate
synchronization accuracy within the chull module". The encapsulation is not
broken however. The eval graphs show broadcast points over the accuracy area.

Signed-off-by: Benjamin Poirier <benjamin.poirier@polymtl.ca>
---

diff --git a/lttv/lttv/sync/event_analysis_eval.c b/lttv/lttv/sync/event_analysis_eval.c
index d5c3be29..8632b6a6 100644
--- a/lttv/lttv/sync/event_analysis_eval.c
+++ b/lttv/lttv/sync/event_analysis_eval.c
@@ -57,6 +57,10 @@ static void analyzeBroadcastEval(SyncState* const syncState, Broadcast* const
 	broadcast);
 static AllFactors* finalizeAnalysisEval(SyncState* const syncState);
 static void printAnalysisStatsEval(SyncState* const syncState);
+static void writeAnalysisTraceTimeBackPlotsEval(SyncState* const syncState,
+	const unsigned int i, const unsigned int j);
+static void writeAnalysisTraceTimeForePlotsEval(SyncState* const syncState,
+	const unsigned int i, const unsigned int j);
 
 // Functions specific to this module
 static guint ghfRttKeyHash(gconstpointer key);
@@ -104,7 +108,10 @@ static AnalysisModule analysisModuleEval= {
 	.analyzeBroadcast= &analyzeBroadcastEval,
 	.finalizeAnalysis= &finalizeAnalysisEval,
 	.printAnalysisStats= &printAnalysisStatsEval,
-	.graphFunctions= {}
+	.graphFunctions= {
+		.writeTraceTimeBackPlots= &writeAnalysisTraceTimeBackPlotsEval,
+		.writeTraceTimeForePlots= &writeAnalysisTraceTimeForePlotsEval,
+	}
 };
 
 static ModuleOption optionEvalRttFile= {
@@ -188,6 +195,7 @@ static void initAnalysisEval(SyncState* const syncState)
 	if (syncState->graphsStream)
 	{
 		AnalysisGraphsEval* graphs= malloc(sizeof(AnalysisGraphsEval));
+		GList* result;
 
 		analysisData->graphs= graphs;
 
@@ -205,6 +213,14 @@ static void initAnalysisEval(SyncState* const syncState)
 				graphs->bounds[i][j].max= 0;
 			}
 		}
+
+		graphs->chullSS= (SyncState*) malloc(sizeof(SyncState));
+		memcpy(graphs->chullSS, syncState, sizeof(SyncState));
+		graphs->chullSS->analysisData= NULL;
+		result= g_queue_find_custom(&analysisModules, "chull", &gcfCompareAnalysis);
+		g_assert(result != NULL);
+		graphs->chullSS->analysisModule= (AnalysisModule*) result->data;
+		graphs->chullSS->analysisModule->initAnalysis(graphs->chullSS);
 	}
 }
 
@@ -510,6 +526,9 @@ static void destroyAnalysisEval(SyncState* const syncState)
 		}
 		free(graphs->bounds);
 
+		graphs->chullSS->analysisModule->destroyAnalysis(graphs->chullSS);
+		free(graphs->chullSS);
+
 		free(graphs);
 	}
 
@@ -612,6 +631,9 @@ static void analyzeMessageEval(SyncState* const syncState, Message* const
 	{
 		updateBounds(analysisData->graphs->bounds, message->inE,
 			message->outE);
+
+		analysisData->graphs->chullSS->analysisModule->analyzeMessage(analysisData->graphs->chullSS,
+			message);
 	}
 }
 
@@ -806,6 +828,9 @@ static AllFactors* finalizeAnalysisEval(SyncState* const syncState)
 {
 	AnalysisDataEval* analysisData= syncState->analysisData;
 
+	/* This function may be run twice because of matching_distributor. This
+	 * check is there to make sure the next block is run only once.
+	 */
 	if (syncState->graphsStream && analysisData->graphs->histograms)
 	{
 		g_hash_table_foreach(analysisData->graphs->histograms,
@@ -813,6 +838,14 @@ static AllFactors* finalizeAnalysisEval(SyncState* const syncState)
 			analysisData->rttInfo, .graphsStream= syncState->graphsStream});
 		g_hash_table_destroy(analysisData->graphs->histograms);
 		analysisData->graphs->histograms= NULL;
+
+		if (syncState->graphsStream)
+		{
+			SyncState* chullSS= analysisData->graphs->chullSS;
+
+			freeAllFactors(chullSS->analysisModule->finalizeAnalysis(chullSS),
+				chullSS->traceNb);
+		}
 	}
 
 	return createAllFactors(syncState->traceNb);
@@ -1392,3 +1425,49 @@ static void updateBounds(Bounds** const bounds, Event* const e1, Event* const
 		tpBounds->max= messageTime;
 	}
 }
+
+
+/*
+ * Write the analysis-specific graph lines in the gnuplot script.
+ *
+ * Args:
+ *   syncState:    container for synchronization data
+ *   i:            first trace number
+ *   j:            second trace number, garanteed to be larger than i
+ */
+static void writeAnalysisTraceTimeBackPlotsEval(SyncState* const syncState,
+	const unsigned int i, const unsigned int j)
+{
+	SyncState* chullSS= ((AnalysisDataEval*)
+				syncState->analysisData)->graphs->chullSS;
+	const GraphFunctions* graphFunctions=
+		&chullSS->analysisModule->graphFunctions;
+
+	if (graphFunctions->writeTraceTimeBackPlots != NULL)
+	{
+			graphFunctions->writeTraceTimeBackPlots(chullSS, i, j);
+		}
+}
+
+
+/*
+ * Write the analysis-specific graph lines in the gnuplot script.
+ *
+ * Args:
+ *   syncState:    container for synchronization data
+ *   i:            first trace number
+ *   j:            second trace number, garanteed to be larger than i
+ */
+static void writeAnalysisTraceTimeForePlotsEval(SyncState* const syncState,
+	const unsigned int i, const unsigned int j)
+{
+	SyncState* chullSS= ((AnalysisDataEval*)
+		syncState->analysisData)->graphs->chullSS;
+	const GraphFunctions* graphFunctions=
+		&chullSS->analysisModule->graphFunctions;
+
+	if (graphFunctions->writeTraceTimeForePlots != NULL)
+	{
+		graphFunctions->writeTraceTimeForePlots(chullSS, i, j);
+	}
+}
diff --git a/lttv/lttv/sync/event_analysis_eval.h b/lttv/lttv/sync/event_analysis_eval.h
index d6d39c2f..736dc8b0 100644
--- a/lttv/lttv/sync/event_analysis_eval.h
+++ b/lttv/lttv/sync/event_analysis_eval.h
@@ -115,6 +115,9 @@ typedef struct
 	 * Only the lower triangular part of the matrix is allocated, that is
 	 * bounds[i][j] where i > j */
 	Bounds** bounds;
+
+	// Extra SyncState used to overlay the chull-calculated accuracy region
+	SyncState* chullSS;
 } AnalysisGraphsEval;
 
 typedef struct