From: Mathieu Desnoyers Date: Thu, 11 Jun 2015 08:09:49 +0000 (+0200) Subject: Cleanup: misleading comment about deferrable timer X-Git-Tag: v2.7.0-rc1~9 X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=da9f3fb70da1ad678047ba9e493c4ab57fead67e;p=lttng-modules.git Cleanup: misleading comment about deferrable timer Timer in lttng-modules are not deferrable, because we cannot hook into the Linux kernel CPU idle events, because no notifiers are exposed for those. Signed-off-by: Mathieu Desnoyers --- diff --git a/lib/ringbuffer/config.h b/lib/ringbuffer/config.h index 67caba06..8fa2c55b 100644 --- a/lib/ringbuffer/config.h +++ b/lib/ringbuffer/config.h @@ -106,7 +106,7 @@ struct lib_ring_buffer_client_cb { * * wakeup: * - * RING_BUFFER_WAKEUP_BY_TIMER uses per-cpu deferrable timers to poll the + * RING_BUFFER_WAKEUP_BY_TIMER uses per-cpu timers to poll the * buffers and wake up readers if data is ready. Mainly useful for tracers which * don't want to call into the wakeup code on the tracing path. Use in * combination with "read_timer_interval" channel_create() argument. diff --git a/lib/ringbuffer/ring_buffer_iterator.c b/lib/ringbuffer/ring_buffer_iterator.c index 24e3dbb3..c6e52256 100644 --- a/lib/ringbuffer/ring_buffer_iterator.c +++ b/lib/ringbuffer/ring_buffer_iterator.c @@ -71,7 +71,7 @@ restart: * Per-CPU buffers rather use a "push" scheme because * the IPI needed to flush all CPU's buffers is too * costly. In the "push" scheme, the reader waits for - * the writer periodic deferrable timer to flush the + * the writer periodic timer to flush the * buffers (keeping track of a quiescent state * timestamp). Therefore, the writer "pushes" data out * of the buffers rather than letting the reader "pull"