From: Mathieu Desnoyers Date: Wed, 10 Feb 2021 17:33:38 +0000 (-0500) Subject: Fix: do not use bdi_unknown_name symbol X-Git-Tag: v2.12.5~4 X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=d894b241ef50eca2f9a8f77334e692d816341c7f;p=lttng-modules.git Fix: do not use bdi_unknown_name symbol Use the GPL-exported bdi_dev_name introduced in kernel 5.7. Do not use static inline bdi_dev_name in prior kernels because it uses the bdi_unknown_name symbol which is not exported to GPL modules. Signed-off-by: Mathieu Desnoyers Change-Id: I8b4e4fd84ecacef7942b308e615ca88db8dce7b6 --- diff --git a/instrumentation/events/lttng-module/writeback.h b/instrumentation/events/lttng-module/writeback.h index c988a9d7..6633e239 100644 --- a/instrumentation/events/lttng-module/writeback.h +++ b/instrumentation/events/lttng-module/writeback.h @@ -14,9 +14,12 @@ #ifndef _TRACE_WRITEBACK_DEF_ #define _TRACE_WRITEBACK_DEF_ -#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(5,6,0) || \ - LTTNG_KERNEL_RANGE(5,5,3, 5,6,0) || \ - LTTNG_KERNEL_RANGE(5,4,19, 5,5,0)) +/* + * Use the GPL-exported bdi_dev_name introduced in kernel 5.7. Do not use + * static inline bdi_dev_name in prior kernels because it uses the bdi_unknown_name + * symbol which is not exported to GPL modules. + */ +#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(5,7,0)) static inline const char *lttng_bdi_dev_name(struct backing_dev_info *bdi) { return bdi_dev_name(bdi);