From: Jérémie Galarneau Date: Sun, 15 Sep 2019 18:56:23 +0000 (-0400) Subject: kconsumer: clean-up: initialize ctf_index before populating it X-Git-Tag: v2.12.0-rc1~375 X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=d3faab47a5ff8be82a1a1df16483d1666f21d3a6;p=lttng-tools.git kconsumer: clean-up: initialize ctf_index before populating it The 'offset' field of the ctf_index is used uninitialized when it is populated. Its uninitialized value is read and stored back. This is not a problem as the offset is populated later-on. Coveity reports 1405630 Uninitialized scalar variable The variable will contain an arbitrary value left from earlier computations. In lttng_kconsumer_read_subbuffer: Use of an uninitialized variable (CWE-457) Reported-by: Coverity Scan Signed-off-by: Jérémie Galarneau --- diff --git a/src/common/kernel-consumer/kernel-consumer.c b/src/common/kernel-consumer/kernel-consumer.c index aea1b4831..9fa92f6b8 100644 --- a/src/common/kernel-consumer/kernel-consumer.c +++ b/src/common/kernel-consumer/kernel-consumer.c @@ -1553,7 +1553,7 @@ ssize_t lttng_kconsumer_read_subbuffer(struct lttng_consumer_stream *stream, int err, write_index = 1, rotation_ret; ssize_t ret = 0; int infd = stream->wait_fd; - struct ctf_packet_index index; + struct ctf_packet_index index = {}; DBG("In read_subbuffer (infd : %d)", infd);