From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Wed, 4 Apr 2018 16:20:30 +0000 (-0400)
Subject: Fix: goto end after end label
X-Git-Tag: v2.11.0-rc1~285
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=cea6c68;p=lttng-tools.git

Fix: goto end after end label

This check was most probably for the previous call and was but after the
end label by mistake. The check is not needed since the end label is
following the call.

CID 1388094 (#1 of 1): Double free (USE_AFTER_FREE)

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/rotation-thread.c b/src/bin/lttng-sessiond/rotation-thread.c
index e6b9b6a1e..d39aad80b 100644
--- a/src/bin/lttng-sessiond/rotation-thread.c
+++ b/src/bin/lttng-sessiond/rotation-thread.c
@@ -732,11 +732,6 @@ int handle_notification_channel(int fd, uint32_t revents,
 
 end:
 	lttng_notification_destroy(notification);
-	if (ret != 0) {
-		goto end;
-	}
-
-
 	return ret;
 }