From: compudj Date: Wed, 5 May 2004 22:19:55 +0000 (+0000) Subject: keep a temporary context, create new one, then delete old one. X-Git-Tag: v0.12.20~2969 X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=c2619a30c1b4614c45c9f54a5725680b8c931cb1;p=lttv.git keep a temporary context, create new one, then delete old one. git-svn-id: http://ltt.polymtl.ca/svn@520 04897980-b3bd-0310-b5e0-8ef037075253 --- diff --git a/ltt/branches/poly/lttv/modules/gui/lttvwindow/lttvwindow/callbacks.c b/ltt/branches/poly/lttv/modules/gui/lttvwindow/lttvwindow/callbacks.c index 59c98371..c4568cf4 100644 --- a/ltt/branches/poly/lttv/modules/gui/lttvwindow/lttvwindow/callbacks.c +++ b/ltt/branches/poly/lttv/modules/gui/lttvwindow/lttvwindow/callbacks.c @@ -485,6 +485,7 @@ void add_trace(GtkWidget * widget, gpointer user_data) LttTrace *trace; LttvTrace * trace_v; LttvTraceset * traceset; + LttvTracesetStats* tmp_context; const char * dir; gint id; MainWindow * mw_data = get_window_data_struct(widget); @@ -507,25 +508,31 @@ void add_trace(GtkWidget * widget, gpointer user_data) if(trace == NULL) g_critical("cannot open trace %s", dir); trace_v = lttv_trace_new(trace); traceset = mw_data->current_tab->traceset_info->traceset; - if(mw_data->current_tab->traceset_info->traceset_context != NULL){ - //remove state update hooks - lttv_state_remove_event_hooks( - (LttvTracesetState*)mw_data->current_tab->traceset_info-> - traceset_context); - lttv_context_fini(LTTV_TRACESET_CONTEXT(mw_data->current_tab-> - traceset_info->traceset_context)); - g_object_unref(mw_data->current_tab->traceset_info->traceset_context); - } + + // Keep the context until the new one is created. + tmp_context = mw_data->current_tab->traceset_info->traceset_context; + mw_data->current_tab->traceset_info->traceset_context = NULL; + lttv_traceset_add(traceset, trace_v); mw_data->current_tab->traceset_info->traceset_context = - g_object_new(LTTV_TRACESET_STATS_TYPE, NULL); + g_object_new(LTTV_TRACESET_STATS_TYPE, NULL); lttv_context_init( - LTTV_TRACESET_CONTEXT(mw_data->current_tab->traceset_info-> - traceset_context),traceset); + LTTV_TRACESET_CONTEXT(mw_data->current_tab->traceset_info-> + traceset_context), + traceset); //add state update hooks lttv_state_add_event_hooks( (LttvTracesetState*)mw_data->current_tab->traceset_info->traceset_context); - + if(tmp_context != NULL) + { + //remove state update hooks + lttv_state_remove_event_hooks( + (LttvTracesetState*)tmp_context); + lttv_context_fini(LTTV_TRACESET_CONTEXT(tmp_context)); + g_object_unref(tmp_context); + } + + add_trace_into_traceset_selector(mw_data->current_tab->multi_vpaned, trace); @@ -595,6 +602,7 @@ void remove_trace(GtkWidget * widget, gpointer user_data) LttTrace *trace; LttvTrace * trace_v; LttvTraceset * traceset; + LttvTracesetStats* tmp_context; gint i, nb_trace; char ** name, *remove_trace_name; MainWindow * mw_data = get_window_data_struct(widget); @@ -647,16 +655,11 @@ void remove_trace(GtkWidget * widget, gpointer user_data) trace_v = lttv_traceset_get(traceset, i); if(lttv_trace_get_ref_number(trace_v) <= 1) ltt_trace_close(lttv_trace(trace_v)); - - if(mw_data->current_tab->traceset_info->traceset_context != NULL){ - //remove state update hooks - lttv_state_remove_event_hooks( - (LttvTracesetState*)mw_data->current_tab->traceset_info-> - traceset_context); - lttv_context_fini(LTTV_TRACESET_CONTEXT(mw_data->current_tab-> - traceset_info->traceset_context)); - g_object_unref(mw_data->current_tab->traceset_info->traceset_context); - } + + // Keep the context until the new one is created. + tmp_context = mw_data->current_tab->traceset_info->traceset_context; + mw_data->current_tab->traceset_info->traceset_context = NULL; + lttv_traceset_remove(traceset, i); if(!lttv_trace_get_ref_number(trace_v)) lttv_trace_destroy(trace_v); @@ -668,6 +671,16 @@ void remove_trace(GtkWidget * widget, gpointer user_data) //add state update hooks lttv_state_add_event_hooks( (LttvTracesetState*)mw_data->current_tab->traceset_info->traceset_context); + + if(tmp_context != NULL){ + //remove state update hooks + lttv_state_remove_event_hooks( + (LttvTracesetState*)tmp_context); + lttv_context_fini(LTTV_TRACESET_CONTEXT(tmp_context)); + g_object_unref(tmp_context); + } + + //update current tab update_traceset(mw_data); if(nb_trace > 1){