From: Michael Jeanson <mjeanson@efficios.com>
Date: Tue, 9 Mar 2021 19:49:03 +0000 (-0500)
Subject: Hide print_op private symbol
X-Git-Tag: v2.13.0-rc1~328
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=bf617e2041b908520b7e167b3401f277c9d4b4d4;p=lttng-ust.git

Hide print_op private symbol

The major SONAME bump to '1' gives us the opportunity to hide private
symbols that should never have been visible.

Also namespace print_op to lttng_bytecode_print_op.

Change-Id: I937b37605d88503102227e82e58600e66f89b5c6
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/liblttng-ust/lttng-bytecode-interpreter.c b/liblttng-ust/lttng-bytecode-interpreter.c
index ee44a8af..9def26cd 100644
--- a/liblttng-ust/lttng-bytecode-interpreter.c
+++ b/liblttng-ust/lttng-bytecode-interpreter.c
@@ -171,7 +171,7 @@ uint64_t lttng_bytecode_capture_interpret_false(void *capture_data,
 	for (pc = next_pc = start_pc; pc - start_pc < bytecode->len;	\
 			pc = next_pc) {					\
 		dbg_printf("Executing op %s (%u)\n",			\
-			print_op((unsigned int) *(bytecode_opcode_t *) pc), \
+			lttng_bytecode_print_op((unsigned int) *(bytecode_opcode_t *) pc), \
 			(unsigned int) *(bytecode_opcode_t *) pc); 	\
 		switch (*(bytecode_opcode_t *) pc)	{
 
diff --git a/liblttng-ust/lttng-bytecode-validator.c b/liblttng-ust/lttng-bytecode-validator.c
index c5dc6272..cbae3215 100644
--- a/liblttng-ust/lttng-bytecode-validator.c
+++ b/liblttng-ust/lttng-bytecode-validator.c
@@ -1975,7 +1975,7 @@ int lttng_bytecode_validate(struct bytecode_runtime *bytecode)
 			goto end;
 		}
 		dbg_printf("Validating op %s (%u)\n",
-			print_op((unsigned int) *(bytecode_opcode_t *) pc),
+			lttng_bytecode_print_op((unsigned int) *(bytecode_opcode_t *) pc),
 			(unsigned int) *(bytecode_opcode_t *) pc);
 
 		/*
diff --git a/liblttng-ust/lttng-bytecode.c b/liblttng-ust/lttng-bytecode.c
index 9bb7f11f..79349570 100644
--- a/liblttng-ust/lttng-bytecode.c
+++ b/liblttng-ust/lttng-bytecode.c
@@ -162,7 +162,7 @@ static const char *opnames[] = {
 	[ BYTECODE_OP_RETURN_S64 ] = "RETURN_S64",
 };
 
-const char *print_op(enum bytecode_op op)
+const char *lttng_bytecode_print_op(enum bytecode_op op)
 {
 	if (op >= NR_BYTECODE_OPS)
 		return "UNKNOWN";
diff --git a/liblttng-ust/lttng-bytecode.h b/liblttng-ust/lttng-bytecode.h
index c0e90c45..4e9f97c9 100644
--- a/liblttng-ust/lttng-bytecode.h
+++ b/liblttng-ust/lttng-bytecode.h
@@ -314,8 +314,8 @@ struct lttng_interpreter_output {
 	} u;
 };
 
-/* Should be hidden but would break the ABI */
-const char *print_op(enum bytecode_op op);
+LTTNG_HIDDEN
+const char *lttng_bytecode_print_op(enum bytecode_op op);
 
 LTTNG_HIDDEN
 void lttng_bytecode_filter_sync_state(struct lttng_bytecode_runtime *runtime);