From: Kienan Stewart <kstewart@efficios.com>
Date: Wed, 7 Jun 2023 13:00:37 +0000 (-0400)
Subject: lava: Use absolute directory for coredumps
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=be9c2b195fb8f58b472f444c7f86854f5e0f5e95;p=lttng-ci.git

lava: Use absolute directory for coredumps

If any of the scripts or tests modify the working directory in an
unexpected way, assuming that the coredump is relative to the working
directory will cause the jobs to fail.

Eg. https://lava-master-03.internal.efficios.com/scheduler/job/491

Change-Id: I0e6a71c1632109c5b62043dff20df587d81dd943
---

diff --git a/lava/benchmark/babeltrace/benchmark.yml b/lava/benchmark/babeltrace/benchmark.yml
index 3bd1c33..c007114 100644
--- a/lava/benchmark/babeltrace/benchmark.yml
+++ b/lava/benchmark/babeltrace/benchmark.yml
@@ -22,8 +22,8 @@ run:
                 - apt install -y curl python3
                 - git clone https://github.com/lttng/lttng-ci ci
                 - export TMPDIR="/tmp"
-                - mkdir -p coredump
-                - echo "$(pwd)/coredump/core.%e.%p.%h.%t" > /proc/sys/kernel/core_pattern
+                - mkdir -p /tmp/coredump
+                - echo "/tmp/coredump/core.%e.%p.%h.%t" > /proc/sys/kernel/core_pattern
                 - ulimit -c unlimited
                 - mkdir /tmp/ram_disk
                 - mount -t tmpfs -o size=10024m new_ram_disk /tmp/ram_disk
diff --git a/lava/system-tests/kernel-tests.yml b/lava/system-tests/kernel-tests.yml
index b1a5513..a5e8e8e 100644
--- a/lava/system-tests/kernel-tests.yml
+++ b/lava/system-tests/kernel-tests.yml
@@ -10,8 +10,8 @@ run:
                 - apt install -y curl
                 - git clone "${CI_REPO}" --branch="${CI_BRANCH}" ci
                 - export TMPDIR="/tmp"
-                - mkdir -p coredump
-                - echo "$(pwd)/coredump/core.%e.%p.%h.%t" > /proc/sys/kernel/core_pattern
+                - mkdir -p /tmp/coredump
+                - echo "/tmp/coredump/core.%e.%p.%h.%t" > /proc/sys/kernel/core_pattern
                 - ulimit -c unlimited
                 - source /root/lttngvenv/activate
                 - pushd /root/lttngvenv/src/lttng-tools
@@ -19,5 +19,5 @@ run:
                 - systemctl stop systemd-timesyncd.service
                 - lava-test-case run-tests --shell "$(dirs -l +1)/ci/scripts/system-tests/run-test-suites.sh ${LTTNG_VERSION_STRING}"
                 - systemctl start systemd-timesyncd.service
-                - tar czf coredump.tar.gz coredump
+                - tar czf coredump.tar.gz /tmp/coredump
                 - ./ci/lava/upload_artifact.sh coredump.tar.gz coredump.tar.gz "results/${JENKINS_BUILD_ID}/${TESTRUN_ID}-coredump.tar.gz"
diff --git a/lava/system-tests/perf-tests.yml b/lava/system-tests/perf-tests.yml
index 0355d82..6cd2e4e 100644
--- a/lava/system-tests/perf-tests.yml
+++ b/lava/system-tests/perf-tests.yml
@@ -10,8 +10,8 @@ run:
                 - apt install -y libpfm4-dev curl
                 - git clone "${CI_REPO}" --branch="${CI_BRANCH}" ci
                 - export TMPDIR="/tmp"
-                - mkdir -p coredump
-                - echo "$(pwd)/coredump/core.%e.%p.%h.%t" > /proc/sys/kernel/core_pattern
+                - mkdir -p /tmp/coredump
+                - echo "/tmp/coredump/core.%e.%p.%h.%t" > /proc/sys/kernel/core_pattern
                 - ulimit -c unlimited
                 - source /root/lttngvenv/activate
                 - pushd /root/lttngvenv/src/lttng-tools
@@ -20,5 +20,5 @@ run:
                 #Need to check if the file is present for branches where the testcase was not backported
                 - lava-test-case run-tests --shell "if [ -e perf_regression ]; then prove --nocolor --verbose --merge --exec '' - < perf_regression; else echo 'perf_regression not found'; fi"
                 - popd
-                - tar czf coredump.tar.gz coredump
+                - tar czf coredump.tar.gz /tmp/coredump
                 - ./ci/lava/upload_artifact.sh coredump.tar.gz coredump.tar.gz "results/${JENKINS_BUILD_ID}/${TESTRUN_ID}-coredump.tar.gz"