From: Michael Jeanson Date: Mon, 7 Mar 2022 16:37:49 +0000 (-0500) Subject: fix: warning '-Wstringop-truncation' with GCC 11.2 X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=b43eb2f612ab4a816c9c1d8f3ba3346cd722074e;p=lttng-tools.git fix: warning '-Wstringop-truncation' with GCC 11.2 Building with GCC 11.2 results in the following warning : In file included from ../../src/common/tracker.h:18, from ../../src/bin/lttng-sessiond/trace-ust.h:17, from test_ust_data.cpp:19: ../../src/common/sessiond-comm/sessiond-comm.h:569:14: note: while referencing ‘lttng_event_exclusion::names’ 569 | char names[0][LTTNG_SYMBOL_NAME_LEN]; | ^~~~~ test_ust_data.cpp:209:16: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 256 equals destination size [-Wstringop-truncation] 209 | strncpy(LTTNG_EVENT_EXCLUSION_NAME_AT(exclusion, 0), | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 210 | get_random_string(), LTTNG_SYMBOL_NAME_LEN); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test_ust_data.cpp:211:16: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 256 equals destination size [-Wstringop-truncation] 211 | strncpy(LTTNG_EVENT_EXCLUSION_NAME_AT(exclusion, 1), | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 212 | get_random_string(), LTTNG_SYMBOL_NAME_LEN); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I78eea760b4684227ee457c3368c6397d0a767af5 Signed-off-by: Michael Jeanson Signed-off-by: Jérémie Galarneau --- diff --git a/tests/unit/test_ust_data.cpp b/tests/unit/test_ust_data.cpp index b35576742..ee566f395 100644 --- a/tests/unit/test_ust_data.cpp +++ b/tests/unit/test_ust_data.cpp @@ -175,9 +175,9 @@ static void test_create_ust_event_exclusion(void) exclusion->count = exclusion_count; random_name = get_random_string(); strncpy(LTTNG_EVENT_EXCLUSION_NAME_AT(exclusion, 0), random_name, - LTTNG_SYMBOL_NAME_LEN); + LTTNG_SYMBOL_NAME_LEN - 1); strncpy(LTTNG_EVENT_EXCLUSION_NAME_AT(exclusion, 1), random_name, - LTTNG_SYMBOL_NAME_LEN); + LTTNG_SYMBOL_NAME_LEN - 1); ret = trace_ust_create_event(&ev, NULL, NULL, exclusion, false, &event); exclusion = NULL; @@ -207,9 +207,9 @@ static void test_create_ust_event_exclusion(void) exclusion->count = exclusion_count; strncpy(LTTNG_EVENT_EXCLUSION_NAME_AT(exclusion, 0), - get_random_string(), LTTNG_SYMBOL_NAME_LEN); + get_random_string(), LTTNG_SYMBOL_NAME_LEN - 1); strncpy(LTTNG_EVENT_EXCLUSION_NAME_AT(exclusion, 1), - get_random_string(), LTTNG_SYMBOL_NAME_LEN); + get_random_string(), LTTNG_SYMBOL_NAME_LEN - 1); exclusion_copy->count = exclusion_count; strncpy(LTTNG_EVENT_EXCLUSION_NAME_AT(exclusion_copy, 0),