From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Wed, 4 Sep 2019 22:29:58 +0000 (-0400)
Subject: Fix: chunk state is not set when relayd does not support trace chunks
X-Git-Tag: v2.11.0-rc3~14
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=b04180f959e0785dda603a1699469bae80da009d;p=lttng-tools.git

Fix: chunk state is not set when relayd does not support trace chunks

Being explicit here enforces that for a lttng-relayd that does not
support chunks, the queried chunk will never exist.

This caused a lttng destroy command to hang during backward
compatibility testing with older lttng-relayd.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/relayd/relayd.c b/src/common/relayd/relayd.c
index 49997015e..a9c2bb2c3 100644
--- a/src/common/relayd/relayd.c
+++ b/src/common/relayd/relayd.c
@@ -1480,6 +1480,8 @@ int relayd_trace_chunk_exists(struct lttcomm_relayd_sock *sock,
 
 	if (!relayd_supports_chunks(sock)) {
 		DBG("Refusing to check for trace chunk existence: relayd does not support chunks");
+		/* The chunk will never exist */
+		*chunk_exists = false;
 		goto end;
 	}