From: Michael Jeanson <mjeanson@efficios.com>
Date: Mon, 16 May 2016 23:33:08 +0000 (-0400)
Subject: Fix: Add missing free() in spawn_viewer
X-Git-Tag: v2.8.0~54
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=ae0ad956e8a756ce374d1ead9cb6c501ef54a6fc;p=lttng-tools.git

Fix: Add missing free() in spawn_viewer

Fixes coverity #1291948

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng/commands/view.c b/src/bin/lttng/commands/view.c
index 09acc30f4..db13ee227 100644
--- a/src/bin/lttng/commands/view.c
+++ b/src/bin/lttng/commands/view.c
@@ -253,12 +253,12 @@ static int spawn_viewer(const char *trace_path)
 		} else {
 			PERROR("exec: %s", viewer_bin);
 		}
-		free(argv);
 		ret = CMD_FATAL;
 		goto error;
 	}
 
 error:
+	free(argv);
 	return ret;
 }