From: Mathieu Desnoyers Date: Tue, 5 Apr 2016 12:05:42 +0000 (-0400) Subject: Fix: use of uninitialized ret value in lttng_abi_create_event X-Git-Tag: v2.7.3~9 X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=ada2ea9b1894647b0104476c9b47b288950217d4;p=lttng-modules.git Fix: use of uninitialized ret value in lttng_abi_create_event Fixes the following compiler warning: /home/jenkins/workspace/lttng-modules_VERSION_param-build/arch/x86-32/src/lttng-modules/lttng-abi.c: In function ‘lttng_abi_create_event’: /home/jenkins/workspace/lttng-modules_VERSION_param-build/arch/x86-32/src/lttng-modules/lttng-abi.c:987:16: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] int event_fd, ret; Signed-off-by: Mathieu Desnoyers --- diff --git a/lttng-abi.c b/lttng-abi.c index b51434a1..9845930d 100644 --- a/lttng-abi.c +++ b/lttng-abi.c @@ -993,6 +993,7 @@ int lttng_abi_create_event(struct file *channel_file, /* The event holds a reference on the channel */ if (atomic_long_add_unless(&channel_file->f_count, 1, INT_MAX) == INT_MAX) { + ret = -EOVERFLOW; goto refcount_error; } if (event_param->instrumentation == LTTNG_KERNEL_TRACEPOINT