From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 16 Jun 2021 19:08:21 +0000 (-0400)
Subject: Fix: rotation client example: leak of handle on error
X-Git-Tag: v2.12.5~5
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=a41134074c65a36cd818e22a99493b0be8199f36;p=lttng-tools.git

Fix: rotation client example: leak of handle on error

1452927 Resource leak

The system resource will not be reclaimed and reused, reducing the
future availability of the resource.

In setup_session: Leak of memory or pointers to system
resources (CWE-404)

CID 1452927 (#1 of 1): Resource leak (RESOURCE_LEAK)8. leaked_storage:
Variable chan_handle going out of scope leaks the storage it points to

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I4c215ac4a86f9f70fd5c9d3aa13f944d3d7a2cc7
---

diff --git a/doc/examples/rotation/rotate-client-example.c b/doc/examples/rotation/rotate-client-example.c
index a9d8b9f31..34287e8bb 100644
--- a/doc/examples/rotation/rotate-client-example.c
+++ b/doc/examples/rotation/rotate-client-example.c
@@ -61,7 +61,7 @@ int setup_session(const char *session_name, const char *path)
 	int ret;
 	struct lttng_domain dom;
 	struct lttng_event ev;
-	struct lttng_handle *chan_handle;
+	struct lttng_handle *chan_handle = NULL;
 
 	printf("Creating session %s\n", session_name);
 	ret = lttng_create_session(session_name, path);
@@ -98,11 +98,10 @@ int setup_session(const char *session_name, const char *path)
 		goto end;
 	}
 
-	lttng_destroy_handle(chan_handle);
-
 	ret = 0;
 
 end:
+	lttng_destroy_handle(chan_handle);
 	return ret;
 }