From: Michael Jeanson <mjeanson@efficios.com>
Date: Mon, 16 Dec 2024 20:02:23 +0000 (-0500)
Subject: fix: add missing check for __must_check 'lttng_file_ref_put()' (v6.13)
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=a374f2e44494ac3275b3823c4583c528192bb718;p=lttng-modules.git

fix: add missing check for __must_check 'lttng_file_ref_put()' (v6.13)

Add a missing return code check to a call to 'lttng_file_ref_put()'
which is marked as 'must_check', otherwise it results in a build
failure when using -Werror.

Change-Id: Ib50ec669ffc0fe87a367b25b788518d148f7a85e
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/src/lttng-events.c b/src/lttng-events.c
index 648a6605..ddd82272 100644
--- a/src/lttng-events.c
+++ b/src/lttng-events.c
@@ -2074,7 +2074,9 @@ int lttng_session_list_tracker_ids(struct lttng_kernel_session *session,
 	return file_fd;
 
 open_error:
-	lttng_file_ref_put(session->priv->file);
+	if (!lttng_file_ref_put(session->priv->file)) {
+		/* Don't change return code */
+	}
 refcount_error:
 	fput(tracker_ids_list_file);
 file_error: