From: Francis Deslauriers <francis.deslauriers@efficios.com>
Date: Tue, 1 Oct 2019 20:06:04 +0000 (-0400)
Subject: Fix: common: Dereference after null check
X-Git-Tag: v2.11.0~32
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=979ee28a8a3276b7835cc40e0e0e989bc7f624b8;p=lttng-tools.git

Fix: common: Dereference after null check

Coverity report:
  CID 1404929 (#1 of 1): Dereference after null check (FORWARD_NULL)
  25. var_deref_model: Passing null pointer directory_to_rename to
  lttng_directory_handle_rename_as_user, which dereferences it.

Reported-by: Coverity (1404929) Dereference after null check
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/trace-chunk.c b/src/common/trace-chunk.c
index affe3ac20..afba60b38 100644
--- a/src/common/trace-chunk.c
+++ b/src/common/trace-chunk.c
@@ -975,6 +975,7 @@ void lttng_trace_chunk_move_to_completed(struct lttng_trace_chunk *trace_chunk)
 				creation_timestamp, NULL);
 		if (!directory_to_rename) {
 			ERR("Failed to generate initial trace chunk name while renaming trace chunk");
+			goto end;
 		}
 		free_directory_to_rename = true;
 	}