From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Tue, 1 Mar 2022 14:50:06 +0000 (-0500)
Subject: Fix: ser/des: missing null terminator on payload append
X-Git-Tag: v2.12.9~24
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=8e97f69dedae2825b594a18994be990c770e7f53;p=lttng-tools.git

Fix: ser/des: missing null terminator on payload append

Reported by the lttng-ust-java-tests_master_build CI job.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I47b048c65a9855347c9b02fe44d9fdbae7e06dbf
---

diff --git a/src/common/event.c b/src/common/event.c
index b90bc2a2f..af4a4b1a3 100644
--- a/src/common/event.c
+++ b/src/common/event.c
@@ -1197,7 +1197,8 @@ static int lttng_event_context_app_serialize(
 	}
 
 	/* Include the null terminator. */
-	comm.provider_name_len = provider_len + 1;
+	provider_len += 1;
+	comm.provider_name_len = provider_len;
 
 	ctx_len = strlen(ctx_name);
 	if (ctx_len == 0) {
@@ -1206,7 +1207,8 @@ static int lttng_event_context_app_serialize(
 	}
 
 	/* Include the null terminator. */
-	comm.ctx_name_len = ctx_len + 1;
+	ctx_len += 1;
+	comm.ctx_name_len = ctx_len;
 
 	/* Header */
 	ret = lttng_dynamic_buffer_append(buffer, &comm, sizeof(comm));