From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 12 Dec 2018 02:26:42 +0000 (-0500)
Subject: Fix: use assignment-suppression for unused sscanf arguments
X-Git-Tag: v2.11.0-rc2~103
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=859597f18697d7187c65c7860c0c5ebd7c22cde4;p=lttng-tools.git

Fix: use assignment-suppression for unused sscanf arguments

This removes the conversion of elements parsed by sscanf() which
are not used anyhow and eliminates a warning on x86 builds
(%lu used on size_t).

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng/commands/enable_events.c b/src/bin/lttng/commands/enable_events.c
index f7c5553da..b4e6320c5 100644
--- a/src/bin/lttng/commands/enable_events.c
+++ b/src/bin/lttng/commands/enable_events.c
@@ -305,12 +305,10 @@ end:
  */
 static int warn_userspace_probe_syntax(const char *symbol)
 {
-	unsigned long addr = 0;
-	size_t offset = 0;
 	int ret;
 
 	/* Check if the symbol field is an hex address. */
-	ret = sscanf(symbol, "0x%lx", &addr);
+	ret = sscanf(symbol, "0x%*x");
 	if (ret > 0) {
 		/* If there is a match, print a warning and return an error. */
 		ERR("Userspace probe on address not supported yet.");
@@ -319,7 +317,7 @@ static int warn_userspace_probe_syntax(const char *symbol)
 	}
 
 	/* Check if the symbol field is an decimal address. */
-	ret = sscanf(symbol, "%lu", &addr);
+	ret = sscanf(symbol, "%*u");
 	if (ret > 0) {
 		/* If there is a match, print a warning and return an error. */
 		ERR("Userspace probe on address not supported yet.");
@@ -328,7 +326,7 @@ static int warn_userspace_probe_syntax(const char *symbol)
 	}
 
 	/* Check if the symbol field is symbol+hex_offset. */
-	ret = sscanf(symbol, "%*[^+]+0x%lx", &offset);
+	ret = sscanf(symbol, "%*[^+]+0x%*x");
 	if (ret > 0) {
 		/* If there is a match, print a warning and return an error. */
 		ERR("Userspace probe on symbol+offset not supported yet.");
@@ -337,7 +335,7 @@ static int warn_userspace_probe_syntax(const char *symbol)
 	}
 
 	/* Check if the symbol field is symbol+decimal_offset. */
-	ret = sscanf(symbol, "%*[^+]+%lu", &offset);
+	ret = sscanf(symbol, "%*[^+]+%*u");
 	if (ret > 0) {
 		/* If there is a match, print a warning and return an error. */
 		ERR("Userspace probe on symbol+offset not supported yet.");