From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Thu, 14 May 2015 22:29:58 +0000 (-0400)
Subject: Fix: missing statedump end event when block device listing available
X-Git-Tag: v2.7.0-rc1~17
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=84c7055e17f9bf7628fe1004db732d932ed2a77b;p=lttng-modules.git

Fix: missing statedump end event when block device listing available

Incorrect handling of lttng_enumerate_block_devices() return value of 0
(which means "ok"), causing do_lttng_statedump() to return early.

To causes missing "lttng_statedump_end" in traces where block device
enumeration is available (CONFIG_KALLSYMS=y).

Reported-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/lttng-statedump-impl.c b/lttng-statedump-impl.c
index fcbdfa58..dddd34dd 100644
--- a/lttng-statedump-impl.c
+++ b/lttng-statedump-impl.c
@@ -522,6 +522,8 @@ int do_lttng_statedump(struct lttng_session *session)
 		return ret;
 	ret = lttng_enumerate_block_devices(session);
 	switch (ret) {
+	case 0:
+		break;
 	case -ENOSYS:
 		printk(KERN_WARNING "LTTng: block device enumeration is not supported by kernel\n");
 		break;