From: Philippe Proulx <eeppeliteloop@gmail.com>
Date: Tue, 13 Jul 2021 14:48:19 +0000 (-0400)
Subject: lttng_strerror(): accept positive and negative codes
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=8346beb68a50caf0b63edaca526250c0068f66d3;p=lttng-tools.git

lttng_strerror(): accept positive and negative codes

Some functions return positive `lttng_error_code` enumerator values
while other return negative values.

Make lttng_strerror() accept positive and negative codes. This improves
the API UX and will make the documentation less complex.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I359cef98ae32991d1a01b7f2cd484ece7bab2df9
---

diff --git a/src/lib/lttng-ctl/lttng-ctl.cpp b/src/lib/lttng-ctl/lttng-ctl.cpp
index d4ec1c81b..63841df40 100644
--- a/src/lib/lttng-ctl/lttng-ctl.cpp
+++ b/src/lib/lttng-ctl/lttng-ctl.cpp
@@ -1769,10 +1769,14 @@ int lttng_list_syscalls(struct lttng_event **events)
 
 /*
  * Returns a human readable string describing
- * the error code (a negative value).
+ * the error code (positive or negative value).
  */
 const char *lttng_strerror(int code)
 {
+	if (code > 0) {
+		code = -code;
+	}
+
 	return error_get_str(code);
 }